WARNING: 'funtion' may be misspelled - perhaps 'function'? #7: same driver. Added PHY_ID and probe funtion to check which version is ^^^^^^^ CHECK: Alignment should match open parenthesis #183: FILE: drivers/net/phy/dp83tg720.c:421: + DP83TG720 = devm_kzalloc(&phydev->mdio.dev, sizeof(*DP83TG720), + GFP_KERNEL); WARNING: please, no spaces at the start of a line #209: FILE: drivers/net/phy/dp83tg720.c:447: + PHY_ID_MATCH_EXACT(_id), \$ WARNING: please, no spaces at the start of a line #210: FILE: drivers/net/phy/dp83tg720.c:448: + .name = (_name), \$ WARNING: please, no spaces at the start of a line #211: FILE: drivers/net/phy/dp83tg720.c:449: + .probe = dp83tg720_probe, \$ WARNING: please, no spaces at the start of a line #212: FILE: drivers/net/phy/dp83tg720.c:450: + .flags = PHY_POLL_CABLE_TEST, \$ WARNING: please, no spaces at the start of a line #213: FILE: drivers/net/phy/dp83tg720.c:451: + .config_aneg = dp83tg720_config_aneg, \$ WARNING: please, no spaces at the start of a line #214: FILE: drivers/net/phy/dp83tg720.c:452: + .read_status = dp83tg720_read_status, \$ WARNING: please, no spaces at the start of a line #215: FILE: drivers/net/phy/dp83tg720.c:453: + .get_features = genphy_c45_pma_read_ext_abilities, \$ WARNING: please, no spaces at the start of a line #216: FILE: drivers/net/phy/dp83tg720.c:454: + .config_init = dp83tg720_config_init, \$ WARNING: please, no spaces at the start of a line #217: FILE: drivers/net/phy/dp83tg720.c:455: + .get_sqi = dp83tg720_get_sqi, \$ WARNING: please, no spaces at the start of a line #218: FILE: drivers/net/phy/dp83tg720.c:456: + .get_sqi_max = dp83tg720_get_sqi_max, \$ WARNING: please, no spaces at the start of a line #219: FILE: drivers/net/phy/dp83tg720.c:457: + .cable_test_start = dp83tg720_cable_test_start, \$ WARNING: please, no spaces at the start of a line #220: FILE: drivers/net/phy/dp83tg720.c:458: + .cable_test_get_status = dp83tg720_cable_test_get_status, \$ WARNING: please, no spaces at the start of a line #221: FILE: drivers/net/phy/dp83tg720.c:459: + .suspend = genphy_suspend, \$ WARNING: please, no spaces at the start of a line #222: FILE: drivers/net/phy/dp83tg720.c:460: + .resume = genphy_resume, \$ WARNING: please, no spaces at the start of a line #226: FILE: drivers/net/phy/dp83tg720.c:464: + DP83TG720_PHY_DRIVER(DP83TG720_CS_1_1_PHY_ID, "TI DP83TG720CS1.1"),$ WARNING: please, no spaces at the start of a line #234: FILE: drivers/net/phy/dp83tg720.c:470: + { PHY_ID_MATCH_EXACT(DP83TG720_CS_1_1_PHY_ID) },$ WARNING: please, no space before tabs #242: FILE: drivers/net/phy/dp83tg720.c:478: +// ^IPHY_ID_MATCH_MODEL(DP83TG720_PHY_ID),$ WARNING: please, no space before tabs #243: FILE: drivers/net/phy/dp83tg720.c:479: +// ^I.name^I^I= "TI DP83TG720",$ WARNING: please, no space before tabs #245: FILE: drivers/net/phy/dp83tg720.c:481: +// ^I.flags = PHY_POLL_CABLE_TEST,$ WARNING: please, no space before tabs #246: FILE: drivers/net/phy/dp83tg720.c:482: +// ^I.config_aneg^I= dp83tg720_config_aneg,$ WARNING: please, no space before tabs #247: FILE: drivers/net/phy/dp83tg720.c:483: +// ^I.read_status^I= dp83tg720_read_status,$ WARNING: please, no space before tabs #248: FILE: drivers/net/phy/dp83tg720.c:484: +// ^I.get_features^I= genphy_c45_pma_read_ext_abilities,$ WARNING: please, no space before tabs #249: FILE: drivers/net/phy/dp83tg720.c:485: +// ^I.config_init^I= dp83tg720_config_init,$ WARNING: please, no space before tabs #250: FILE: drivers/net/phy/dp83tg720.c:486: +// ^I.get_sqi^I= dp83tg720_get_sqi,$ WARNING: please, no space before tabs #251: FILE: drivers/net/phy/dp83tg720.c:487: +// ^I.get_sqi_max^I= dp83tg720_get_sqi_max,$ WARNING: please, no space before tabs #252: FILE: drivers/net/phy/dp83tg720.c:488: +// ^I.cable_test_start = dp83tg720_cable_test_start,$ WARNING: please, no space before tabs #253: FILE: drivers/net/phy/dp83tg720.c:489: +// ^I.cable_test_get_status = dp83tg720_cable_test_get_status,$ WARNING: please, no space before tabs #255: FILE: drivers/net/phy/dp83tg720.c:491: +// ^I.suspend^I= genphy_suspend,$ WARNING: please, no space before tabs #256: FILE: drivers/net/phy/dp83tg720.c:492: +// ^I.resume^I^I= genphy_resume,$ WARNING: please, no space before tabs #261: FILE: drivers/net/phy/dp83tg720.c:497: +// ^I{ PHY_ID_MATCH_MODEL(DP83TG720_PHY_ID) },$ WARNING: please, no space before tabs #262: FILE: drivers/net/phy/dp83tg720.c:498: +// ^I{ }$ total: 0 errors, 32 warnings, 1 checks, 244 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e783e55a1f56 ("net: phy: dp83tg720: Extending support to DP83TG721 PHY") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 32 warnings, 1 checks, 244 lines checked