========== checkpatch - FAILED CHECK: Alignment should match open parenthesis #264: FILE: drivers/net/phy/dp83tg720.c:352: + ret = phy_write_mmd(phydev, MMD1F, DP83TG720_PHY_RESET_CTRL, + DP83TG720_HW_RESET); CHECK: Alignment should match open parenthesis #267: FILE: drivers/net/phy/dp83tg720.c:355: + ret = phy_write_mmd(phydev, MMD1F, DP83TG720_PHY_RESET_CTRL, + DP83TG720_SW_RESET); WARNING: line length of 82 exceeds 80 columns #292: FILE: drivers/net/phy/dp83tg720.c:380: + const struct DP83TG720_init_reg *init_data, int size) CHECK: Alignment should match open parenthesis #292: FILE: drivers/net/phy/dp83tg720.c:380: +static int DP83TG720_write_seq(struct phy_device *phydev, + const struct DP83TG720_init_reg *init_data, int size) WARNING: suspect code indent for conditional statements (8, 24) #297: FILE: drivers/net/phy/dp83tg720.c:385: + for (i = 0; i < size; i++) { + ret = phy_write_mmd(phydev, init_data[i].MMD, init_data[i].reg, WARNING: line length of 87 exceeds 80 columns #298: FILE: drivers/net/phy/dp83tg720.c:386: + ret = phy_write_mmd(phydev, init_data[i].MMD, init_data[i].reg, CHECK: Alignment should match open parenthesis #299: FILE: drivers/net/phy/dp83tg720.c:387: + ret = phy_write_mmd(phydev, init_data[i].MMD, init_data[i].reg, + init_data[i].val); WARNING: suspect code indent for conditional statements (24, 40) #300: FILE: drivers/net/phy/dp83tg720.c:388: + if (ret) + return ret; ERROR: trailing whitespace #322: FILE: drivers/net/phy/dp83tg720.c:638: +^I$ WARNING: please, no spaces at the start of a line #324: FILE: drivers/net/phy/dp83tg720.c:640: + phydev->speed = SPEED_1000;$ WARNING: please, no spaces at the start of a line #326: FILE: drivers/net/phy/dp83tg720.c:642: + linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, phydev->supported);$ WARNING: line length of 86 exceeds 80 columns #331: FILE: drivers/net/phy/dp83tg720.c:647: + ret = DP83TG720_write_seq(phydev, DP83TG720_cs1_1_master_init, WARNING: line length of 89 exceeds 80 columns #332: FILE: drivers/net/phy/dp83tg720.c:648: + ARRAY_SIZE(DP83TG720_cs1_1_master_init)); CHECK: Alignment should match open parenthesis #332: FILE: drivers/net/phy/dp83tg720.c:648: + ret = DP83TG720_write_seq(phydev, DP83TG720_cs1_1_master_init, + ARRAY_SIZE(DP83TG720_cs1_1_master_init)); WARNING: line length of 85 exceeds 80 columns #334: FILE: drivers/net/phy/dp83tg720.c:650: + ret = DP83TG720_write_seq(phydev, DP83TG720_cs1_1_slave_init, WARNING: line length of 88 exceeds 80 columns #335: FILE: drivers/net/phy/dp83tg720.c:651: + ARRAY_SIZE(DP83TG720_cs1_1_slave_init)); CHECK: Alignment should match open parenthesis #335: FILE: drivers/net/phy/dp83tg720.c:651: + ret = DP83TG720_write_seq(phydev, DP83TG720_cs1_1_slave_init, + ARRAY_SIZE(DP83TG720_cs1_1_slave_init)); WARNING: line length of 84 exceeds 80 columns #342: FILE: drivers/net/phy/dp83tg720.c:658: + ret = DP83TG720_write_seq(phydev, DP83TG721_cs1_master_init, WARNING: line length of 87 exceeds 80 columns #343: FILE: drivers/net/phy/dp83tg720.c:659: + ARRAY_SIZE(DP83TG721_cs1_master_init)); CHECK: Alignment should match open parenthesis #343: FILE: drivers/net/phy/dp83tg720.c:659: + ret = DP83TG720_write_seq(phydev, DP83TG721_cs1_master_init, + ARRAY_SIZE(DP83TG721_cs1_master_init)); WARNING: line length of 83 exceeds 80 columns #345: FILE: drivers/net/phy/dp83tg720.c:661: + ret = DP83TG720_write_seq(phydev, DP83TG721_cs1_slave_init, WARNING: line length of 86 exceeds 80 columns #346: FILE: drivers/net/phy/dp83tg720.c:662: + ARRAY_SIZE(DP83TG721_cs1_slave_init)); CHECK: Alignment should match open parenthesis #346: FILE: drivers/net/phy/dp83tg720.c:662: + ret = DP83TG720_write_seq(phydev, DP83TG721_cs1_slave_init, + ARRAY_SIZE(DP83TG721_cs1_slave_init)); WARNING: line length of 94 exceeds 80 columns #359: FILE: drivers/net/phy/dp83tg720.c:675: + ret = phy_write_mmd(phydev, MMD1F, DP83TG720_LPS_CFG3, DP83TG720_LPS_CFG3_PWR_MODE_0); WARNING: line length of 113 exceeds 80 columns #387: FILE: drivers/net/phy/dp83tg720.c:768: + .soft_reset = dp83tg720_phy_reset, \ total: 1 errors, 16 warnings, 8 checks, 397 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 99d5577d31e4 ("net: phy: dp83tg720: Added OA script") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.