WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #58: new file mode 100644 ERROR: trailing whitespace #84: FILE: tools/testing/selftests/net/ovpn/Makefile:14: +^Ifloat-test.sh $ WARNING: line length of 100 exceeds 80 columns #148: FILE: tools/testing/selftests/net/ovpn/data-test.sh:26: + ip link add veth${p} netns peer0 type veth peer name veth${p} netns peer${p} WARNING: line length of 95 exceeds 80 columns #166: FILE: tools/testing/selftests/net/ovpn/data-test.sh:44: + ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 1 ${UDP_PEERS_FILE} WARNING: line length of 122 exceeds 80 columns #169: FILE: tools/testing/selftests/net/ovpn/data-test.sh:47: + # ip netns exec peer0 ${OVPN_CLI} new_peer tun0 ${p} ${p} 10.10.${p}.2 1 5.5.5.$((${p} + 1)) WARNING: line length of 105 exceeds 80 columns #171: FILE: tools/testing/selftests/net/ovpn/data-test.sh:49: + ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 ${ALG} 0 data64.key WARNING: line length of 97 exceeds 80 columns #174: FILE: tools/testing/selftests/net/ovpn/data-test.sh:52: + ip netns exec peer${1} ${OVPN_CLI} new_peer tun${1} 1 ${1} 10.10.${1}.1 1 WARNING: line length of 103 exceeds 80 columns #175: FILE: tools/testing/selftests/net/ovpn/data-test.sh:53: + ip netns exec peer${1} ${OVPN_CLI} new_key tun${1} ${1} 1 0 ${ALG} 1 data64.key WARNING: line length of 93 exceeds 80 columns #179: FILE: tools/testing/selftests/net/ovpn/data-test.sh:57: + (ip netns exec peer0 ${OVPN_CLI} listen tun0 1 ${TCP_PEERS_FILE} && { WARNING: line length of 113 exceeds 80 columns #181: FILE: tools/testing/selftests/net/ovpn/data-test.sh:59: + ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 ${ALG} 0 data64.key WARNING: line length of 105 exceeds 80 columns #186: FILE: tools/testing/selftests/net/ovpn/data-test.sh:64: + ip netns exec peer${1} ${OVPN_CLI} connect tun${1} ${1} 10.10.${1}.1 1 data64.key WARNING: line length of 88 exceeds 80 columns #196: FILE: tools/testing/selftests/net/ovpn/data-test.sh:74: + ip netns exec peer${p} ${OVPN_CLI} del_iface tun${p} 2>/dev/null || true WARNING: line length of 81 exceeds 80 columns #235: FILE: tools/testing/selftests/net/ovpn/data-test.sh:113: + ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 2 1 ${ALG} 0 data64.key WARNING: line length of 87 exceeds 80 columns #236: FILE: tools/testing/selftests/net/ovpn/data-test.sh:114: + ip netns exec peer${p} ${OVPN_CLI} new_key tun${p} ${p} 2 1 ${ALG} 1 data64.key WARNING: line length of 100 exceeds 80 columns #315: FILE: tools/testing/selftests/net/ovpn/float-test.sh:26: + ip link add veth${p} netns peer0 type veth peer name veth${p} netns peer${p} WARNING: line length of 95 exceeds 80 columns #333: FILE: tools/testing/selftests/net/ovpn/float-test.sh:44: + ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 1 ${UDP_PEERS_FILE} WARNING: line length of 122 exceeds 80 columns #336: FILE: tools/testing/selftests/net/ovpn/float-test.sh:47: + # ip netns exec peer0 ${OVPN_CLI} new_peer tun0 ${p} ${p} 10.10.${p}.2 1 5.5.5.$((${p} + 1)) WARNING: line length of 105 exceeds 80 columns #337: FILE: tools/testing/selftests/net/ovpn/float-test.sh:48: + ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 ${ALG} 0 data64.key WARNING: line length of 97 exceeds 80 columns #340: FILE: tools/testing/selftests/net/ovpn/float-test.sh:51: + ip netns exec peer${1} ${OVPN_CLI} new_peer tun${1} 1 ${1} 10.10.${1}.1 1 WARNING: line length of 103 exceeds 80 columns #341: FILE: tools/testing/selftests/net/ovpn/float-test.sh:52: + ip netns exec peer${1} ${OVPN_CLI} new_key tun${1} ${1} 1 0 ${ALG} 1 data64.key WARNING: line length of 93 exceeds 80 columns #345: FILE: tools/testing/selftests/net/ovpn/float-test.sh:56: + (ip netns exec peer0 ${OVPN_CLI} listen tun0 1 ${TCP_PEERS_FILE} && { WARNING: line length of 113 exceeds 80 columns #347: FILE: tools/testing/selftests/net/ovpn/float-test.sh:58: + ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 ${ALG} 0 data64.key WARNING: line length of 113 exceeds 80 columns #352: FILE: tools/testing/selftests/net/ovpn/float-test.sh:63: + ip netns exec peer${1} ${OVPN_CLI} connect tun${1} ${1} 10.10.${1}.1 1 5.5.5.1 data64.key WARNING: line length of 88 exceeds 80 columns #362: FILE: tools/testing/selftests/net/ovpn/float-test.sh:73: + ip netns exec peer${p} ${OVPN_CLI} del_iface tun${p} 2>/dev/null || true WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #633: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:223: +static int ovpn_nl_cb_error(struct sockaddr_nl (*nla)__attribute__((unused)), WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #678: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:268: +static int ovpn_nl_cb_finish(struct nl_msg (*msg)__attribute__((unused)), WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #687: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:277: +static int ovpn_nl_cb_ack(struct nl_msg (*msg)__attribute__((unused)), WARNING: line length of 85 exceeds 80 columns #1451: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:1041: + grp->group, nla_len(tb_mcgrp[CTRL_ATTR_MCAST_GRP_NAME]))) total: 1 errors, 27 warnings, 0 checks, 2143 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit b37ff23a5254 ("testing/selftest: add test tool and scripts for ovpn module") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.