CHECK: spaces preferred around that '/' (ctx:VxO) #38: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:775: +__description("SDIV64, overflow, LLONG_MIN/-1") ^ ERROR: space required before that '-' (ctx:OxV) #38: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:775: +__description("SDIV64, overflow, LLONG_MIN/-1") ^ ERROR: spaces required around that ':' (ctx:VxW) #41: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:778: +__xlated("0: r2 = 0x8000000000000000") ^ ERROR: spaces required around that ':' (ctx:VxW) #42: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:779: +__xlated("2: r3 = -1") ^ ERROR: spaces required around that ':' (ctx:VxW) #43: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:780: +__xlated("3: r4 = r2") ^ ERROR: spaces required around that ':' (ctx:VxW) #44: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:781: +__xlated("4: if r3 != 0x0 goto pc+2") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #44: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:781: +__xlated("4: if r3 != 0x0 goto pc+2") ^ ERROR: spaces required around that ':' (ctx:VxW) #45: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:782: +__xlated("5: w2 ^= w2") ^ ERROR: spaces required around that ':' (ctx:VxW) #46: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:783: +__xlated("6: goto pc+8") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #46: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:783: +__xlated("6: goto pc+8") ^ ERROR: spaces required around that ':' (ctx:VxW) #47: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:784: +__xlated("7: if r3 != 0xffffffff goto pc+6") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #47: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:784: +__xlated("7: if r3 != 0xffffffff goto pc+6") ^ ERROR: spaces required around that ':' (ctx:VxW) #48: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:785: +__xlated("8: r3 = 0x8000000000000000") ^ ERROR: spaces required around that ':' (ctx:VxW) #49: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:786: +__xlated("10: if r2 != r3 goto pc+2") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #49: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:786: +__xlated("10: if r2 != r3 goto pc+2") ^ ERROR: spaces required around that ':' (ctx:VxW) #50: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:787: +__xlated("11: r3 = -1") ^ ERROR: spaces required around that ':' (ctx:VxW) #51: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:788: +__xlated("12: goto pc+2") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #51: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:788: +__xlated("12: goto pc+2") ^ ERROR: spaces required around that ':' (ctx:VxW) #52: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:789: +__xlated("13: r3 = -1") ^ ERROR: spaces required around that ':' (ctx:VxW) #53: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:790: +__xlated("14: r2 s/= r3") ^ ERROR: spaces required around that '/=' (ctx:VxW) #53: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:790: +__xlated("14: r2 s/= r3") ^ ERROR: spaces required around that ':' (ctx:VxW) #54: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:791: +__xlated("15: r0 = 0") ^ ERROR: spaces required around that ':' (ctx:VxW) #55: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:792: +__xlated("16: if r2 != r4 goto pc+1") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #55: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:792: +__xlated("16: if r2 != r4 goto pc+1") ^ ERROR: spaces required around that ':' (ctx:VxW) #56: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:793: +__xlated("17: r0 = 1") ^ ERROR: spaces required around that ':' (ctx:VxW) #57: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:794: +__xlated("18: exit") ^ WARNING: Avoid unnecessary line continuations #60: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:797: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #60: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:797: + asm volatile (" \ CHECK: spaces preferred around that '%' (ctx:WxV) #61: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:798: + r2 = %[llong_min] ll; \ ^ ERROR: spaces required around that '/=' (ctx:VxW) #64: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:801: + r2 s/= r3; \ ^ CHECK: spaces preferred around that '+' (ctx:WxV) #66: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:803: + if r2 != r4 goto +1; \ ^ CHECK: spaces preferred around that '-' (ctx:WxV) #75: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:812: +__description("SDIV64, divisor -1") ^ ERROR: spaces required around that ':' (ctx:VxW) #78: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:815: +__xlated("0: r2 = 5") ^ ERROR: spaces required around that ':' (ctx:VxW) #79: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:816: +__xlated("1: r3 = -1") ^ ERROR: spaces required around that ':' (ctx:VxW) #80: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:817: +__xlated("2: if r3 != 0x0 goto pc+2") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #80: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:817: +__xlated("2: if r3 != 0x0 goto pc+2") ^ ERROR: spaces required around that ':' (ctx:VxW) #81: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:818: +__xlated("3: w2 ^= w2") ^ ERROR: spaces required around that ':' (ctx:VxW) #82: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:819: +__xlated("4: goto pc+8") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #82: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:819: +__xlated("4: goto pc+8") ^ ERROR: spaces required around that ':' (ctx:VxW) #83: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:820: +__xlated("5: if r3 != 0xffffffff goto pc+6") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #83: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:820: +__xlated("5: if r3 != 0xffffffff goto pc+6") ^ ERROR: spaces required around that ':' (ctx:VxW) #84: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:821: +__xlated("6: r3 = 0x8000000000000000") ^ ERROR: spaces required around that ':' (ctx:VxW) #85: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:822: +__xlated("8: if r2 != r3 goto pc+2") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #85: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:822: +__xlated("8: if r2 != r3 goto pc+2") ^ ERROR: spaces required around that ':' (ctx:VxW) #86: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:823: +__xlated("9: r3 = -1") ^ ERROR: spaces required around that ':' (ctx:VxW) #87: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:824: +__xlated("10: goto pc+2") ^ CHECK: spaces preferred around that '+' (ctx:VxV) #87: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:824: +__xlated("10: goto pc+2") ^ ERROR: spaces required around that ':' (ctx:VxW) #88: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:825: +__xlated("11: r3 = -1") ^ ERROR: spaces required around that ':' (ctx:VxW) #89: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:826: +__xlated("12: r2 s/= r3") ^ ERROR: spaces required around that '/=' (ctx:VxW) #89: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:826: +__xlated("12: r2 s/= r3") ^ ERROR: spaces required around that ':' (ctx:VxW) #90: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:827: +__xlated("13: r0 = r2") ^ ERROR: spaces required around that ':' (ctx:VxW) #91: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:828: +__xlated("14: exit") ^ WARNING: Avoid unnecessary line continuations #94: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:831: + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #94: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:831: + asm volatile (" \ ERROR: spaces required around that '/=' (ctx:VxW) #97: FILE: tools/testing/selftests/bpf/progs/verifier_sdiv.c:834: + r2 s/= r3; \ ^ total: 36 errors, 4 warnings, 15 checks, 81 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1e5ccb5eb214 ("selftests/bpf: Add a couple of tests for potential sdiv overflow") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.