CHECK: extern prototypes should be avoided in .h files #43: FILE: tools/testing/selftests/bpf/bpf_experimental.h:579: +extern int bpf_iter_dynptr_new(struct bpf_iter_dynptr *it, struct bpf_dynptr *p, WARNING: line length of 81 exceeds 80 columns #44: FILE: tools/testing/selftests/bpf/bpf_experimental.h:580: + u32 offset, void *buffer, u32 buffer__szk) __ksym; CHECK: extern prototypes should be avoided in .h files #45: FILE: tools/testing/selftests/bpf/bpf_experimental.h:581: +extern int *bpf_iter_dynptr_next(struct bpf_iter_dynptr *it) __ksym; CHECK: extern prototypes should be avoided in .h files #46: FILE: tools/testing/selftests/bpf/bpf_experimental.h:582: +extern int bpf_iter_dynptr_set_buffer(struct bpf_iter_dynptr *it__iter, WARNING: line length of 84 exceeds 80 columns #48: FILE: tools/testing/selftests/bpf/bpf_experimental.h:584: +extern u32 bpf_iter_dynptr_get_last_offset(struct bpf_iter_dynptr *it__iter) __ksym; CHECK: extern prototypes should be avoided in .h files #48: FILE: tools/testing/selftests/bpf/bpf_experimental.h:584: +extern u32 bpf_iter_dynptr_get_last_offset(struct bpf_iter_dynptr *it__iter) __ksym; CHECK: extern prototypes should be avoided in .h files #49: FILE: tools/testing/selftests/bpf/bpf_experimental.h:585: +extern void bpf_iter_dynptr_destroy(struct bpf_iter_dynptr *it) __ksym; WARNING: line length of 81 exceeds 80 columns #71: FILE: tools/testing/selftests/bpf/prog_tests/iters.c:296: +static int subtest_dynptr_iters(struct iters_dynptr *skel, const char *prog_name) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #129: new file mode 100644 WARNING: line length of 81 exceeds 80 columns #167: FILE: tools/testing/selftests/bpf/progs/iters_dynptr.c:34: + bpf_iter_dynptr_new(&dynptr_it, &ptr, 0, read_data1, sizeof(read_data1)); CHECK: Comparison to NULL could be written "!read_len" #172: FILE: tools/testing/selftests/bpf/progs/iters_dynptr.c:39: + if (read_len == NULL) { CHECK: Comparison to NULL could be written "!read_len" #197: FILE: tools/testing/selftests/bpf/progs/iters_dynptr.c:64: + if (read_len == NULL) { CHECK: Alignment should match open parenthesis #213: FILE: tools/testing/selftests/bpf/progs/iters_dynptr.c:80: + if (read_data2[0] != write_data[2] || read_data2[1] != write_data[3] || + read_data2[2] != write_data[4]) { CHECK: Comparison to NULL could be written "read_len" #219: FILE: tools/testing/selftests/bpf/progs/iters_dynptr.c:86: + if (read_len != NULL) CHECK: Comparison to NULL could be written "!read_len" #246: FILE: tools/testing/selftests/bpf/progs/iters_dynptr.c:113: + if (read_len == NULL) { CHECK: Comparison to NULL could be written "read_len" #267: FILE: tools/testing/selftests/bpf/progs/iters_dynptr.c:134: + if (read_len != NULL) total: 0 errors, 5 warnings, 11 checks, 330 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c14da7dc8c06 ("selftests/bpf: Add tests for open-coded style bpf dynamic pointer iterator") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 5 warnings, 11 checks, 330 lines checked