WARNING: Co-developed-by and Signed-off-by: name/email do not match #27: Co-developed-by: Michael Jeanson Signed-off-by: Mathieu Desnoyers WARNING: line length of 84 exceeds 80 columns #106: FILE: include/linux/tracepoint.h:44: +tracepoint_probe_register_prio_flags(struct tracepoint *tp, void *probe, void *data, CHECK: Alignment should match open parenthesis #107: FILE: include/linux/tracepoint.h:45: +tracepoint_probe_register_prio_flags(struct tracepoint *tp, void *probe, void *data, + int prio, unsigned int flags); WARNING: use of RCU tasks trace is incorrect outside BPF or core RCU code #124: FILE: include/linux/tracepoint.h:86: + synchronize_rcu_tasks_trace(); WARNING: Argument 'name' is not used in function-like macro #133: FILE: include/linux/tracepoint.h:189: +#define __DO_TRACE(name, args, cond, rcuidle, tp_flags) \ do { \ int __maybe_unused __idx = 0; \ + bool mayfault = (tp_flags) & TRACEPOINT_MAY_FAULT; \ \ if (!(cond)) \ return; \ WARNING: Argument 'args' is not used in function-like macro #133: FILE: include/linux/tracepoint.h:189: +#define __DO_TRACE(name, args, cond, rcuidle, tp_flags) \ do { \ int __maybe_unused __idx = 0; \ + bool mayfault = (tp_flags) & TRACEPOINT_MAY_FAULT; \ \ if (!(cond)) \ return; \ WARNING: Argument 'rcuidle' is not used in function-like macro #133: FILE: include/linux/tracepoint.h:189: +#define __DO_TRACE(name, args, cond, rcuidle, tp_flags) \ do { \ int __maybe_unused __idx = 0; \ + bool mayfault = (tp_flags) & TRACEPOINT_MAY_FAULT; \ \ if (!(cond)) \ return; \ WARNING: Macros with flow control statements should be avoided #133: FILE: include/linux/tracepoint.h:189: +#define __DO_TRACE(name, args, cond, rcuidle, tp_flags) \ do { \ int __maybe_unused __idx = 0; \ + bool mayfault = (tp_flags) & TRACEPOINT_MAY_FAULT; \ \ if (!(cond)) \ return; \ WARNING: use of RCU tasks trace is incorrect outside BPF or core RCU code #147: FILE: include/linux/tracepoint.h:202: + rcu_read_lock_trace(); \ WARNING: use of RCU tasks trace is incorrect outside BPF or core RCU code #161: FILE: include/linux/tracepoint.h:225: + rcu_read_unlock_trace(); \ WARNING: Argument 'name' is not used in function-like macro #179: FILE: include/linux/tracepoint.h:240: +#define __DECLARE_TRACE_RCU(name, proto, args, cond, tp_flags) WARNING: Argument 'proto' is not used in function-like macro #179: FILE: include/linux/tracepoint.h:240: +#define __DECLARE_TRACE_RCU(name, proto, args, cond, tp_flags) WARNING: Argument 'args' is not used in function-like macro #179: FILE: include/linux/tracepoint.h:240: +#define __DECLARE_TRACE_RCU(name, proto, args, cond, tp_flags) WARNING: Argument 'cond' is not used in function-like macro #179: FILE: include/linux/tracepoint.h:240: +#define __DECLARE_TRACE_RCU(name, proto, args, cond, tp_flags) WARNING: Argument 'tp_flags' is not used in function-like macro #179: FILE: include/linux/tracepoint.h:240: +#define __DECLARE_TRACE_RCU(name, proto, args, cond, tp_flags) WARNING: Argument 'proto' is not used in function-like macro #188: FILE: include/linux/tracepoint.h:254: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ extern int __traceiter_##name(data_proto); \ DECLARE_STATIC_CALL(tp_func_##name, __traceiter_##name); \ extern struct tracepoint __tracepoint_##name; \ WARNING: Argument 'args' is not used in function-like macro #188: FILE: include/linux/tracepoint.h:254: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ extern int __traceiter_##name(data_proto); \ DECLARE_STATIC_CALL(tp_func_##name, __traceiter_##name); \ extern struct tracepoint __tracepoint_##name; \ WARNING: Argument 'cond' is not used in function-like macro #188: FILE: include/linux/tracepoint.h:254: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ extern int __traceiter_##name(data_proto); \ DECLARE_STATIC_CALL(tp_func_##name, __traceiter_##name); \ extern struct tracepoint __tracepoint_##name; \ WARNING: Argument 'tp_flags' is not used in function-like macro #188: FILE: include/linux/tracepoint.h:254: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ extern int __traceiter_##name(data_proto); \ DECLARE_STATIC_CALL(tp_func_##name, __traceiter_##name); \ extern struct tracepoint __tracepoint_##name; \ WARNING: line length of 81 exceeds 80 columns #215: FILE: include/linux/tracepoint.h:287: + register_trace_prio_flags_##name(void (*probe)(data_proto), void *data, \ WARNING: line length of 83 exceeds 80 columns #218: FILE: include/linux/tracepoint.h:290: + return tracepoint_probe_register_prio_flags(&__tracepoint_##name, \ WARNING: line length of 82 exceeds 80 columns #219: FILE: include/linux/tracepoint.h:291: + (void *)probe, data, prio, flags); \ WARNING: Argument '_reg' is not used in function-like macro #230: FILE: include/linux/tracepoint.h:314: +#define DEFINE_TRACE_FN_FLAGS(_name, _reg, _unreg, proto, args, tp_flags) \ static const char __tpstrtab_##_name[] \ __section("__tracepoints_strings") = #_name; \ extern struct static_call_key STATIC_CALL_KEY(tp_func_##_name); \ WARNING: Argument '_unreg' is not used in function-like macro #230: FILE: include/linux/tracepoint.h:314: +#define DEFINE_TRACE_FN_FLAGS(_name, _reg, _unreg, proto, args, tp_flags) \ static const char __tpstrtab_##_name[] \ __section("__tracepoints_strings") = #_name; \ extern struct static_call_key STATIC_CALL_KEY(tp_func_##_name); \ WARNING: Argument 'proto' is not used in function-like macro #230: FILE: include/linux/tracepoint.h:314: +#define DEFINE_TRACE_FN_FLAGS(_name, _reg, _unreg, proto, args, tp_flags) \ static const char __tpstrtab_##_name[] \ __section("__tracepoints_strings") = #_name; \ extern struct static_call_key STATIC_CALL_KEY(tp_func_##_name); \ WARNING: Argument 'args' is not used in function-like macro #230: FILE: include/linux/tracepoint.h:314: +#define DEFINE_TRACE_FN_FLAGS(_name, _reg, _unreg, proto, args, tp_flags) \ static const char __tpstrtab_##_name[] \ __section("__tracepoints_strings") = #_name; \ extern struct static_call_key STATIC_CALL_KEY(tp_func_##_name); \ WARNING: Argument 'tp_flags' is not used in function-like macro #230: FILE: include/linux/tracepoint.h:314: +#define DEFINE_TRACE_FN_FLAGS(_name, _reg, _unreg, proto, args, tp_flags) \ static const char __tpstrtab_##_name[] \ __section("__tracepoints_strings") = #_name; \ extern struct static_call_key STATIC_CALL_KEY(tp_func_##_name); \ WARNING: line length of 82 exceeds 80 columns #250: FILE: include/linux/tracepoint.h:356: + DEFINE_TRACE_FN_FLAGS(_name, _reg, _unreg, PARAMS(proto), PARAMS(args), 0) WARNING: Argument 'args' is not used in function-like macro #263: FILE: include/linux/tracepoint.h:372: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ static inline void trace_##name(proto) \ { } \ static inline void trace_##name##_rcuidle(proto) \ WARNING: Argument 'cond' is not used in function-like macro #263: FILE: include/linux/tracepoint.h:372: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ static inline void trace_##name(proto) \ { } \ static inline void trace_##name##_rcuidle(proto) \ WARNING: Argument 'data_proto' is not used in function-like macro #263: FILE: include/linux/tracepoint.h:372: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ static inline void trace_##name(proto) \ { } \ static inline void trace_##name##_rcuidle(proto) \ WARNING: Argument 'tp_flags' is not used in function-like macro #263: FILE: include/linux/tracepoint.h:372: +#define __DECLARE_TRACE(name, proto, args, cond, data_proto, tp_flags) \ static inline void trace_##name(proto) \ { } \ static inline void trace_##name##_rcuidle(proto) \ WARNING: ENOSYS means 'invalid syscall nr' and nothing else #274: FILE: include/linux/tracepoint.h:387: + return -ENOSYS; \ WARNING: ENOSYS means 'invalid syscall nr' and nothing else #280: FILE: include/linux/tracepoint.h:393: + return -ENOSYS; \ WARNING: Argument 'name' is not used in function-like macro #290: FILE: include/linux/tracepoint.h:410: +#define DEFINE_TRACE_FN_FLAGS(name, reg, unreg, proto, args, tp_flags) WARNING: Argument 'reg' is not used in function-like macro #290: FILE: include/linux/tracepoint.h:410: +#define DEFINE_TRACE_FN_FLAGS(name, reg, unreg, proto, args, tp_flags) WARNING: Argument 'unreg' is not used in function-like macro #290: FILE: include/linux/tracepoint.h:410: +#define DEFINE_TRACE_FN_FLAGS(name, reg, unreg, proto, args, tp_flags) WARNING: Argument 'proto' is not used in function-like macro #290: FILE: include/linux/tracepoint.h:410: +#define DEFINE_TRACE_FN_FLAGS(name, reg, unreg, proto, args, tp_flags) WARNING: Argument 'args' is not used in function-like macro #290: FILE: include/linux/tracepoint.h:410: +#define DEFINE_TRACE_FN_FLAGS(name, reg, unreg, proto, args, tp_flags) WARNING: Argument 'tp_flags' is not used in function-like macro #290: FILE: include/linux/tracepoint.h:410: +#define DEFINE_TRACE_FN_FLAGS(name, reg, unreg, proto, args, tp_flags) WARNING: Argument 'struct' is not used in function-like macro #318: FILE: include/linux/tracepoint.h:606: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, struct, \ + assign, print, reg, unreg) \ + DECLARE_TRACE_MAY_FAULT(name, PARAMS(proto), PARAMS(args)) WARNING: Argument 'assign' is not used in function-like macro #318: FILE: include/linux/tracepoint.h:606: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, struct, \ + assign, print, reg, unreg) \ + DECLARE_TRACE_MAY_FAULT(name, PARAMS(proto), PARAMS(args)) WARNING: Argument 'print' is not used in function-like macro #318: FILE: include/linux/tracepoint.h:606: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, struct, \ + assign, print, reg, unreg) \ + DECLARE_TRACE_MAY_FAULT(name, PARAMS(proto), PARAMS(args)) WARNING: Argument 'reg' is not used in function-like macro #318: FILE: include/linux/tracepoint.h:606: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, struct, \ + assign, print, reg, unreg) \ + DECLARE_TRACE_MAY_FAULT(name, PARAMS(proto), PARAMS(args)) WARNING: Argument 'unreg' is not used in function-like macro #318: FILE: include/linux/tracepoint.h:606: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, struct, \ + assign, print, reg, unreg) \ + DECLARE_TRACE_MAY_FAULT(name, PARAMS(proto), PARAMS(args)) WARNING: Argument 'tstruct' is not used in function-like macro #333: FILE: include/trace/define_trace.h:45: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, tstruct, \ + assign, print, reg, unreg) \ + DEFINE_TRACE_FN_FLAGS(name, reg, unreg, PARAMS(proto), \ + PARAMS(args), TRACEPOINT_MAY_FAULT) WARNING: Argument 'assign' is not used in function-like macro #333: FILE: include/trace/define_trace.h:45: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, tstruct, \ + assign, print, reg, unreg) \ + DEFINE_TRACE_FN_FLAGS(name, reg, unreg, PARAMS(proto), \ + PARAMS(args), TRACEPOINT_MAY_FAULT) WARNING: Argument 'print' is not used in function-like macro #333: FILE: include/trace/define_trace.h:45: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, tstruct, \ + assign, print, reg, unreg) \ + DEFINE_TRACE_FN_FLAGS(name, reg, unreg, PARAMS(proto), \ + PARAMS(args), TRACEPOINT_MAY_FAULT) WARNING: Argument 'reg' is not used in function-like macro #358: FILE: include/trace/trace_events.h:81: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, tstruct, \ + assign, print, reg, unreg) \ + TRACE_EVENT(name, PARAMS(proto), PARAMS(args), \ + PARAMS(tstruct), PARAMS(assign), PARAMS(print)) \ + WARNING: Argument 'unreg' is not used in function-like macro #358: FILE: include/trace/trace_events.h:81: +#define TRACE_EVENT_FN_MAY_FAULT(name, proto, args, tstruct, \ + assign, print, reg, unreg) \ + TRACE_EVENT(name, PARAMS(proto), PARAMS(args), \ + PARAMS(tstruct), PARAMS(assign), PARAMS(print)) \ + WARNING: line length of 82 exceeds 80 columns #388: FILE: kernel/trace/bpf_trace.c:2475: + link, TRACEPOINT_DEFAULT_PRIO, CHECK: Alignment should match open parenthesis #404: FILE: kernel/trace/trace_fprobe.c:709: + ret = tracepoint_probe_register_prio_flags(tpoint, + tpoint->probestub, NULL, 0, WARNING: use of RCU tasks trace is incorrect outside BPF or core RCU code #425: FILE: kernel/tracepoint.c:121: + call_rcu_tasks_trace(head, rcu_tasks_trace_free_old_probes); WARNING: line length of 98 exceeds 80 columns #471: FILE: kernel/tracepoint.c:468: + * tracepoint_probe_register_prio_flags - Connect a probe to a tracepoint with priority and flags CHECK: Alignment should match open parenthesis #489: FILE: kernel/tracepoint.c:482: +int tracepoint_probe_register_prio_flags(struct tracepoint *tp, void *probe, + void *data, int prio, unsigned int flags) WARNING: line length of 81 exceeds 80 columns #498: FILE: kernel/tracepoint.c:491: + if ((tp->flags & TRACEPOINT_MAY_FAULT) != (flags & TRACEPOINT_MAY_FAULT)) WARNING: line length of 84 exceeds 80 columns #510: FILE: kernel/tracepoint.c:502: + ret = tracepoint_add_func(tp, &tp_func, prio, flags & TRACEPOINT_MAY_EXIST); WARNING: line length of 97 exceeds 80 columns #551: FILE: kernel/tracepoint.c:544: + return tracepoint_probe_register_prio_flags(tp, probe, data, TRACEPOINT_DEFAULT_PRIO, 0); total: 0 errors, 55 warnings, 3 checks, 434 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 6537ef3096f5 ("tracing: Introduce faultable tracepoints") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 55 warnings, 3 checks, 434 lines checked