WARNING: line length of 81 exceeds 80 columns #103: FILE: tools/testing/selftests/net/tcp_ao/connect-deny.c:229: + trace_hash_event_expect(TCP_HASH_AO_REQUIRED, this_ip_addr, this_ip_dest, CHECK: Alignment should match open parenthesis #204: FILE: tools/testing/selftests/net/tcp_ao/key-management.c:1096: + trace_ao_event_expect(TCP_AO_RNEXT_REQUEST, + this_ip_addr, this_ip_dest, WARNING: line length of 82 exceeds 80 columns #206: FILE: tools/testing/selftests/net/tcp_ao/key-management.c:1098: + i == 0 ? -1 : collection.keys[i - 1].server_keyid, CHECK: extern prototypes should be avoided in .h files #244: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:187: +extern void test_init_ftrace(int nsfd1, int nsfd2); CHECK: extern prototypes should be avoided in .h files #245: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:188: +extern int test_setup_tracing(void); CHECK: extern prototypes should be avoided in .h files #253: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:263: +extern int switch_save_ns(int fd); CHECK: extern prototypes should be avoided in .h files #254: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:264: +extern void switch_close_ns(int fd); CHECK: extern prototypes should be avoided in .h files #282: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:665: +extern struct test_ftracer *create_ftracer(const char *name, CHECK: Alignment should match open parenthesis #283: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:666: +extern struct test_ftracer *create_ftracer(const char *name, + enum ftracer_op (*process_line)(const char *line), CHECK: extern prototypes should be avoided in .h files #287: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:670: +extern int setup_trace_event(struct test_ftracer *tracer, CHECK: extern prototypes should be avoided in .h files #289: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:672: +extern void destroy_ftracer(struct test_ftracer *tracer); CHECK: extern prototypes should be avoided in .h files #290: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:673: +extern const size_t tracer_get_savedlines_nr(struct test_ftracer *tracer); CHECK: extern prototypes should be avoided in .h files #291: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:674: +extern const char **tracer_get_savedlines(struct test_ftracer *tracer); CHECK: extern prototypes should be avoided in .h files #314: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:697: +extern int __trace_event_expect(enum trace_events type, int family, CHECK: Alignment should match open parenthesis #321: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:704: +static inline void trace_hash_event_expect(enum trace_events type, + union tcp_addr src, union tcp_addr dst, CHECK: Alignment should match open parenthesis #336: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:719: +static inline void trace_ao_event_expect(enum trace_events type, + union tcp_addr src, union tcp_addr dst, CHECK: Alignment should match open parenthesis #352: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:735: +static inline void trace_ao_event_sk_expect(enum trace_events type, + union tcp_addr src, union tcp_addr dst, CHECK: Alignment should match open parenthesis #367: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:750: +static inline void trace_ao_event_sne_expect(enum trace_events type, + union tcp_addr src, union tcp_addr dst, CHECK: extern prototypes should be avoided in .h files #380: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:763: +extern int setup_aolib_ftracer(void); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #384: new file mode 100644 WARNING: line length of 87 exceeds 80 columns #590: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:202: + if (!strncmp(trace_event_names[i], line, strlen(trace_event_names[i]))) WARNING: line length of 83 exceeds 80 columns #624: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:236: + test_print("Couldn't parse trace event addr:port %s", src); WARNING: line length of 125 exceeds 80 columns #691: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:303: + nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c]", WARNING: line length of 81 exceeds 80 columns #696: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:308: + test_print("Couldn't parse trace event, matched = %d/10", WARNING: line length of 153 exceeds 80 columns #705: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:317: + nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c] keyid=%u rnext=%u maclen=%u", WARNING: line length of 81 exceeds 80 columns #711: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:323: + test_print("Couldn't parse trace event, matched = %d/13", WARNING: line length of 119 exceeds 80 columns #716: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:328: + nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms keyid=%u rnext=%u", WARNING: line length of 108 exceeds 80 columns #726: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:338: + nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms sne=%u", WARNING: line length of 83 exceeds 80 columns #744: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:356: + test_print("Couldn't parse trace event family %s", family); WARNING: line length of 81 exceeds 80 columns #762: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:374: + test_print("Couldn't parse trace event flags %c%c%c%c%c", WARNING: line length of 86 exceeds 80 columns #769: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:381: + if (src && tracer_scan_address(out->family, src, &out->src, &out->src_port)) { WARNING: line length of 86 exceeds 80 columns #774: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:386: + if (dst && tracer_scan_address(out->family, dst, &out->dst, &out->dst_port)) { WARNING: line length of 118 exceeds 80 columns #780: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:392: + test_print("Net namespace filter for trace event didn't work: %" PRIu64 " != %" PRIu64 " OR %" PRIu64, WARNING: line length of 140 exceeds 80 columns #815: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:427: + test_print("trace event filter %s [%s:%d => %s:%d, L3index %d, flags: %s%s%s%s%s, keyid: %d, rnext: %d, maclen: %d, sne: %d] = %zu", WARNING: static char array declaration should probably be static const char #966: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:13: +static char ftrace_path[] = "ksft-ftrace-XXXXXX"; WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #1239: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:286: + unsigned timeout_sec) CHECK: Alignment should match open parenthesis #1255: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:302: + ret = pthread_cond_timedwait(&tracer->met_all_expected, + &tracer->met_all_expected_lock, &timeout); WARNING: line length of 86 exceeds 80 columns #1286: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:333: + enum ftracer_op (*process_line)(const char *line), WARNING: line length of 84 exceeds 80 columns #1287: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:334: + void (*destructor)(struct test_ftracer *tracer), WARNING: line length of 83 exceeds 80 columns #1325: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:372: + tracer->saved_lines = calloc(lines_buf_sz, sizeof(tracer->saved_lines[0])); WARNING: line length of 96 exceeds 80 columns #1400: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:447: + test_error("tracers list corruption or double free %p", tracer); WARNING: line length of 101 exceeds 80 columns #1449: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:496: + test_print("net-namespace cookies: %" PRIu64 " == %" PRIu64 ", can't set up tracing", WARNING: line length of 81 exceeds 80 columns #1610: FILE: tools/testing/selftests/net/tcp_ao/restore.c:231: + /* not expecting server => client mismatches as only snd sne is broken */ WARNING: line length of 81 exceeds 80 columns #1617: FILE: tools/testing/selftests/net/tcp_ao/restore.c:238: + /* not expecting client => server mismatches as only rcv sne is broken */ WARNING: line length of 83 exceeds 80 columns #1652: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:167: + /* expecting rnext to change based on the first segment RNext != Current */ WARNING: line length of 86 exceeds 80 columns #1661: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:175: + /* intentionally on restore they are added to the socket in different order */ WARNING: line length of 83 exceeds 80 columns #1663: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:177: + port + 1, port + 1, 0, -1, -1, -1, -1, -1, 5, 7, -1); CHECK: Alignment should match open parenthesis #1686: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:120: + trace_ao_event_sne_expect(TCP_AO_SND_SNE_UPDATE, this_ip_addr, + this_ip_dest, test_server_port + 1, client_new_port, 1); CHECK: Alignment should match open parenthesis #1688: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:122: + trace_ao_event_sne_expect(TCP_AO_SND_SNE_UPDATE, this_ip_dest, + this_ip_addr, client_new_port, test_server_port + 1, 1); CHECK: Alignment should match open parenthesis #1690: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:124: + trace_ao_event_sne_expect(TCP_AO_RCV_SNE_UPDATE, this_ip_addr, + this_ip_dest, test_server_port + 1, client_new_port, 1); CHECK: Alignment should match open parenthesis #1692: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:126: + trace_ao_event_sne_expect(TCP_AO_RCV_SNE_UPDATE, this_ip_dest, + this_ip_addr, client_new_port, test_server_port + 1, 1); total: 0 errors, 29 warnings, 22 checks, 1646 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 83b94389a684 ("selftests/net: Add trace events matching to tcp_ao") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 29 warnings, 22 checks, 1646 lines checked