WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 ERROR: Macros with complex values should be enclosed in parentheses #152: FILE: drivers/ptp/ptp_vmclock.c:54: +#define VMCLOCK_FIELD_PRESENT(_c, _f) \ + le32_to_cpu((_c)->size) >= (offsetof(struct vmclock_abi, _f) + \ + sizeof((_c)->_f)) CHECK: Prefer kernel type 'u64' over 'uint64_t' #163: FILE: drivers/ptp/ptp_vmclock.c:65: +static uint64_t mul_u64_u64_shr_add_u64(uint64_t *res_hi, uint64_t delta, CHECK: Prefer kernel type 'u64' over 'uint64_t' #164: FILE: drivers/ptp/ptp_vmclock.c:66: + uint64_t period, uint8_t shift, CHECK: Prefer kernel type 'u64' over 'uint64_t' #196: FILE: drivers/ptp/ptp_vmclock.c:98: + uint64_t cycle, delta, seq, frac_sec; WARNING: line length of 97 exceeds 80 columns #248: FILE: drivers/ptp/ptp_vmclock.c:150: + le64_to_cpu(st->clk->counter_period_frac_sec), WARNING: line length of 81 exceeds 80 columns #249: FILE: drivers/ptp/ptp_vmclock.c:151: + st->clk->counter_period_shift, WARNING: line length of 88 exceeds 80 columns #250: FILE: drivers/ptp/ptp_vmclock.c:152: + le64_to_cpu(st->clk->time_frac_sec)); WARNING: memory barrier without comment #257: FILE: drivers/ptp/ptp_vmclock.c:159: + virt_rmb(); WARNING: line length of 87 exceeds 80 columns #287: FILE: drivers/ptp/ptp_vmclock.c:189: + struct system_counterval_t *system_counter, WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #291: FILE: drivers/ptp/ptp_vmclock.c:193: + unsigned pvti_ver; WARNING: line length of 87 exceeds 80 columns #304: FILE: drivers/ptp/ptp_vmclock.c:206: + system_counter->cycles); WARNING: Missing a blank line after declarations #361: FILE: drivers/ptp/ptp_vmclock.c:263: + struct system_time_snapshot systime_snapshot; + ktime_get_snapshot(&systime_snapshot); WARNING: line length of 84 exceeds 80 columns #366: FILE: drivers/ptp/ptp_vmclock.c:268: + ret = get_device_system_crosststamp(ptp_vmclock_get_time_fn, CHECK: Alignment should match open parenthesis #389: FILE: drivers/ptp/ptp_vmclock.c:291: +static int ptp_vmclock_settime(struct ptp_clock_info *ptp, + const struct timespec64 *ts) WARNING: line length of 82 exceeds 80 columns #394: FILE: drivers/ptp/ptp_vmclock.c:296: +static int ptp_vmclock_gettimex(struct ptp_clock_info *ptp, struct timespec64 *ts, CHECK: Alignment should match open parenthesis #404: FILE: drivers/ptp/ptp_vmclock.c:306: +static int ptp_vmclock_enable(struct ptp_clock_info *ptp, + struct ptp_clock_request *rq, int on) CHECK: multiple assignments should be avoided #445: FILE: drivers/ptp/ptp_vmclock.c:347: + st->sys_cs_id = st->cs_id = cs_id; CHECK: spaces preferred around that '|' (ctx:VxV) #457: FILE: drivers/ptp/ptp_vmclock.c:359: + if ((vma->vm_flags & (VM_READ|VM_WRITE)) != VM_READ) ^ ERROR: code indent should use tabs where possible #463: FILE: drivers/ptp/ptp_vmclock.c:365: + if (io_remap_pfn_range(vma, vma->vm_start,$ WARNING: please, no spaces at the start of a line #463: FILE: drivers/ptp/ptp_vmclock.c:365: + if (io_remap_pfn_range(vma, vma->vm_start,$ ERROR: code indent should use tabs where possible #465: FILE: drivers/ptp/ptp_vmclock.c:367: + vma->vm_page_prot))$ WARNING: please, no spaces at the start of a line #465: FILE: drivers/ptp/ptp_vmclock.c:367: + vma->vm_page_prot))$ ERROR: code indent should use tabs where possible #466: FILE: drivers/ptp/ptp_vmclock.c:368: + return -EAGAIN;$ WARNING: please, no spaces at the start of a line #466: FILE: drivers/ptp/ptp_vmclock.c:368: + return -EAGAIN;$ ERROR: code indent should use tabs where possible #468: FILE: drivers/ptp/ptp_vmclock.c:370: + return 0;$ WARNING: please, no spaces at the start of a line #468: FILE: drivers/ptp/ptp_vmclock.c:370: + return 0;$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #478: FILE: drivers/ptp/ptp_vmclock.c:380: + uint32_t seq; WARNING: memory barrier without comment #489: FILE: drivers/ptp/ptp_vmclock.c:391: + virt_rmb(); WARNING: memory barrier without comment #494: FILE: drivers/ptp/ptp_vmclock.c:396: + virt_rmb(); ERROR: code indent should use tabs where possible #507: FILE: drivers/ptp/ptp_vmclock.c:409: + .mmap = vmclock_miscdev_mmap,$ WARNING: please, no spaces at the start of a line #507: FILE: drivers/ptp/ptp_vmclock.c:409: + .mmap = vmclock_miscdev_mmap,$ ERROR: code indent should use tabs where possible #508: FILE: drivers/ptp/ptp_vmclock.c:410: + .read = vmclock_miscdev_read,$ WARNING: please, no spaces at the start of a line #508: FILE: drivers/ptp/ptp_vmclock.c:410: + .read = vmclock_miscdev_read,$ WARNING: line length of 81 exceeds 80 columns #525: FILE: drivers/ptp/ptp_vmclock.c:427: +static acpi_status vmclock_acpi_resources(struct acpi_resource *ares, void *data) CHECK: Unnecessary parentheses around win.res #529: FILE: drivers/ptp/ptp_vmclock.c:431: + struct resource *res = &(win.res); ERROR: code indent should use tabs where possible #538: FILE: drivers/ptp/ptp_vmclock.c:440: + if (acpi_dev_resource_memory(ares, res) ||$ WARNING: please, no spaces at the start of a line #538: FILE: drivers/ptp/ptp_vmclock.c:440: + if (acpi_dev_resource_memory(ares, res) ||$ CHECK: Blank lines aren't necessary after an open brace '{' #540: FILE: drivers/ptp/ptp_vmclock.c:442: + acpi_dev_resource_address_space(ares, &win)) { + WARNING: space prohibited between function name and open parenthesis '(' #588: FILE: drivers/ptp/ptp_vmclock.c:490: + st = devm_kzalloc(dev, sizeof (*st), GFP_KERNEL); WARNING: line length of 82 exceeds 80 columns #634: FILE: drivers/ptp/ptp_vmclock.c:536: + st->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "vmclock%d", st->index); WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #705: FILE: drivers/ptp/ptp_vmclock.c:607: +MODULE_LICENSE("GPL v2"); WARNING: line length of 82 exceeds 80 columns #712: FILE: include/uapi/linux/vmclock-abi.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */ WARNING: line length of 88 exceeds 80 columns #785: FILE: include/uapi/linux/vmclock-abi.h:74: +#define VMCLOCK_TIME_UTC 0 /* Since 1970-01-01 00:00:00z */ WARNING: line length of 88 exceeds 80 columns #786: FILE: include/uapi/linux/vmclock-abi.h:75: +#define VMCLOCK_TIME_TAI 1 /* Since 1970-01-01 00:00:00z */ WARNING: line length of 83 exceeds 80 columns #787: FILE: include/uapi/linux/vmclock-abi.h:76: +#define VMCLOCK_TIME_MONOTONIC 2 /* Since undefined epoch */ total: 8 errors, 28 warnings, 10 checks, 815 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 07a8fa03f1dc ("ptp: Add support for the AMZNC10C 'vmclock' device") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.