WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #65: new file mode 100644 ERROR: Macros with complex values should be enclosed in parentheses #123: FILE: drivers/ptp/ptp_vmclock.c:54: +#define VMCLOCK_FIELD_PRESENT(_c, _f) \ + (_c)->size >= (offsetof(struct vmclock_abi, _f) + \ + sizeof((_c)->_f)) CHECK: Prefer kernel type 'u64' over 'uint64_t' #137: FILE: drivers/ptp/ptp_vmclock.c:68: +static uint64_t mul_u64_u64_shr_add_u64(uint64_t *res_hi, uint64_t delta, CHECK: Prefer kernel type 'u64' over 'uint64_t' #138: FILE: drivers/ptp/ptp_vmclock.c:69: + uint64_t period, uint8_t shift, CHECK: Prefer kernel type 'u64' over 'uint64_t' #170: FILE: drivers/ptp/ptp_vmclock.c:101: + uint64_t cycle, delta, seq, frac_sec; WARNING: line length of 97 exceeds 80 columns #222: FILE: drivers/ptp/ptp_vmclock.c:153: + le64_to_cpu(st->clk->counter_period_frac_sec), WARNING: line length of 81 exceeds 80 columns #223: FILE: drivers/ptp/ptp_vmclock.c:154: + st->clk->counter_period_shift, WARNING: line length of 88 exceeds 80 columns #224: FILE: drivers/ptp/ptp_vmclock.c:155: + le64_to_cpu(st->clk->time_frac_sec)); WARNING: memory barrier without comment #231: FILE: drivers/ptp/ptp_vmclock.c:162: + virt_rmb(); WARNING: line length of 87 exceeds 80 columns #261: FILE: drivers/ptp/ptp_vmclock.c:192: + struct system_counterval_t *system_counter, WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #265: FILE: drivers/ptp/ptp_vmclock.c:196: + unsigned pvti_ver; WARNING: line length of 87 exceeds 80 columns #278: FILE: drivers/ptp/ptp_vmclock.c:209: + system_counter->cycles); WARNING: Missing a blank line after declarations #335: FILE: drivers/ptp/ptp_vmclock.c:266: + struct system_time_snapshot systime_snapshot; + ktime_get_snapshot(&systime_snapshot); WARNING: line length of 84 exceeds 80 columns #340: FILE: drivers/ptp/ptp_vmclock.c:271: + ret = get_device_system_crosststamp(ptp_vmclock_get_time_fn, CHECK: Alignment should match open parenthesis #363: FILE: drivers/ptp/ptp_vmclock.c:294: +static int ptp_vmclock_settime(struct ptp_clock_info *ptp, + const struct timespec64 *ts) WARNING: line length of 82 exceeds 80 columns #368: FILE: drivers/ptp/ptp_vmclock.c:299: +static int ptp_vmclock_gettimex(struct ptp_clock_info *ptp, struct timespec64 *ts, CHECK: Alignment should match open parenthesis #378: FILE: drivers/ptp/ptp_vmclock.c:309: +static int ptp_vmclock_enable(struct ptp_clock_info *ptp, + struct ptp_clock_request *rq, int on) CHECK: multiple assignments should be avoided #419: FILE: drivers/ptp/ptp_vmclock.c:350: + st->sys_cs_id = st->cs_id = cs_id; CHECK: spaces preferred around that '|' (ctx:VxV) #431: FILE: drivers/ptp/ptp_vmclock.c:362: + if ((vma->vm_flags & (VM_READ|VM_WRITE)) != VM_READ) ^ ERROR: code indent should use tabs where possible #437: FILE: drivers/ptp/ptp_vmclock.c:368: + if (io_remap_pfn_range(vma, vma->vm_start,$ WARNING: please, no spaces at the start of a line #437: FILE: drivers/ptp/ptp_vmclock.c:368: + if (io_remap_pfn_range(vma, vma->vm_start,$ ERROR: code indent should use tabs where possible #439: FILE: drivers/ptp/ptp_vmclock.c:370: + vma->vm_page_prot))$ WARNING: please, no spaces at the start of a line #439: FILE: drivers/ptp/ptp_vmclock.c:370: + vma->vm_page_prot))$ ERROR: code indent should use tabs where possible #440: FILE: drivers/ptp/ptp_vmclock.c:371: + return -EAGAIN;$ WARNING: please, no spaces at the start of a line #440: FILE: drivers/ptp/ptp_vmclock.c:371: + return -EAGAIN;$ ERROR: code indent should use tabs where possible #442: FILE: drivers/ptp/ptp_vmclock.c:373: + return 0;$ WARNING: please, no spaces at the start of a line #442: FILE: drivers/ptp/ptp_vmclock.c:373: + return 0;$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #452: FILE: drivers/ptp/ptp_vmclock.c:383: + uint32_t seq; WARNING: memory barrier without comment #463: FILE: drivers/ptp/ptp_vmclock.c:394: + virt_rmb(); WARNING: memory barrier without comment #468: FILE: drivers/ptp/ptp_vmclock.c:399: + virt_rmb(); ERROR: code indent should use tabs where possible #481: FILE: drivers/ptp/ptp_vmclock.c:412: + .mmap = vmclock_miscdev_mmap,$ WARNING: please, no spaces at the start of a line #481: FILE: drivers/ptp/ptp_vmclock.c:412: + .mmap = vmclock_miscdev_mmap,$ ERROR: code indent should use tabs where possible #482: FILE: drivers/ptp/ptp_vmclock.c:413: + .read = vmclock_miscdev_read,$ WARNING: please, no spaces at the start of a line #482: FILE: drivers/ptp/ptp_vmclock.c:413: + .read = vmclock_miscdev_read,$ WARNING: line length of 81 exceeds 80 columns #499: FILE: drivers/ptp/ptp_vmclock.c:430: +static acpi_status vmclock_acpi_resources(struct acpi_resource *ares, void *data) CHECK: Unnecessary parentheses around win.res #503: FILE: drivers/ptp/ptp_vmclock.c:434: + struct resource *res = &(win.res); ERROR: code indent should use tabs where possible #512: FILE: drivers/ptp/ptp_vmclock.c:443: + if (acpi_dev_resource_memory(ares, res) ||$ WARNING: please, no spaces at the start of a line #512: FILE: drivers/ptp/ptp_vmclock.c:443: + if (acpi_dev_resource_memory(ares, res) ||$ CHECK: Blank lines aren't necessary after an open brace '{' #514: FILE: drivers/ptp/ptp_vmclock.c:445: + acpi_dev_resource_address_space(ares, &win)) { + WARNING: space prohibited between function name and open parenthesis '(' #562: FILE: drivers/ptp/ptp_vmclock.c:493: + st = devm_kzalloc(dev, sizeof (*st), GFP_KERNEL); WARNING: line length of 82 exceeds 80 columns #608: FILE: drivers/ptp/ptp_vmclock.c:539: + st->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "vmclock%d", st->index); WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #679: FILE: drivers/ptp/ptp_vmclock.c:610: +MODULE_LICENSE("GPL v2"); WARNING: line length of 82 exceeds 80 columns #686: FILE: include/uapi/linux/vmclock-abi.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */ WARNING: line length of 88 exceeds 80 columns #759: FILE: include/uapi/linux/vmclock-abi.h:74: +#define VMCLOCK_TIME_UTC 0 /* Since 1970-01-01 00:00:00z */ WARNING: line length of 88 exceeds 80 columns #760: FILE: include/uapi/linux/vmclock-abi.h:75: +#define VMCLOCK_TIME_TAI 1 /* Since 1970-01-01 00:00:00z */ WARNING: line length of 83 exceeds 80 columns #761: FILE: include/uapi/linux/vmclock-abi.h:76: +#define VMCLOCK_TIME_MONOTONIC 2 /* Since undefined epoch */ total: 8 errors, 28 warnings, 10 checks, 818 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 365d5f8e14af ("ptp: Add vDSO-style vmclock support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.