WARNING: return sysfs_emit(...) formats should include a terminating newline #148: FILE: drivers/ptp/ptp_ocp.c:3371: + return sysfs_emit(buf, "ttyS%d", bp->port[(uintptr_t)ea->var].line); WARNING: line length of 84 exceeds 80 columns #152: FILE: drivers/ptp/ptp_ocp.c:3375: +ptp_ocp_timecard_tty_is_visible(struct kobject *kobj, struct attribute *attr, int n) CHECK: Please use a blank line after function/struct/union/enum declarations #167: FILE: drivers/ptp/ptp_ocp.c:3390: +} +#define EXT_TTY_ATTR_RO(_name, _val) \ WARNING: line length of 82 exceeds 80 columns #169: FILE: drivers/ptp/ptp_ocp.c:3392: + { __ATTR(tty##_name, 0444, ptp_ocp_tty_show, NULL), (void *)_val } WARNING: line length of 85 exceeds 80 columns #232: FILE: drivers/ptp/ptp_ocp.c:4031: + seq_printf(s, "%7s: /dev/ttyS%d\n", ptp_ocp_tty_port_name(i), WARNING: line length of 87 exceeds 80 columns #301: FILE: drivers/ptp/ptp_ocp.c:4469: + if (i == PORT_NMEA && bp->nmea_out && bp->port[PORT_NMEA].line != -1) { WARNING: line length of 84 exceeds 80 columns #308: FILE: drivers/ptp/ptp_ocp.c:4476: + ptp_ocp_serial_info(dev, ptp_ocp_tty_port_name(i), bp->port[i].line, total: 0 errors, 6 warnings, 1 checks, 305 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 666248f1f4f5 ("ptp: ocp: adjust sysfs entries to expose tty information") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 6 warnings, 1 checks, 305 lines checked