WARNING: please write a help paragraph that fully describes the config symbol
#41: FILE: drivers/pinctrl/Kconfig:568:
+config PINCTRL_RP1
+	bool "Pinctrl driver for RP1"
+	select PINMUX
+	select PINCONF
+	select GENERIC_PINCONF
+	select GPIOLIB_IRQCHIP
+	help
+	  Enable the gpio and pinctrl/mux  driver for RaspberryPi RP1
+	  multi function device. 
+

ERROR: trailing whitespace
#49: FILE: drivers/pinctrl/Kconfig:576:
+^I  multi function device. $

CHECK: Macro argument '_reg' may be better as '(_reg)' to avoid precedence issues
#214: FILE: drivers/pinctrl/pinctrl-rp1.c:143:
+#define FIELD_SET(_reg, _mask, _val)			\
+	({						\
+		_reg &= ~(_mask);				\
+		_reg |= FIELD_PREP((_mask), (_val));	\
+	})

WARNING: line length of 83 exceeds 80 columns
#360: FILE: drivers/pinctrl/pinctrl-rp1.c:289:
+	       pin->rio + RP1_RIO_OUT + (value ? RP1_SET_OFFSET : RP1_CLR_OFFSET));

WARNING: line length of 81 exceeds 80 columns
#413: FILE: drivers/pinctrl/pinctrl-rp1.c:342:
+static int rp1_gpio_direction_output(struct gpio_chip *chip, unsigned int offset,

WARNING: line length of 83 exceeds 80 columns
#479: FILE: drivers/pinctrl/pinctrl-rp1.c:408:
+						     bank->gpio_offset + bit_pos));

WARNING: line length of 83 exceeds 80 columns
#584: FILE: drivers/pinctrl/pinctrl-rp1.c:513:
+	writel(RP1_GPIO_CTRL_IRQRESET, pin->gpio + RP1_SET_OFFSET + RP1_GPIO_CTRL);

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#671: FILE: drivers/pinctrl/pinctrl-rp1.c:600:
+				return -ENOTSUPP;

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
#677: FILE: drivers/pinctrl/pinctrl-rp1.c:606:
+			return -ENOTSUPP;

total: 1 errors, 7 warnings, 1 checks, 749 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Commit a441713e87de ("pinctrl: rp1: Implement RaspberryPi RP1 gpio support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.