CHECK: Prefer using the BIT macro #247: FILE: kernel/trace/fprobe.c:19: +#define FPROBE_IP_TABLE_SIZE (1 << FPROBE_IP_HASH_BITS) CHECK: Prefer using the BIT macro #258: FILE: kernel/trace/fprobe.c:22: +#define FPROBE_TABLE_SIZE (1 << FPROBE_HASH_BITS) CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues #261: FILE: kernel/trace/fprobe.c:24: +#define SIZE_IN_LONG(x) ((x + sizeof(long) - 1) >> (sizeof(long) == 8 ? 3 : 2)) CHECK: Please use a blank line after function/struct/union/enum declarations #313: FILE: kernel/trace/fprobe.c:65: +} +NOKPROBE_SYMBOL(find_first_fprobe_node); CHECK: Please use a blank line after function/struct/union/enum declarations #381: FILE: kernel/trace/fprobe.c:109: +} +NOKPROBE_SYMBOL(is_fprobe_still_exist); WARNING: line length of 82 exceeds 80 columns #436: FILE: kernel/trace/fprobe.c:149: +#define MAX_FPROBE_DATA_SIZE (MAX_FPROBE_DATA_SIZE_WORD * sizeof(long)) WARNING: line length of 81 exceeds 80 columns #437: FILE: kernel/trace/fprobe.c:150: +#define FPROBE_HEADER_PTR_BITS (BITS_PER_LONG - FPROBE_HEADER_SIZE_BITS) WARNING: line length of 83 exceeds 80 columns #441: FILE: kernel/trace/fprobe.c:154: +static inline unsigned long encode_fprobe_header(struct fprobe *fp, int size_words) CHECK: Alignment should match open parenthesis #444: FILE: kernel/trace/fprobe.c:157: + if (WARN_ON_ONCE(size_words > MAX_FPROBE_DATA_SIZE_WORD || + ((unsigned long)fp & ~FPROBE_HEADER_PTR_MASK) != WARNING: line length of 84 exceeds 80 columns #482: FILE: kernel/trace/fprobe.c:195: +static inline int __fprobe_kprobe_handler(unsigned long ip, unsigned long parent_ip, WARNING: line length of 87 exceeds 80 columns #483: FILE: kernel/trace/fprobe.c:196: + struct fprobe *fp, struct ftrace_regs *fregs, CHECK: multiple assignments should be avoided #530: FILE: kernel/trace/fprobe.c:231: + first = node = find_first_fprobe_node(func); WARNING: line length of 81 exceeds 80 columns #543: FILE: kernel/trace/fprobe.c:243: + * Since fprobe can be enabled until the next loop, we ignore the WARNING: line length of 92 exceeds 80 columns #551: FILE: kernel/trace/fprobe.c:251: + fgraph_data = fgraph_reserve_data(gops->idx, reserved_words * sizeof(long)); WARNING: line length of 85 exceeds 80 columns #590: FILE: kernel/trace/fprobe.c:285: + ret = __fprobe_kprobe_handler(func, ret_ip, fp, fregs, data); WARNING: line length of 97 exceeds 80 columns #593: FILE: kernel/trace/fprobe.c:288: + /* If entry_handler returns !0, nmissed is not counted but skips exit_handler. */ CHECK: Please use a blank line after function/struct/union/enum declarations #610: FILE: kernel/trace/fprobe.c:305: +} +NOKPROBE_SYMBOL(fprobe_entry); CHECK: Please use a blank line after function/struct/union/enum declarations #648: FILE: kernel/trace/fprobe.c:343: +} +NOKPROBE_SYMBOL(fprobe_return); CHECK: Please use a blank line after function/struct/union/enum declarations #654: FILE: kernel/trace/fprobe.c:349: +}; +static int fprobe_graph_active; WARNING: line length of 82 exceeds 80 columns #722: FILE: kernel/trace/fprobe.c:424: +static int filter_match_callback(void *data, const char *name, unsigned long addr) WARNING: line length of 84 exceeds 80 columns #764: FILE: kernel/trace/fprobe.c:449: + struct filter_match_data match = { .filter = filter, .notfilter = notfilter, WARNING: line length of 82 exceeds 80 columns #771: FILE: kernel/trace/fprobe.c:456: + ret = module_kallsyms_on_each_symbol(NULL, filter_match_callback, &match); total: 0 errors, 12 warnings, 10 checks, 1011 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a7532ee1f6ed ("fprobe: Rewrite fprobe on function-graph tracer") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 10 checks, 1011 lines checked