WARNING: line length of 81 exceeds 80 columns
#103: FILE: tools/testing/selftests/net/tcp_ao/connect-deny.c:229:
+	trace_hash_event_expect(TCP_HASH_AO_REQUIRED, this_ip_addr, this_ip_dest,

CHECK: Alignment should match open parenthesis
#204: FILE: tools/testing/selftests/net/tcp_ao/key-management.c:1096:
+		trace_ao_event_expect(TCP_AO_RNEXT_REQUEST,
+				this_ip_addr, this_ip_dest,

WARNING: line length of 82 exceeds 80 columns
#206: FILE: tools/testing/selftests/net/tcp_ao/key-management.c:1098:
+				i == 0 ? -1 : collection.keys[i - 1].server_keyid,

CHECK: extern prototypes should be avoided in .h files
#244: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:187:
+extern void test_init_ftrace(int nsfd1, int nsfd2);

CHECK: extern prototypes should be avoided in .h files
#245: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:188:
+extern int test_setup_tracing(void);

CHECK: extern prototypes should be avoided in .h files
#253: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:263:
+extern int switch_save_ns(int fd);

CHECK: extern prototypes should be avoided in .h files
#254: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:264:
+extern void switch_close_ns(int fd);

CHECK: extern prototypes should be avoided in .h files
#282: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:665:
+extern struct test_ftracer *create_ftracer(const char *name,

CHECK: Alignment should match open parenthesis
#283: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:666:
+extern struct test_ftracer *create_ftracer(const char *name,
+		enum ftracer_op (*process_line)(const char *line),

CHECK: extern prototypes should be avoided in .h files
#286: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:669:
+extern int setup_trace_event(struct test_ftracer *tracer,

CHECK: extern prototypes should be avoided in .h files
#288: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:671:
+extern void destroy_ftracer(struct test_ftracer *tracer);

CHECK: extern prototypes should be avoided in .h files
#289: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:672:
+extern const size_t tracer_get_savedlines_nr(struct test_ftracer *tracer);

CHECK: extern prototypes should be avoided in .h files
#290: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:673:
+extern const char **tracer_get_savedlines(struct test_ftracer *tracer);

CHECK: Please use a blank line after function/struct/union/enum declarations
#312: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:695:
+};
+extern int __trace_event_expect(enum trace_events type, int family,

CHECK: extern prototypes should be avoided in .h files
#312: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:695:
+extern int __trace_event_expect(enum trace_events type, int family,

CHECK: Alignment should match open parenthesis
#319: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:702:
+static inline void trace_hash_event_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

CHECK: Alignment should match open parenthesis
#334: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:717:
+static inline void trace_ao_event_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

CHECK: Alignment should match open parenthesis
#350: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:733:
+static inline void trace_ao_event_sk_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

CHECK: Alignment should match open parenthesis
#365: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:748:
+static inline void trace_ao_event_sne_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

CHECK: extern prototypes should be avoided in .h files
#378: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:761:
+extern int setup_aolib_ftracer(void);

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#382: 
new file mode 100644

CHECK: Alignment should match open parenthesis
#444: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:58:
+int __trace_event_expect(enum trace_events type, int family,
+		union tcp_addr src, union tcp_addr dst,

WARNING: line length of 87 exceeds 80 columns
#588: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:202:
+		if (!strncmp(trace_event_names[i], line, strlen(trace_event_names[i])))

CHECK: Comparison to NULL could be written "!p"
#621: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:235:
+		if (p == NULL) {

WARNING: line length of 83 exceeds 80 columns
#622: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:236:
+			test_print("Couldn't parse trace event addr:port %s", src);

CHECK: Comparison to NULL could be written "!p"
#636: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:250:
+	if (p == NULL || *addr == NULL) {

CHECK: Comparison to NULL could be written "!addr"
#636: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:250:
+	if (p == NULL || *addr == NULL) {

CHECK: Alignment should match open parenthesis
#653: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:267:
+static int tracer_scan_address(int family, char *src,
+		union tcp_addr *dst, unsigned int *port)

CHECK: Alignment should match open parenthesis
#676: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:290:
+static int tracer_scan_event(const char *line, enum trace_events event,
+		struct trace_point *out)

WARNING: line length of 125 exceeds 80 columns
#689: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:303:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c]",

WARNING: line length of 81 exceeds 80 columns
#694: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:308:
+			test_print("Couldn't parse trace event, matched = %d/10",

WARNING: line length of 153 exceeds 80 columns
#703: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:317:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c] keyid=%u rnext=%u maclen=%u",

WARNING: line length of 81 exceeds 80 columns
#709: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:323:
+			test_print("Couldn't parse trace event, matched = %d/13",

WARNING: line length of 119 exceeds 80 columns
#714: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:328:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms keyid=%u rnext=%u",

CHECK: Alignment should match open parenthesis
#719: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:333:
+			test_print("Couldn't parse trace event, matched = %d/6",
+					nr_matched);

WARNING: line length of 108 exceeds 80 columns
#724: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:338:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state%*s family=%ms src=%ms dest=%ms sne=%u",

CHECK: Alignment should match open parenthesis
#729: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:343:
+			test_print("Couldn't parse trace event, matched = %d/5",
+					nr_matched);

WARNING: line length of 83 exceeds 80 columns
#742: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:356:
+			test_print("Couldn't parse trace event family %s", family);

CHECK: Alignment should match open parenthesis
#756: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:370:
+		if ((fin != 'F' && fin != ' ') ||
+				(syn != 'S' && syn != ' ') ||

WARNING: line length of 81 exceeds 80 columns
#760: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:374:
+			test_print("Couldn't parse trace event flags %c%c%c%c%c",

CHECK: Alignment should match open parenthesis
#761: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:375:
+			test_print("Couldn't parse trace event flags %c%c%c%c%c",
+					fin, syn, rst, psh, ack);

WARNING: line length of 86 exceeds 80 columns
#767: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:381:
+	if (src && tracer_scan_address(out->family, src, &out->src, &out->src_port)) {

WARNING: line length of 86 exceeds 80 columns
#772: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:386:
+	if (dst && tracer_scan_address(out->family, dst, &out->dst, &out->dst_port)) {

WARNING: line length of 118 exceeds 80 columns
#778: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:392:
+		test_print("Net namespace filter for trace event didn't work: %" PRIu64 " != %" PRIu64 " OR %" PRIu64,

CHECK: Alignment should match open parenthesis
#779: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:393:
+		test_print("Net namespace filter for trace event didn't work: %" PRIu64 " != %" PRIu64 " OR %" PRIu64,
+				netns_cookie, ns_cookie1, ns_cookie2);

WARNING: line length of 140 exceeds 80 columns
#813: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace-tcp.c:427:
+	test_print("trace event filter %s [%s:%d => %s:%d, L3index %d, flags: %s%s%s%s%s, keyid: %d, rnext: %d, maclen: %d, sne: %d] = %zu",

WARNING: static char array declaration should probably be static const char
#953: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:12:
+static char ftrace_path[] = "ksft-ftrace-XXXXXX";

CHECK: Comparison to NULL could be written "!opts"
#1018: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:77:
+	if (opts == NULL) {

CHECK: Please don't use multiple blank lines
#1238: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:297:
+
+

WARNING: line length of 86 exceeds 80 columns
#1241: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:300:
+				    enum ftracer_op (*process_line)(const char *line),

WARNING: line length of 84 exceeds 80 columns
#1242: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:301:
+				    void (*destructor)(struct test_ftracer *tracer),

WARNING: line length of 83 exceeds 80 columns
#1267: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:326:
+	tracer->saved_lines = calloc(lines_buf_sz, sizeof(tracer->saved_lines[0]));

WARNING: line length of 96 exceeds 80 columns
#1317: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:376:
+				test_error("tracers list corruption or double free %p", tracer);

WARNING: line length of 81 exceeds 80 columns
#1521: FILE: tools/testing/selftests/net/tcp_ao/restore.c:231:
+	/* not expecting server => client mismatches as only snd sne is broken */

WARNING: line length of 81 exceeds 80 columns
#1528: FILE: tools/testing/selftests/net/tcp_ao/restore.c:238:
+	/* not expecting client => server mismatches as only rcv sne is broken */

WARNING: line length of 83 exceeds 80 columns
#1563: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:167:
+	/* expecting rnext to change based on the first segment RNext != Current */

WARNING: line length of 86 exceeds 80 columns
#1572: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:175:
+	/* intentionally on restore they are added to the socket in different order */

WARNING: line length of 83 exceeds 80 columns
#1574: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:177:
+			      port + 1, port + 1, 0, -1, -1, -1, -1, -1, 5, 7, -1);

CHECK: Alignment should match open parenthesis
#1597: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:120:
+	trace_ao_event_sne_expect(TCP_AO_SND_SNE_UPDATE, this_ip_addr,
+			this_ip_dest, test_server_port + 1, client_new_port, 1);

CHECK: Alignment should match open parenthesis
#1599: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:122:
+	trace_ao_event_sne_expect(TCP_AO_SND_SNE_UPDATE, this_ip_dest,
+			this_ip_addr, client_new_port, test_server_port + 1, 1);

CHECK: Alignment should match open parenthesis
#1601: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:124:
+	trace_ao_event_sne_expect(TCP_AO_RCV_SNE_UPDATE, this_ip_addr,
+			this_ip_dest, test_server_port + 1, client_new_port, 1);

CHECK: Alignment should match open parenthesis
#1603: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:126:
+	trace_ao_event_sne_expect(TCP_AO_RCV_SNE_UPDATE, this_ip_dest,
+			this_ip_addr, client_new_port, test_server_port + 1, 1);

total: 0 errors, 27 warnings, 35 checks, 1557 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 98a815c07357 ("selftests/net: Add trace events matching to tcp_ao") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 27 warnings, 35 checks, 1557 lines checked