WARNING: return sysfs_emit(...) formats should include a terminating newline #130: FILE: drivers/ptp/ptp_ocp.c:3362: + return sysfs_emit(buf, "ttyS%d", bp->port[(uintptr_t)ea->var].line); WARNING: line length of 84 exceeds 80 columns #134: FILE: drivers/ptp/ptp_ocp.c:3366: +ptp_ocp_timecard_tty_is_visible(struct kobject *kobj, struct attribute *attr, int n) CHECK: Please use a blank line after function/struct/union/enum declarations #149: FILE: drivers/ptp/ptp_ocp.c:3381: +} +#define EXT_TTY_ATTR_RO(_name, _val) \ WARNING: line length of 82 exceeds 80 columns #151: FILE: drivers/ptp/ptp_ocp.c:3383: + { __ATTR(tty##_name, 0444, ptp_ocp_tty_show, NULL), (void *)_val } WARNING: line length of 84 exceeds 80 columns #217: FILE: drivers/ptp/ptp_ocp.c:4027: + seq_printf(s, "%7s: /dev/ttyS%d\n", "MAC", bp->port[PORT_MAC].line); WARNING: line length of 86 exceeds 80 columns #219: FILE: drivers/ptp/ptp_ocp.c:4029: + seq_printf(s, "%7s: /dev/ttyS%d\n", "NMEA", bp->port[PORT_NMEA].line); total: 0 errors, 5 warnings, 1 checks, 290 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c94728597a95 ("ptp: ocp: adjust sysfs entries to expose tty information") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 5 warnings, 1 checks, 290 lines checked