========== checkpatch - FAILED ERROR: Remove Gerrit Change-Id's before submitting upstream #30: Change-Id: If14e37966db416e1ff715c19439d071814800efe WARNING: line length of 93 exceeds 80 columns #146: FILE: include/net/devlink.h:1481: + int (*rate_traffic_class_tx_share_set)(struct devlink_rate *devlink_rate, void *priv, WARNING: line length of 93 exceeds 80 columns #147: FILE: include/net/devlink.h:1482: + u64 tx_share, struct netlink_ext_ack *extack); WARNING: line length of 91 exceeds 80 columns #148: FILE: include/net/devlink.h:1483: + int (*rate_traffic_class_tx_max_set)(struct devlink_rate *devlink_rate, void *priv, WARNING: line length of 89 exceeds 80 columns #149: FILE: include/net/devlink.h:1484: + u64 tx_max, struct netlink_ext_ack *extack); WARNING: line length of 96 exceeds 80 columns #150: FILE: include/net/devlink.h:1485: + int (*rate_traffic_class_tx_priority_set)(struct devlink_rate *devlink_rate, void *priv, WARNING: line length of 99 exceeds 80 columns #151: FILE: include/net/devlink.h:1486: + u32 tx_priority, struct netlink_ext_ack *extack); WARNING: line length of 94 exceeds 80 columns #152: FILE: include/net/devlink.h:1487: + int (*rate_traffic_class_tx_weight_set)(struct devlink_rate *devlink_rate, void *priv, WARNING: line length of 95 exceeds 80 columns #153: FILE: include/net/devlink.h:1488: + u32 tx_weight, struct netlink_ext_ack *extack); WARNING: line length of 81 exceeds 80 columns #163: FILE: include/net/devlink.h:1503: + void *priv_child, void *priv_parent, WARNING: line length of 88 exceeds 80 columns #173: FILE: include/net/devlink.h:1740: +devl_rate_traffic_class_create(struct devlink_port *devlink_port, void *priv, u16 tc_id, WARNING: line length of 89 exceeds 80 columns #262: FILE: net/devlink/rate.c:55: +devlink_rate_traffic_class_get_from_attrs(struct devlink *devlink, struct nlattr **attrs) WARNING: line length of 89 exceeds 80 columns #279: FILE: net/devlink/rate.c:72: +devlink_rate_traffic_class_get_from_info(struct devlink *devlink, struct genl_info *info) WARNING: line length of 99 exceeds 80 columns #301: FILE: net/devlink/rate.c:155: + if (nla_put_u16(msg, DEVLINK_ATTR_RATE_TRAFFIC_CLASS_INDEX, devlink_rate->tc_id) || WARNING: line length of 97 exceeds 80 columns #302: FILE: net/devlink/rate.c:156: + nla_put_u32(msg, DEVLINK_ATTR_PORT_INDEX, devlink_rate->devlink_port->index)) WARNING: line length of 84 exceeds 80 columns #312: FILE: net/devlink/rate.c:326: + err = ops->rate_traffic_class_parent_set(devlink_rate, NULL, WARNING: line length of 90 exceeds 80 columns #313: FILE: net/devlink/rate.c:327: + devlink_rate->priv, NULL, WARNING: line length of 86 exceeds 80 columns #323: FILE: net/devlink/rate.c:359: + err = ops->rate_traffic_class_parent_set(devlink_rate, parent, WARNING: line length of 98 exceeds 80 columns #324: FILE: net/devlink/rate.c:360: + devlink_rate->priv, parent->priv, WARNING: line length of 97 exceeds 80 columns #334: FILE: net/devlink/rate.c:510: + if (attrs[DEVLINK_ATTR_RATE_TX_SHARE] && !ops->rate_traffic_class_tx_share_set) { WARNING: line length of 109 exceeds 80 columns #335: FILE: net/devlink/rate.c:511: + NL_SET_ERR_MSG(info->extack, "TX share set isn't supported for the traffic classes"); WARNING: line length of 93 exceeds 80 columns #338: FILE: net/devlink/rate.c:514: + if (attrs[DEVLINK_ATTR_RATE_TX_MAX] && !ops->rate_traffic_class_tx_max_set) { WARNING: line length of 107 exceeds 80 columns #339: FILE: net/devlink/rate.c:515: + NL_SET_ERR_MSG(info->extack, "TX max set isn't supported for the traffic classes"); WARNING: line length of 107 exceeds 80 columns #344: FILE: net/devlink/rate.c:520: + NL_SET_ERR_MSG(info->extack, "Parent set isn't supported for the traffic classes"); WARNING: line length of 103 exceeds 80 columns #347: FILE: net/devlink/rate.c:523: + if (attrs[DEVLINK_ATTR_RATE_TX_PRIORITY] && !ops->rate_traffic_class_tx_priority_set) { WARNING: line length of 81 exceeds 80 columns #349: FILE: net/devlink/rate.c:525: + attrs[DEVLINK_ATTR_RATE_TX_PRIORITY], WARNING: line length of 99 exceeds 80 columns #353: FILE: net/devlink/rate.c:529: + if (attrs[DEVLINK_ATTR_RATE_TX_WEIGHT] && !ops->rate_traffic_class_tx_weight_set) { WARNING: line length of 92 exceeds 80 columns #374: FILE: net/devlink/rate.c:753: +int devl_rate_traffic_class_create(struct devlink_port *devlink_port, void *priv, u16 tc_id, WARNING: line length of 98 exceeds 80 columns #416: FILE: net/devlink/rate.c:837: + ops->rate_traffic_class_parent_set(devlink_rate, NULL, devlink_rate->priv, total: 1 errors, 28 warnings, 0 checks, 331 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 613f7a24d658 ("devlink: Extend the devlink rate API to support rate management on traffic classes") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.