WARNING: return sysfs_emit(...) formats should include a terminating newline #35: FILE: drivers/ptp/ptp_ocp.c:3357: + return sysfs_emit(buf, "ttyS%d", port->line); WARNING: line length of 84 exceeds 80 columns #39: FILE: drivers/ptp/ptp_ocp.c:3361: +ptp_ocp_timecard_tty_is_visible(struct kobject *kobj, struct attribute *attr, int n) CHECK: Please use a blank line after function/struct/union/enum declarations #54: FILE: drivers/ptp/ptp_ocp.c:3376: +} +#define EXT_TTY_ATTR_RO(_name, _val) \ WARNING: line length of 82 exceeds 80 columns #56: FILE: drivers/ptp/ptp_ocp.c:3378: + { __ATTR(tty##_name, 0444, ptp_ocp_tty_show, NULL), (void *)_val } total: 0 errors, 3 warnings, 1 checks, 98 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c393bdca713a ("ptp: ocp: adjust sysfs entries to expose tty information") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 3 warnings, 1 checks, 98 lines checked