ERROR: do not initialise statics to 0
#49: FILE: drivers/net/ethernet/broadcom/tg3.c:236:
+static int short_preamble = 0;

WARNING: suspect code indent for conditional statements (8, 12)
#61: FILE: drivers/net/ethernet/broadcom/tg3.c:1501:
+	if(short_preamble) {
+	    tp->mi_mode |= MAC_MI_MODE_SHORT_PREAMBLE;

ERROR: space required before the open parenthesis '('
#61: FILE: drivers/net/ethernet/broadcom/tg3.c:1501:
+	if(short_preamble) {

WARNING: braces {} are not necessary for single statement blocks
#61: FILE: drivers/net/ethernet/broadcom/tg3.c:1501:
+	if(short_preamble) {
+	    tp->mi_mode |= MAC_MI_MODE_SHORT_PREAMBLE;
+	}

total: 2 errors, 2 warnings, 0 checks, 21 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit cc33784fb6a2 ("tg3: Add param `short_preamble` to enable MDIO traffic to external PHYs") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.