========== checkpatch - FAILED WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #86: FILE: net/xfrm/xfrm_iptfs.c:280: + BUG_ON(skb_headlen(skb) > initial_offset); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #105: FILE: net/xfrm/xfrm_iptfs.c:299: + BUG_ON(initial_offset != 0); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #111: FILE: net/xfrm/xfrm_iptfs.c:305: + BUG_ON(offset < walk->initial_offset); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #119: FILE: net/xfrm/xfrm_iptfs.c:313: + BUG_ON(walk->fragi == 0); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #192: FILE: net/xfrm/xfrm_iptfs.c:386: + BUG_ON(skb->pp_recycle != walk->pp_recycle); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #198: FILE: net/xfrm/xfrm_iptfs.c:392: + BUG_ON(shinfo->nr_frags >= MAX_SKB_FRAGS); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #212: FILE: net/xfrm/xfrm_iptfs.c:406: + BUG_ON(shinfo->nr_frags > MAX_SKB_FRAGS); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #321: FILE: net/xfrm/xfrm_iptfs.c:870: + BUG_ON(leftover != 0); WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #324: FILE: net/xfrm/xfrm_iptfs.c:873: + BUG_ON(skb_tailroom(newskb) < copylen); ERROR: do not use assignment in if condition #373: FILE: net/xfrm/xfrm_iptfs.c:1144: + if (!fragwalk || total: 1 errors, 9 warnings, 0 checks, 360 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 74fae7c03e85 ("xfrm: iptfs: add skb-fragment sharing code") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.