WARNING: line length of 83 exceeds 80 columns #87: FILE: lib/buildid.c:38: +static void freader_init_from_mem(struct freader *r, const char *data, u64 data_sz) WARNING: line length of 88 exceeds 80 columns #144: FILE: lib/buildid.c:95: + if (!r->page || file_off < r->file_off || file_off >= r->file_off + PAGE_SIZE) { WARNING: line length of 81 exceeds 80 columns #160: FILE: lib/buildid.c:111: + memcpy(r->buf, r->page_addr + (file_off - r->file_off), part_sz); WARNING: const array should probably be static const #198: FILE: lib/buildid.c:144: + const char note_name[] = "GNU"; WARNING: line length of 86 exceeds 80 columns #208: FILE: lib/buildid.c:152: + nhdr = freader_fetch(r, note_offs, sizeof(Elf32_Nhdr) + note_name_sz); CHECK: Blank lines aren't necessary after an open brace '{' #225: FILE: lib/buildid.c:161: nhdr->n_descsz <= BUILD_ID_SIZE_MAX) { + WARNING: line length of 95 exceeds 80 columns #226: FILE: lib/buildid.c:162: + build_id_off = note_offs + sizeof(Elf32_Nhdr) + ALIGN(note_name_sz, 4); WARNING: line length of 91 exceeds 80 columns #235: FILE: lib/buildid.c:171: + memset(build_id + build_id_sz, 0, BUILD_ID_SIZE_MAX - build_id_sz); WARNING: line length of 83 exceeds 80 columns #277: FILE: lib/buildid.c:205: +static int get_build_id_32(struct freader *r, unsigned char *build_id, __u32 *size) WARNING: line length of 87 exceeds 80 columns #290: FILE: lib/buildid.c:215: + /* subsequent freader_fetch() calls invalidate pointers, so remember locally */ WARNING: line length of 84 exceeds 80 columns #301: FILE: lib/buildid.c:223: + phdr = freader_fetch(r, i * sizeof(Elf32_Phdr), sizeof(Elf32_Phdr)); WARNING: line length of 87 exceeds 80 columns #311: FILE: lib/buildid.c:228: + !parse_build_id(r, build_id, size, phdr->p_offset, phdr->p_filesz)) WARNING: line length of 83 exceeds 80 columns #320: FILE: lib/buildid.c:235: +static int get_build_id_64(struct freader *r, unsigned char *build_id, __u32 *size) WARNING: line length of 87 exceeds 80 columns #333: FILE: lib/buildid.c:245: + /* subsequent freader_fetch() calls invalidate pointers, so remember locally */ WARNING: line length of 84 exceeds 80 columns #344: FILE: lib/buildid.c:253: + phdr = freader_fetch(r, i * sizeof(Elf64_Phdr), sizeof(Elf64_Phdr)); WARNING: line length of 87 exceeds 80 columns #354: FILE: lib/buildid.c:258: + !parse_build_id(r, build_id, size, phdr->p_offset, phdr->p_filesz)) total: 0 errors, 15 warnings, 1 checks, 369 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 2ccb90ebdce6 ("lib/buildid: add single page-based file reader abstraction") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 15 warnings, 1 checks, 369 lines checked