WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #65: new file mode 100644 CHECK: Prefer kernel type 'u64' over 'uint64_t' #130: FILE: drivers/ptp/ptp_vmclock.c:61: +static inline uint64_t mul_u64_u64_shr_add_u64(uint64_t *res_hi, uint64_t delta, CHECK: Prefer kernel type 'u64' over 'uint64_t' #131: FILE: drivers/ptp/ptp_vmclock.c:62: + uint64_t period, uint8_t shift, CHECK: Prefer kernel type 'u64' over 'uint64_t' #163: FILE: drivers/ptp/ptp_vmclock.c:94: + uint64_t cycle, delta, seq, frac_sec; WARNING: memory barrier without comment #176: FILE: drivers/ptp/ptp_vmclock.c:107: + virt_rmb(); CHECK: braces {} should be used on all arms of this statement #195: FILE: drivers/ptp/ptp_vmclock.c:126: + if (sts) { [...] + } else [...] CHECK: Unbalanced braces around else statement #203: FILE: drivers/ptp/ptp_vmclock.c:134: + } else WARNING: line length of 84 exceeds 80 columns #209: FILE: drivers/ptp/ptp_vmclock.c:140: + st->clk->counter_period_frac_sec, WARNING: line length of 81 exceeds 80 columns #210: FILE: drivers/ptp/ptp_vmclock.c:141: + st->clk->counter_period_shift, WARNING: memory barrier without comment #218: FILE: drivers/ptp/ptp_vmclock.c:149: + virt_rmb(); WARNING: line length of 87 exceeds 80 columns #248: FILE: drivers/ptp/ptp_vmclock.c:179: + struct system_counterval_t *system_counter, WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #252: FILE: drivers/ptp/ptp_vmclock.c:183: + unsigned pvti_ver; WARNING: line length of 87 exceeds 80 columns #265: FILE: drivers/ptp/ptp_vmclock.c:196: + system_counter->cycles); CHECK: Please don't use multiple blank lines #307: FILE: drivers/ptp/ptp_vmclock.c:238: + + WARNING: Missing a blank line after declarations #323: FILE: drivers/ptp/ptp_vmclock.c:254: + struct system_time_snapshot systime_snapshot; + ktime_get_snapshot(&systime_snapshot); WARNING: line length of 84 exceeds 80 columns #328: FILE: drivers/ptp/ptp_vmclock.c:259: + ret = get_device_system_crosststamp(ptp_vmclock_get_time_fn, CHECK: Alignment should match open parenthesis #351: FILE: drivers/ptp/ptp_vmclock.c:282: +static int ptp_vmclock_settime(struct ptp_clock_info *ptp, + const struct timespec64 *ts) WARNING: line length of 82 exceeds 80 columns #356: FILE: drivers/ptp/ptp_vmclock.c:287: +static int ptp_vmclock_gettimex(struct ptp_clock_info *ptp, struct timespec64 *ts, CHECK: Alignment should match open parenthesis #366: FILE: drivers/ptp/ptp_vmclock.c:297: +static int ptp_vmclock_enable(struct ptp_clock_info *ptp, + struct ptp_clock_request *rq, int on) CHECK: spaces preferred around that '|' (ctx:VxV) #390: FILE: drivers/ptp/ptp_vmclock.c:321: + if ((vma->vm_flags & (VM_READ|VM_WRITE)) != VM_READ) ^ ERROR: code indent should use tabs where possible #396: FILE: drivers/ptp/ptp_vmclock.c:327: + if (io_remap_pfn_range(vma, vma->vm_start,$ WARNING: please, no spaces at the start of a line #396: FILE: drivers/ptp/ptp_vmclock.c:327: + if (io_remap_pfn_range(vma, vma->vm_start,$ ERROR: code indent should use tabs where possible #398: FILE: drivers/ptp/ptp_vmclock.c:329: + vma->vm_page_prot))$ WARNING: please, no spaces at the start of a line #398: FILE: drivers/ptp/ptp_vmclock.c:329: + vma->vm_page_prot))$ ERROR: code indent should use tabs where possible #399: FILE: drivers/ptp/ptp_vmclock.c:330: + return -EAGAIN;$ WARNING: please, no spaces at the start of a line #399: FILE: drivers/ptp/ptp_vmclock.c:330: + return -EAGAIN;$ ERROR: code indent should use tabs where possible #401: FILE: drivers/ptp/ptp_vmclock.c:332: + return 0;$ WARNING: please, no spaces at the start of a line #401: FILE: drivers/ptp/ptp_vmclock.c:332: + return 0;$ CHECK: Prefer kernel type 's32' over 'int32_t' #411: FILE: drivers/ptp/ptp_vmclock.c:342: + int32_t seq; WARNING: memory barrier without comment #422: FILE: drivers/ptp/ptp_vmclock.c:353: + virt_rmb(); WARNING: memory barrier without comment #427: FILE: drivers/ptp/ptp_vmclock.c:358: + virt_rmb(); ERROR: code indent should use tabs where possible #440: FILE: drivers/ptp/ptp_vmclock.c:371: + .mmap = vmclock_miscdev_mmap,$ WARNING: please, no spaces at the start of a line #440: FILE: drivers/ptp/ptp_vmclock.c:371: + .mmap = vmclock_miscdev_mmap,$ ERROR: code indent should use tabs where possible #441: FILE: drivers/ptp/ptp_vmclock.c:372: + .read = vmclock_miscdev_read,$ WARNING: please, no spaces at the start of a line #441: FILE: drivers/ptp/ptp_vmclock.c:372: + .read = vmclock_miscdev_read,$ WARNING: line length of 81 exceeds 80 columns #458: FILE: drivers/ptp/ptp_vmclock.c:389: +static acpi_status vmclock_acpi_resources(struct acpi_resource *ares, void *data) CHECK: Unnecessary parentheses around win.res #462: FILE: drivers/ptp/ptp_vmclock.c:393: + struct resource *res = &(win.res); ERROR: code indent should use tabs where possible #471: FILE: drivers/ptp/ptp_vmclock.c:402: + if (acpi_dev_resource_memory(ares, res) ||$ WARNING: please, no spaces at the start of a line #471: FILE: drivers/ptp/ptp_vmclock.c:402: + if (acpi_dev_resource_memory(ares, res) ||$ CHECK: Blank lines aren't necessary after an open brace '{' #473: FILE: drivers/ptp/ptp_vmclock.c:404: + acpi_dev_resource_address_space(ares, &win)) { + ERROR: code indent should use tabs where possible #490: FILE: drivers/ptp/ptp_vmclock.c:421: + status = acpi_walk_resources(adev->handle, METHOD_NAME__CRS,$ WARNING: please, no spaces at the start of a line #490: FILE: drivers/ptp/ptp_vmclock.c:421: + status = acpi_walk_resources(adev->handle, METHOD_NAME__CRS,$ ERROR: code indent should use tabs where possible #491: FILE: drivers/ptp/ptp_vmclock.c:422: + vmclock_acpi_resources, st);$ WARNING: please, no spaces at the start of a line #491: FILE: drivers/ptp/ptp_vmclock.c:422: + vmclock_acpi_resources, st);$ ERROR: code indent should use tabs where possible #492: FILE: drivers/ptp/ptp_vmclock.c:423: + if (ACPI_FAILURE(status) || resource_type(&st->res) != IORESOURCE_MEM) {$ WARNING: please, no spaces at the start of a line #492: FILE: drivers/ptp/ptp_vmclock.c:423: + if (ACPI_FAILURE(status) || resource_type(&st->res) != IORESOURCE_MEM) {$ ERROR: code indent should use tabs where possible #493: FILE: drivers/ptp/ptp_vmclock.c:424: + dev_err(dev, "failed to get resources\n");$ WARNING: please, no spaces at the start of a line #493: FILE: drivers/ptp/ptp_vmclock.c:424: + dev_err(dev, "failed to get resources\n");$ ERROR: code indent should use tabs where possible #494: FILE: drivers/ptp/ptp_vmclock.c:425: + return -ENODEV;$ WARNING: please, no spaces at the start of a line #494: FILE: drivers/ptp/ptp_vmclock.c:425: + return -ENODEV;$ ERROR: code indent should use tabs where possible #495: FILE: drivers/ptp/ptp_vmclock.c:426: + }$ WARNING: please, no spaces at the start of a line #495: FILE: drivers/ptp/ptp_vmclock.c:426: + }$ WARNING: space prohibited between function name and open parenthesis '(' #513: FILE: drivers/ptp/ptp_vmclock.c:444: + st = devm_kzalloc(dev, sizeof (*st), GFP_KERNEL); ERROR: code indent should use tabs where possible #549: FILE: drivers/ptp/ptp_vmclock.c:480: + ret = devm_add_action_or_reset(&pdev->dev, vmclock_put_idx, st);$ WARNING: please, no spaces at the start of a line #549: FILE: drivers/ptp/ptp_vmclock.c:480: + ret = devm_add_action_or_reset(&pdev->dev, vmclock_put_idx, st);$ WARNING: line length of 82 exceeds 80 columns #553: FILE: drivers/ptp/ptp_vmclock.c:484: + st->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "vmclock%d", st->index); WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #636: FILE: drivers/ptp/ptp_vmclock.c:567: +MODULE_LICENSE("GPL v2"); WARNING: line length of 82 exceeds 80 columns #643: FILE: include/uapi/linux/vmclock-abi.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */ WARNING: line length of 88 exceeds 80 columns #720: FILE: include/uapi/linux/vmclock-abi.h:78: +#define VMCLOCK_TIME_UTC 0 /* Since 1970-01-01 00:00:00z */ WARNING: line length of 88 exceeds 80 columns #721: FILE: include/uapi/linux/vmclock-abi.h:79: +#define VMCLOCK_TIME_TAI 1 /* Since 1970-01-01 00:00:00z */ WARNING: line length of 83 exceeds 80 columns #722: FILE: include/uapi/linux/vmclock-abi.h:80: +#define VMCLOCK_TIME_MONOTONIC 2 /* Since undefined epoch */ WARNING: Possible repeated word: 'the' #789: FILE: include/uapi/linux/vmclock-abi.h:147: + * This field is based on the the VIRTIO_RTC_LEAP_xxx values as total: 14 errors, 36 warnings, 12 checks, 780 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 5195d2460754 ("ptp: Add vDSO-style vmclock support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.