WARNING: Possible repeated word: 'is'
#139: 
It is is clear that private-stack is worse than non-private stack up to close 5 percents.

WARNING: line length of 81 exceeds 80 columns
#210: FILE: arch/x86/net/bpf_jit_comp.c:3331:
+			private_stack_ptr = __alloc_percpu_gfp(8, 8, GFP_KERNEL);

WARNING: line length of 102 exceeds 80 columns
#212: FILE: arch/x86/net/bpf_jit_comp.c:3333:
+			private_stack_ptr = __alloc_percpu_gfp(prog->aux->stack_depth, 8, GFP_KERNEL);

WARNING: line length of 84 exceeds 80 columns
#226: FILE: include/linux/bpf.h:1555:
+				disable_private_stack:1; /* Disable private stack */

WARNING: line length of 89 exceeds 80 columns
#282: FILE: kernel/bpf/syscall.c:2832:
+	prog->disable_private_stack = !!(attr->prog_flags & BPF_F_DISABLE_PRIVATE_STACK);

WARNING: externs should be avoided in .c files
#340: FILE: tools/testing/selftests/bpf/bench.c:285:
+extern struct argp bench_private_stack_argp;

WARNING: externs should be avoided in .c files
#356: FILE: tools/testing/selftests/bpf/bench.c:547:
+extern const struct bench bench_no_private_stack;

WARNING: externs should be avoided in .c files
#357: FILE: tools/testing/selftests/bpf/bench.c:548:
+extern const struct bench bench_private_stack;

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#371: 
new file mode 100644

ERROR: code indent should use tabs where possible
#398: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:23:
+        { "nr-batch-iters", ARG_NR_BATCH_ITERS, "NR_BATCH_ITERS",$

WARNING: please, no spaces at the start of a line
#398: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:23:
+        { "nr-batch-iters", ARG_NR_BATCH_ITERS, "NR_BATCH_ITERS",$

ERROR: code indent should use tabs where possible
#400: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:25:
+        {},$

WARNING: please, no spaces at the start of a line
#400: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:25:
+        {},$

WARNING: line length of 84 exceeds 80 columns
#403: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:28:
+static error_t private_stack_parse_arg(int key, char *arg, struct argp_state *state)

ERROR: code indent should use tabs where possible
#407: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:32:
+        switch (key) {$

WARNING: please, no spaces at the start of a line
#407: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:32:
+        switch (key) {$

ERROR: code indent should use tabs where possible
#408: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:33:
+        case ARG_NR_BATCH_ITERS:$

WARNING: please, no spaces at the start of a line
#408: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:33:
+        case ARG_NR_BATCH_ITERS:$

ERROR: code indent should use tabs where possible
#409: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:34:
+                ret = strtoul(arg, NULL, 10);$

WARNING: please, no spaces at the start of a line
#409: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:34:
+                ret = strtoul(arg, NULL, 10);$

ERROR: code indent should use tabs where possible
#413: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:38:
+                break;$

WARNING: please, no spaces at the start of a line
#413: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:38:
+                break;$

ERROR: code indent should use tabs where possible
#414: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:39:
+        default:$

ERROR: code indent should use tabs where possible
#415: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:40:
+                return ARGP_ERR_UNKNOWN;$

WARNING: please, no spaces at the start of a line
#415: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:40:
+                return ARGP_ERR_UNKNOWN;$

ERROR: code indent should use tabs where possible
#416: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:41:
+        }$

WARNING: please, no spaces at the start of a line
#416: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:41:
+        }$

ERROR: code indent should use tabs where possible
#418: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:43:
+        return 0;$

WARNING: please, no spaces at the start of a line
#418: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:43:
+        return 0;$

ERROR: code indent should use tabs where possible
#422: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:47:
+        .options = opts,$

WARNING: please, no spaces at the start of a line
#422: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:47:
+        .options = opts,$

ERROR: code indent should use tabs where possible
#423: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:48:
+        .parser = private_stack_parse_arg,$

WARNING: please, no spaces at the start of a line
#423: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:48:
+        .parser = private_stack_parse_arg,$

ERROR: space required before the open parenthesis '('
#443: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:68:
+	if(!skel) {

WARNING: line length of 87 exceeds 80 columns
#450: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:75:
+		old_flags = bpf_program__flags(skel->progs.bench_trigger_fentry_batch);

WARNING: line length of 120 exceeds 80 columns
#451: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:76:
+		bpf_program__set_flags(skel->progs.bench_trigger_fentry_batch, old_flags | BPF_F_DISABLE_PRIVATE_STACK);

WARNING: line length of 89 exceeds 80 columns
#464: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:89:
+		fprintf(stderr, "failed to attach program bench_trigger_fentry_batch\n");

WARNING: line length of 94 exceeds 80 columns
#539: FILE: tools/testing/selftests/bpf/benchs/run_bench_private_stack.sh:9:
+    summarize "no-private-stack-${b}: " "$($RUN_BENCH --nr-batch-iters=${b} no-private-stack)"

WARNING: line length of 88 exceeds 80 columns
#540: FILE: tools/testing/selftests/bpf/benchs/run_bench_private_stack.sh:10:
+    summarize "private-stack-${b}: " "$($RUN_BENCH --nr-batch-iters=${b} private-stack)"

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#558: FILE: tools/testing/selftests/bpf/progs/private_stack.c:11:
+const volatile int batch_iters = 0;

WARNING: line length of 81 exceeds 80 columns
#566: FILE: tools/testing/selftests/bpf/progs/private_stack.c:19:
+		(void)bpf_get_numa_node_id(); /* attach point for benchmarking */

ERROR: open brace '{' following function definitions go on the next line
#571: FILE: tools/testing/selftests/bpf/progs/private_stack.c:24:
+__attribute__((weak)) int func1(void) {

WARNING: Prefer __weak over __attribute__((weak))
#571: FILE: tools/testing/selftests/bpf/progs/private_stack.c:24:
+__attribute__((weak)) int func1(void) {

total: 14 errors, 29 warnings, 0 checks, 317 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Commit 596a8d9fe4b1 ("selftests/bpf: Benchmark runtime performance with private stack") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.