WARNING: line length of 84 exceeds 80 columns #293: FILE: include/linux/bpf.h:1555: + disable_private_stack:1; /* Disable private stack */ WARNING: line length of 89 exceeds 80 columns #342: FILE: kernel/bpf/syscall.c:2832: + prog->disable_private_stack = !!(attr->prog_flags & BPF_F_DISABLE_PRIVATE_STACK); WARNING: externs should be avoided in .c files #388: FILE: tools/testing/selftests/bpf/bench.c:285: +extern struct argp bench_private_stack_argp; WARNING: externs should be avoided in .c files #404: FILE: tools/testing/selftests/bpf/bench.c:547: +extern const struct bench bench_no_private_stack; WARNING: externs should be avoided in .c files #405: FILE: tools/testing/selftests/bpf/bench.c:548: +extern const struct bench bench_private_stack; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #419: new file mode 100644 ERROR: code indent should use tabs where possible #446: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:23: + { "nr-batch-iters", ARG_NR_BATCH_ITERS, "NR_BATCH_ITERS",$ WARNING: please, no spaces at the start of a line #446: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:23: + { "nr-batch-iters", ARG_NR_BATCH_ITERS, "NR_BATCH_ITERS",$ ERROR: code indent should use tabs where possible #448: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:25: + {},$ WARNING: please, no spaces at the start of a line #448: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:25: + {},$ WARNING: line length of 84 exceeds 80 columns #451: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:28: +static error_t private_stack_parse_arg(int key, char *arg, struct argp_state *state) ERROR: code indent should use tabs where possible #455: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:32: + switch (key) {$ WARNING: please, no spaces at the start of a line #455: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:32: + switch (key) {$ ERROR: code indent should use tabs where possible #456: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:33: + case ARG_NR_BATCH_ITERS:$ WARNING: please, no spaces at the start of a line #456: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:33: + case ARG_NR_BATCH_ITERS:$ ERROR: code indent should use tabs where possible #457: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:34: + ret = strtoul(arg, NULL, 10);$ WARNING: please, no spaces at the start of a line #457: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:34: + ret = strtoul(arg, NULL, 10);$ ERROR: code indent should use tabs where possible #461: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:38: + break;$ WARNING: please, no spaces at the start of a line #461: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:38: + break;$ ERROR: code indent should use tabs where possible #462: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:39: + default:$ ERROR: code indent should use tabs where possible #463: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:40: + return ARGP_ERR_UNKNOWN;$ WARNING: please, no spaces at the start of a line #463: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:40: + return ARGP_ERR_UNKNOWN;$ ERROR: code indent should use tabs where possible #464: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:41: + }$ WARNING: please, no spaces at the start of a line #464: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:41: + }$ ERROR: code indent should use tabs where possible #466: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:43: + return 0;$ WARNING: please, no spaces at the start of a line #466: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:43: + return 0;$ ERROR: code indent should use tabs where possible #470: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:47: + .options = opts,$ WARNING: please, no spaces at the start of a line #470: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:47: + .options = opts,$ ERROR: code indent should use tabs where possible #471: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:48: + .parser = private_stack_parse_arg,$ WARNING: please, no spaces at the start of a line #471: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:48: + .parser = private_stack_parse_arg,$ ERROR: space required before the open parenthesis '(' #491: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:68: + if(!skel) { WARNING: line length of 100 exceeds 80 columns #499: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:76: + bpf_program__set_flags(skel->progs.stack0, old_flags | BPF_F_DISABLE_PRIVATE_STACK); WARNING: line length of 94 exceeds 80 columns #582: FILE: tools/testing/selftests/bpf/benchs/run_bench_private_stack.sh:9: + summarize "no-private-stack-${b}: " "$($RUN_BENCH --nr-batch-iters=${b} no-private-stack)" WARNING: line length of 88 exceeds 80 columns #583: FILE: tools/testing/selftests/bpf/benchs/run_bench_private_stack.sh:10: + summarize "private-stack-${b}: " "$($RUN_BENCH --nr-batch-iters=${b} private-stack)" ERROR: code indent should use tabs where possible #601: FILE: tools/testing/selftests/bpf/progs/private_stack.c:11: + unsigned int d[12];$ WARNING: please, no spaces at the start of a line #601: FILE: tools/testing/selftests/bpf/progs/private_stack.c:11: + unsigned int d[12];$ ERROR: code indent should use tabs where possible #605: FILE: tools/testing/selftests/bpf/progs/private_stack.c:15: + __uint(type, BPF_MAP_TYPE_HASH);$ WARNING: please, no spaces at the start of a line #605: FILE: tools/testing/selftests/bpf/progs/private_stack.c:15: + __uint(type, BPF_MAP_TYPE_HASH);$ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #612: FILE: tools/testing/selftests/bpf/progs/private_stack.c:22: +const volatile int batch_iters = 0; total: 15 errors, 24 warnings, 0 checks, 294 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit fb1c62b8c05a ("selftests/bpf: Benchmark runtime performance with private stack") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.