WARNING: Co-developed-by and Signed-off-by: name/email do not match #17: Co-developed-by: Dan Williams Signed-off-by: NIPA Bot CHECK: Please don't use multiple blank lines #76: FILE: drivers/cxl/core/memdev.c:715: + ERROR: spaces required around that '=' (ctx:VxW) #85: FILE: drivers/cxl/core/memdev.c:724: + cxlds->serial= serial; ^ WARNING: 'unkown' may be misspelled - perhaps 'unknown'? #103: FILE: drivers/cxl/core/memdev.c:742: + dev_err(cxlds->dev, "unkown resource type (%u)\n", type); ^^^^^^ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #154: new file mode 100644 CHECK: Please don't use multiple blank lines #169: FILE: drivers/net/ethernet/sfc/efx_cxl.c:11: + + CHECK: spaces preferred around that '*' (ctx:VxV) #177: FILE: drivers/net/ethernet/sfc/efx_cxl.c:19: +#define EFX_CTPIO_BUFFER_SIZE (1024*1024*256) ^ CHECK: spaces preferred around that '*' (ctx:VxV) #177: FILE: drivers/net/ethernet/sfc/efx_cxl.c:19: +#define EFX_CTPIO_BUFFER_SIZE (1024*1024*256) ^ CHECK: Please don't use multiple blank lines #210: FILE: drivers/net/ethernet/sfc/efx_cxl.c:52: + + WARNING: Improper SPDX comment style for 'drivers/net/ethernet/sfc/efx_cxl.h', please use '/*' instead #218: FILE: drivers/net/ethernet/sfc/efx_cxl.h:1: +// SPDX-License-Identifier: GPL-2.0-only WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #218: FILE: drivers/net/ethernet/sfc/efx_cxl.h:1: +// SPDX-License-Identifier: GPL-2.0-only WARNING: missing space after enum definition #290: FILE: include/linux/cxl_accel_mem.h:9: +enum accel_resource{ WARNING: do not add new typedefs #296: FILE: include/linux/cxl_accel_mem.h:15: +typedef struct cxl_dev_state cxl_accel_state; CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues #323: FILE: include/linux/cxl_accel_pci.h:14: +#define CXL_DVSEC_RANGE_SIZE_HIGH(i) (0x18 + (i * 0x10)) CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues #324: FILE: include/linux/cxl_accel_pci.h:15: +#define CXL_DVSEC_RANGE_SIZE_LOW(i) (0x1C + (i * 0x10)) CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues #328: FILE: include/linux/cxl_accel_pci.h:19: +#define CXL_DVSEC_RANGE_BASE_HIGH(i) (0x20 + (i * 0x10)) CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues #329: FILE: include/linux/cxl_accel_pci.h:20: +#define CXL_DVSEC_RANGE_BASE_LOW(i) (0x24 + (i * 0x10)) total: 1 errors, 7 warnings, 9 checks, 249 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f0921d8e7e1d ("cxl: add type2 device basic support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.