========== checkpatch - FAILED WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #72: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #77: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_netem.c:1: +#include CHECK: spaces preferred around that '*' (ctx:WxV) #95: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_netem.c:19: + struct sk_buff __kptr *skb; ^ ERROR: Macros with complex values should be enclosed in parentheses #115: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_netem.c:39: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) WARNING: Prefer __aligned(8) over __attribute__((aligned(8))) #115: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_netem.c:39: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) CHECK: spaces preferred around that '<<' (ctx:VxV) #141: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_netem.c:65: + answer = (value * ((1ull<<32) - rho) + state->last * rho) >> 32; ^ WARNING: From:/Signed-off-by: email address mismatch: 'From: Amery Hung ' != 'Signed-off-by: Amery Hung ' total: 1 errors, 4 warnings, 2 checks, 304 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a4f8ae10ec34 ("selftests: Add a bpf netem qdisc to selftest") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.