CHECK: braces {} should be used on all arms of this statement #44: FILE: tools/lib/bpf/str_error.c:26: + if (ret == EINVAL) { [...] + } else [...] WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #45: FILE: tools/lib/bpf/str_error.c:27: + if (err == ENOTSUPP) WARNING: line length of 89 exceeds 80 columns #46: FILE: tools/lib/bpf/str_error.c:28: + snprintf(dst, len, "Operation not supported (%d)", -err); WARNING: line length of 88 exceeds 80 columns #48: FILE: tools/lib/bpf/str_error.c:30: + /* strerror_r() doesn't recognize this specific error */ WARNING: line length of 95 exceeds 80 columns #49: FILE: tools/lib/bpf/str_error.c:31: + snprintf(dst, len, "unknown error (%d)", err < 0 ? err : -err); CHECK: Unbalanced braces around else statement #50: FILE: tools/lib/bpf/str_error.c:32: + } else WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #62: FILE: tools/lib/bpf/str_error.h:7: +#ifndef ENOTSUPP WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #63: FILE: tools/lib/bpf/str_error.h:8: +#define ENOTSUPP 524 total: 0 errors, 6 warnings, 2 checks, 27 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7ad7b0d5b7ee ("libbpf: handle ENOTSUPP in libbpf_strerror_r") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 6 warnings, 2 checks, 27 lines checked