WARNING: line length of 84 exceeds 80 columns #191: FILE: include/linux/bpf.h:1555: + disable_private_stack:1; /* Disable private stack */ WARNING: line length of 89 exceeds 80 columns #240: FILE: kernel/bpf/syscall.c:2832: + prog->disable_private_stack = !!(attr->prog_flags & BPF_F_DISABLE_PRIVATE_STACK); WARNING: externs should be avoided in .c files #286: FILE: tools/testing/selftests/bpf/bench.c:285: +extern struct argp bench_private_stack_argp; WARNING: externs should be avoided in .c files #302: FILE: tools/testing/selftests/bpf/bench.c:547: +extern const struct bench bench_no_private_stack; WARNING: externs should be avoided in .c files #303: FILE: tools/testing/selftests/bpf/bench.c:548: +extern const struct bench bench_private_stack; WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #317: new file mode 100644 WARNING: line length of 86 exceeds 80 columns #344: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:23: + { "disable-private-stack", ARG_DISABLE_PRIVATE_STACK, "DISABLE_PRIVATE_STACK", ERROR: code indent should use tabs where possible #344: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:23: + { "disable-private-stack", ARG_DISABLE_PRIVATE_STACK, "DISABLE_PRIVATE_STACK",$ WARNING: please, no spaces at the start of a line #344: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:23: + { "disable-private-stack", ARG_DISABLE_PRIVATE_STACK, "DISABLE_PRIVATE_STACK",$ ERROR: code indent should use tabs where possible #346: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:25: + {},$ WARNING: please, no spaces at the start of a line #346: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:25: + {},$ WARNING: line length of 84 exceeds 80 columns #349: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:28: +static error_t private_stack_parse_arg(int key, char *arg, struct argp_state *state) ERROR: code indent should use tabs where possible #353: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:32: + switch (key) {$ WARNING: please, no spaces at the start of a line #353: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:32: + switch (key) {$ ERROR: code indent should use tabs where possible #354: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:33: + case ARG_DISABLE_PRIVATE_STACK:$ WARNING: please, no spaces at the start of a line #354: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:33: + case ARG_DISABLE_PRIVATE_STACK:$ ERROR: code indent should use tabs where possible #355: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:34: + ret = strtoul(arg, NULL, 10);$ WARNING: please, no spaces at the start of a line #355: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:34: + ret = strtoul(arg, NULL, 10);$ ERROR: code indent should use tabs where possible #359: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:38: + break;$ WARNING: please, no spaces at the start of a line #359: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:38: + break;$ ERROR: code indent should use tabs where possible #360: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:39: + default:$ ERROR: code indent should use tabs where possible #361: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:40: + return ARGP_ERR_UNKNOWN;$ WARNING: please, no spaces at the start of a line #361: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:40: + return ARGP_ERR_UNKNOWN;$ ERROR: code indent should use tabs where possible #362: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:41: + }$ WARNING: please, no spaces at the start of a line #362: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:41: + }$ ERROR: code indent should use tabs where possible #364: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:43: + return 0;$ WARNING: please, no spaces at the start of a line #364: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:43: + return 0;$ ERROR: code indent should use tabs where possible #368: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:47: + .options = opts,$ WARNING: please, no spaces at the start of a line #368: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:47: + .options = opts,$ ERROR: code indent should use tabs where possible #369: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:48: + .parser = private_stack_parse_arg,$ WARNING: please, no spaces at the start of a line #369: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:48: + .parser = private_stack_parse_arg,$ ERROR: space required before the open parenthesis '(' #389: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:68: + if(!skel) { WARNING: line length of 100 exceeds 80 columns #397: FILE: tools/testing/selftests/bpf/benchs/bench_private_stack.c:76: + bpf_program__set_flags(skel->progs.stack0, old_flags | BPF_F_DISABLE_PRIVATE_STACK); WARNING: line length of 89 exceeds 80 columns #477: FILE: tools/testing/selftests/bpf/benchs/run_bench_private_stack.sh:8: +summarize "no-private-stack: " "$($RUN_BENCH --disable-private-stack 1 no-private-stack)" ERROR: code indent should use tabs where possible #495: FILE: tools/testing/selftests/bpf/progs/private_stack.c:11: + unsigned int d[12];$ WARNING: please, no spaces at the start of a line #495: FILE: tools/testing/selftests/bpf/progs/private_stack.c:11: + unsigned int d[12];$ ERROR: code indent should use tabs where possible #499: FILE: tools/testing/selftests/bpf/progs/private_stack.c:15: + __uint(type, BPF_MAP_TYPE_HASH);$ WARNING: please, no spaces at the start of a line #499: FILE: tools/testing/selftests/bpf/progs/private_stack.c:15: + __uint(type, BPF_MAP_TYPE_HASH);$ total: 15 errors, 23 warnings, 0 checks, 286 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 1ad311c7898f ("selftests/bpf: Benchmark runtime performance with private stack") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.