WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 ERROR: do not initialise globals to 0 #43: FILE: tools/testing/selftests/bpf/prog_tests/timer_lockup.c:14: +volatile int k = 0; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #43: FILE: tools/testing/selftests/bpf/prog_tests/timer_lockup.c:14: +volatile int k = 0; CHECK: Alignment should match open parenthesis #47: FILE: tools/testing/selftests/bpf/prog_tests/timer_lockup.c:18: + LIBBPF_OPTS(bpf_test_run_opts, opts, + .data_in = &pkt_v4, WARNING: line length of 99 exceeds 80 columns #57: FILE: tools/testing/selftests/bpf/prog_tests/timer_lockup.c:28: + ASSERT_OK(pthread_setaffinity_np(pthread_self(), sizeof(cpuset), &cpuset), "cpu affinity"); WARNING: line length of 90 exceeds 80 columns #90: FILE: tools/testing/selftests/bpf/prog_tests/timer_lockup.c:61: + if (!ASSERT_OK(pthread_create(&thrds[0], NULL, timer_lockup_thread, &timer1_prog), WARNING: line length of 90 exceeds 80 columns #93: FILE: tools/testing/selftests/bpf/prog_tests/timer_lockup.c:64: + if (!ASSERT_OK(pthread_create(&thrds[1], NULL, timer_lockup_thread, &timer2_prog), WARNING: void function return statements are not generally useful #115: FILE: tools/testing/selftests/bpf/prog_tests/timer_lockup.c:86: + return; +} WARNING: braces {} are not necessary for single statement blocks #160: FILE: tools/testing/selftests/bpf/progs/timer_lockup.c:39: + if (timer) { + timer2_err = bpf_timer_cancel(timer); + } WARNING: braces {} are not necessary for single statement blocks #172: FILE: tools/testing/selftests/bpf/progs/timer_lockup.c:51: + if (timer) { + timer1_err = bpf_timer_cancel(timer); + } total: 1 errors, 8 warnings, 1 checks, 173 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit bd3a1b84aef1 ("selftests/bpf: Add timer lockup selftest") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.