WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 WARNING: externs should be avoided in .c files #63: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:27: +extern struct task_struct *bpf_task_from_vpid(pid_t vpid) __ksym; WARNING: line length of 83 exceeds 80 columns #66: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:30: +extern struct sock *bpf_sock_from_task_fd(struct task_struct *task, int fd) __ksym; WARNING: externs should be avoided in .c files #66: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:30: +extern struct sock *bpf_sock_from_task_fd(struct task_struct *task, int fd) __ksym; WARNING: externs should be avoided in .c files #69: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:33: +extern struct udp_sock *bpf_udp_sock_from_sock(struct sock *sk) __ksym; WARNING: line length of 81 exceeds 80 columns #70: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:34: +extern struct sk_buff_head *bpf_receive_queue_from_sock(struct sock *sk) __ksym; WARNING: externs should be avoided in .c files #70: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:34: +extern struct sk_buff_head *bpf_receive_queue_from_sock(struct sock *sk) __ksym; WARNING: externs should be avoided in .c files #71: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:35: +extern struct sk_buff_head *bpf_write_queue_from_sock(struct sock *sk) __ksym; WARNING: line length of 87 exceeds 80 columns #72: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:36: +extern struct sk_buff_head *bpf_reader_queue_from_udp_sock(struct udp_sock *up) __ksym; WARNING: externs should be avoided in .c files #72: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:36: +extern struct sk_buff_head *bpf_reader_queue_from_udp_sock(struct udp_sock *up) __ksym; WARNING: line length of 87 exceeds 80 columns #74: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:38: +extern int bpf_iter_skb_new(struct bpf_iter_skb *it, struct sk_buff_head *head) __ksym; WARNING: externs should be avoided in .c files #75: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:39: +extern struct sk_buff *bpf_iter_skb_next(struct bpf_iter_skb *it) __ksym; WARNING: line length of 114 exceeds 80 columns #78: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:42: +extern int bpf_iter_skb_data_new(struct bpf_iter_skb_data *it, struct sk_buff *skb, char *buf, int buflen) __ksym; WARNING: externs should be avoided in .c files #79: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:43: +extern char *bpf_iter_skb_data_next(struct bpf_iter_skb_data *it) __ksym; WARNING: line length of 98 exceeds 80 columns #80: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:44: +extern void bpf_iter_skb_data_set_buf(struct bpf_iter_skb_data *it, char *buf, int buflen) __ksym; WARNING: externs should be avoided in .c files #86: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:50: +extern struct sk_buff *bpf_skb_peek_tail(struct sk_buff_head *head) __ksym; WARNING: line length of 92 exceeds 80 columns #89: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:53: +extern struct sk_buff *bpf_restore_skb_rcv_queue(struct sk_buff_head *head, struct sock *sk, WARNING: externs should be avoided in .c files #89: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:53: +extern struct sk_buff *bpf_restore_skb_rcv_queue(struct sk_buff_head *head, struct sock *sk, WARNING: line length of 92 exceeds 80 columns #90: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:54: + struct bpf_crib_skb_info *skb_info) __ksym; WARNING: line length of 93 exceeds 80 columns #91: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:55: +extern int bpf_restore_skb_data(struct sk_buff *skb, int offset, char *data, int len) __ksym; WARNING: Missing a blank line after declarations #103: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:67: + struct event_skb_data *e_skb_data; + e_skb_data = bpf_ringbuf_reserve(&rb, sizeof(struct event_skb_data), 0); WARNING: line length of 91 exceeds 80 columns #109: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:73: + bpf_iter_skb_data_new(&skb_data_it, skb, e_skb_data->buf, sizeof(e_skb_data->buf)); WARNING: line length of 89 exceeds 80 columns #114: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:78: + e_skb_data->chunk_length = bpf_iter_skb_data_get_chunk_len(&skb_data_it); WARNING: line length of 88 exceeds 80 columns #122: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:86: + e_skb_data = bpf_ringbuf_reserve(&rb, sizeof(struct event_skb_data), 0); WARNING: line length of 98 exceeds 80 columns #128: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:92: + bpf_iter_skb_data_set_buf(&skb_data_it, e_skb_data->buf, sizeof(e_skb_data->buf)); WARNING: line length of 90 exceeds 80 columns #130: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:94: + /* Discard the pre-allocated buffer in the last iteration (it will not be used) */ WARNING: line length of 96 exceeds 80 columns #148: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:112: + struct event_skb *e_skb = bpf_ringbuf_reserve(&rb, sizeof(struct event_skb), 0); WARNING: Missing a blank line after declarations #149: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:113: + struct event_skb *e_skb = bpf_ringbuf_reserve(&rb, sizeof(struct event_skb), 0); + if (!e_skb) { WARNING: line length of 83 exceeds 80 columns #161: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:125: + e_skb->transport_header = BPF_CORE_READ(cur_skb, transport_header); WARNING: Missing a blank line after declarations #170: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:134: + unsigned char *data = BPF_CORE_READ(cur_skb, data); + e_skb->headerlen = data - head; //skb_headroom WARNING: Missing a blank line after declarations #189: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:153: + struct sk_buff_head *write_queue_head = bpf_write_queue_from_sock(sk); + return dump_all_queue_skb(write_queue_head, EVENT_SUBTYPE_WRITE_QUEUE); WARNING: line length of 82 exceeds 80 columns #194: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:158: + struct sk_buff_head *receive_queue_head = bpf_receive_queue_from_sock(sk); WARNING: line length of 83 exceeds 80 columns #195: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:159: + return dump_all_queue_skb(receive_queue_head, EVENT_SUBTYPE_RECEIVE_QUEUE); WARNING: Missing a blank line after declarations #195: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:159: + struct sk_buff_head *receive_queue_head = bpf_receive_queue_from_sock(sk); + return dump_all_queue_skb(receive_queue_head, EVENT_SUBTYPE_RECEIVE_QUEUE); WARNING: line length of 84 exceeds 80 columns #201: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:165: + struct sk_buff_head *reader_queue_head = bpf_reader_queue_from_udp_sock(up); WARNING: line length of 81 exceeds 80 columns #202: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:166: + return dump_all_queue_skb(reader_queue_head, EVENT_SUBTYPE_READER_QUEUE); WARNING: Missing a blank line after declarations #202: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:166: + struct sk_buff_head *reader_queue_head = bpf_reader_queue_from_udp_sock(up); + return dump_all_queue_skb(reader_queue_head, EVENT_SUBTYPE_READER_QUEUE); WARNING: Missing a blank line after declarations #211: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:175: + struct task_struct *task = bpf_task_from_vpid(arg->pid); + if (!task) { WARNING: Missing a blank line after declarations #217: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:181: + struct sock *sk = bpf_sock_from_task_fd(task, arg->fd); + if (!sk) { WARNING: line length of 93 exceeds 80 columns #226: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:190: + struct event_hdr *e_dump_end = bpf_ringbuf_reserve(&rb, sizeof(struct event_hdr), 0); WARNING: Missing a blank line after declarations #227: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:191: + struct event_hdr *e_dump_end = bpf_ringbuf_reserve(&rb, sizeof(struct event_hdr), 0); + if (!e_dump_end) { WARNING: line length of 96 exceeds 80 columns #243: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:207: +static int handle_restore_skb_data(struct event_skb_data *e_skb_data, struct sk_buff_head *head) WARNING: Missing a blank line after declarations #246: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:210: + struct sk_buff *skb = bpf_skb_peek_tail(head); + if (!skb) WARNING: line length of 97 exceeds 80 columns #249: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:213: + bpf_restore_skb_data(skb, e_skb_data->offset, e_skb_data->buf, e_skb_data->chunk_length); WARNING: line length of 98 exceeds 80 columns #255: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:219: +static int handle_restore_skb(struct event_skb *e_skb, struct sk_buff_head *head, struct sock *sk) WARNING: Missing a blank line after declarations #258: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:222: + struct bpf_crib_skb_info skb_info; + skb_info.headerlen = e_skb->headerlen; WARNING: Missing a blank line after declarations #270: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:234: + struct sk_buff *skb = bpf_restore_skb_rcv_queue(head, sk, &skb_info); + if (!skb) WARNING: Missing a blank line after declarations #283: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:247: + struct task_struct *task = bpf_task_from_vpid(arg_context->pid); + if (!task) { WARNING: Missing a blank line after declarations #289: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:253: + struct sock *sk = bpf_sock_from_task_fd(task, arg_context->fd); + if (!sk) { WARNING: line length of 87 exceeds 80 columns #299: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:263: + struct event_hdr *e_hdr = bpf_dynptr_data(dynptr, 0, sizeof(struct event_hdr)); WARNING: Missing a blank line after declarations #300: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:264: + struct event_hdr *e_hdr = bpf_dynptr_data(dynptr, 0, sizeof(struct event_hdr)); + if (!e_hdr) { WARNING: line length of 95 exceeds 80 columns #306: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:270: + struct event_skb *e_skb = bpf_dynptr_data(dynptr, 0, sizeof(struct event_skb)); WARNING: Missing a blank line after declarations #307: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:271: + struct event_skb *e_skb = bpf_dynptr_data(dynptr, 0, sizeof(struct event_skb)); + if (!e_skb) { WARNING: line length of 110 exceeds 80 columns #317: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:281: + struct event_skb_data *e_skb_data = bpf_dynptr_data(dynptr, 0, sizeof(struct event_skb_data)); WARNING: Missing a blank line after declarations #318: FILE: tools/testing/selftests/crib/test_restore_udp_socket.bpf.c:282: + struct event_skb_data *e_skb_data = bpf_dynptr_data(dynptr, 0, sizeof(struct event_skb_data)); + if (!e_skb_data) { CHECK: Alignment should match open parenthesis #410: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:57: + DECLARE_LIBBPF_OPTS(bpf_test_run_opts, opts, + .ctx_in = &arg_restore, WARNING: line length of 93 exceeds 80 columns #422: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:69: + send(sockfd_restore, e_skb_data->buf + last_skb_transport_header + 8, WARNING: line length of 93 exceeds 80 columns #423: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:70: + e_skb_data->chunk_length - last_skb_transport_header - 8, 0); CHECK: Alignment should match open parenthesis #423: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:70: + send(sockfd_restore, e_skb_data->buf + last_skb_transport_header + 8, + e_skb_data->chunk_length - last_skb_transport_header - 8, 0); WARNING: line length of 91 exceeds 80 columns #426: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:73: + send(sockfd_restore, e_skb_data->buf, e_skb_data->chunk_length, 0); WARNING: line length of 147 exceeds 80 columns #429: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:76: + struct event_skb_data *e_restore_skb_data = (struct event_skb_data *)user_ring_buffer__reserve(urb, sizeof(struct event_skb_data)); WARNING: Missing a blank line after declarations #430: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:77: + struct event_skb_data *e_restore_skb_data = (struct event_skb_data *)user_ring_buffer__reserve(urb, sizeof(struct event_skb_data)); + if (!e_restore_skb_data) { WARNING: line length of 91 exceeds 80 columns #440: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:87: + memcpy(e_restore_skb_data->buf, e_skb_data->buf, e_skb_data->chunk_length); WARNING: line length of 119 exceeds 80 columns #454: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:101: + struct event_skb *e_restore_skb = (struct event_skb *)user_ring_buffer__reserve(urb, sizeof(struct event_skb)); WARNING: Missing a blank line after declarations #455: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:102: + struct event_skb *e_restore_skb = (struct event_skb *)user_ring_buffer__reserve(urb, sizeof(struct event_skb)); + if (!e_restore_skb) { WARNING: line length of 89 exceeds 80 columns #504: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:151: + if (setsockopt(sockfd_restore, IPPROTO_UDP, UDP_CORK, &disable, sizeof(disable))) WARNING: Missing a blank line after declarations #504: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:151: + const int disable = 0; + if (setsockopt(sockfd_restore, IPPROTO_UDP, UDP_CORK, &disable, sizeof(disable))) WARNING: Missing a blank line after declarations #508: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:155: + char buffer1[1000], buffer2[2000]; + memset(buffer1, 0, sizeof(buffer1)); WARNING: Missing a blank line after declarations #513: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:160: + socklen_t sockaddr_len = sizeof(struct sockaddr_in); + memset(&src_addr, 0, sizeof(struct sockaddr_in)); WARNING: line length of 91 exceeds 80 columns #516: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:163: + if (getsockname(sockfd_client, (struct sockaddr *)&client_src_addr, &sockaddr_len)) WARNING: line length of 116 exceeds 80 columns #519: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:166: + if (recvfrom(sockfd_restore, buffer1, sizeof(buffer1), 0, (struct sockaddr *)&src_addr, &sockaddr_len) <= 0) WARNING: line length of 112 exceeds 80 columns #525: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:172: + if (src_addr.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || src_addr.sin_port != client_src_addr.sin_port) WARNING: line length of 116 exceeds 80 columns #528: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:175: + if (recvfrom(sockfd_restore, buffer1, sizeof(buffer1), 0, (struct sockaddr *)&src_addr, &sockaddr_len) <= 0) WARNING: line length of 112 exceeds 80 columns #534: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:181: + if (src_addr.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || src_addr.sin_port != client_src_addr.sin_port) WARNING: line length of 115 exceeds 80 columns #537: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:184: + if (recvfrom(sockfd_server, buffer2, sizeof(buffer2), 0, (struct sockaddr *)&src_addr, &sockaddr_len) <= 0) WARNING: line length of 92 exceeds 80 columns #543: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:190: + if (memcmp(buffer2 + sizeof(buffer_send1), buffer_send2, sizeof(buffer_send2)) != 0) WARNING: Missing a blank line after declarations #556: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:203: + char buffer[1000]; + memset(buffer, 0, sizeof(buffer)); WARNING: Missing a blank line after declarations #560: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:207: + socklen_t sockaddr_len = sizeof(struct sockaddr_in); + memset(&src_addr, 0, sizeof(struct sockaddr_in)); WARNING: line length of 93 exceeds 80 columns #563: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:210: + if (getsockname(sockfd_restore, (struct sockaddr *)&restore_src_addr, &sockaddr_len)) WARNING: line length of 105 exceeds 80 columns #566: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:213: + if (connect(sockfd_server, (struct sockaddr *)&restore_src_addr, sizeof(struct sockaddr_in)) < 0) WARNING: line length of 113 exceeds 80 columns #575: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:222: + if (recvfrom(sockfd_server, buffer, sizeof(buffer), 0, (struct sockaddr *)&src_addr, &sockaddr_len) <= 0) WARNING: line length of 114 exceeds 80 columns #581: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:228: + if (recvfrom(sockfd_restore, buffer, sizeof(buffer), 0, (struct sockaddr *)&src_addr, &sockaddr_len) <= 0) WARNING: line length of 99 exceeds 80 columns #587: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:234: + if (src_addr.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || src_addr.sin_port != htons(6003)) WARNING: line length of 85 exceeds 80 columns #595: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:242: + sockfd_checkpoint = socket(AF_INET, SOCK_DGRAM | SOCK_NONBLOCK, IPPROTO_UDP); WARNING: line length of 82 exceeds 80 columns #598: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:245: + sockfd_restore = socket(AF_INET, SOCK_DGRAM | SOCK_NONBLOCK, IPPROTO_UDP); WARNING: line length of 81 exceeds 80 columns #601: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:248: + sockfd_client = socket(AF_INET, SOCK_DGRAM | SOCK_NONBLOCK, IPPROTO_UDP); WARNING: line length of 81 exceeds 80 columns #604: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:251: + sockfd_server = socket(AF_INET, SOCK_DGRAM | SOCK_NONBLOCK, IPPROTO_UDP); WARNING: line length of 103 exceeds 80 columns #626: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:273: + ASSERT_EQ(setsockopt(sockfd_checkpoint, SOL_SOCKET, SO_REUSEADDR, &enable, sizeof(enable)), 0); WARNING: Missing a blank line after declarations #626: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:273: + const int enable = 1; + ASSERT_EQ(setsockopt(sockfd_checkpoint, SOL_SOCKET, SO_REUSEADDR, &enable, sizeof(enable)), 0); WARNING: line length of 99 exceeds 80 columns #627: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:274: + ASSERT_EQ(setsockopt(sockfd_server, SOL_SOCKET, SO_REUSEADDR, &enable, sizeof(enable)), 0); WARNING: line length of 100 exceeds 80 columns #629: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:276: + ASSERT_EQ(setsockopt(sockfd_checkpoint, IPPROTO_UDP, UDP_CORK, &enable, sizeof(enable)), 0); WARNING: line length of 97 exceeds 80 columns #630: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:277: + ASSERT_EQ(setsockopt(sockfd_restore, IPPROTO_UDP, UDP_CORK, &enable, sizeof(enable)), 0); WARNING: line length of 115 exceeds 80 columns #632: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:279: + ASSERT_EQ(bind(sockfd_checkpoint, (struct sockaddr *)&checkpoint_src_addr, sizeof(struct sockaddr_in)), 0); WARNING: line length of 108 exceeds 80 columns #633: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:280: + ASSERT_EQ(bind(sockfd_server, (struct sockaddr *)&restore_dst_addr, sizeof(struct sockaddr_in)), 0); WARNING: line length of 114 exceeds 80 columns #640: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:287: + ASSERT_EQ(connect(sockfd_client, (struct sockaddr *)&checkpoint_src_addr, sizeof(struct sockaddr_in)), 0); WARNING: line length of 100 exceeds 80 columns #641: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:288: + ASSERT_EQ(send(sockfd_client, buffer_recv1, sizeof(buffer_recv1), 0), sizeof(buffer_recv1)); WARNING: line length of 100 exceeds 80 columns #642: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:289: + ASSERT_EQ(send(sockfd_client, buffer_recv2, sizeof(buffer_recv2), 0), sizeof(buffer_recv2)); WARNING: line length of 118 exceeds 80 columns #644: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:291: + ASSERT_EQ(connect(sockfd_checkpoint, (struct sockaddr *)&checkpoint_dst_addr, sizeof(struct sockaddr_in)), 0); WARNING: line length of 112 exceeds 80 columns #645: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:292: + ASSERT_EQ(connect(sockfd_restore, (struct sockaddr *)&restore_dst_addr, sizeof(struct sockaddr_in)), 0); WARNING: line length of 104 exceeds 80 columns #647: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:294: + ASSERT_EQ(send(sockfd_checkpoint, buffer_send1, sizeof(buffer_send1), 0), sizeof(buffer_send1)); WARNING: line length of 104 exceeds 80 columns #648: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:295: + ASSERT_EQ(send(sockfd_checkpoint, buffer_send2, sizeof(buffer_send2), 0), sizeof(buffer_send2)); CHECK: Alignment should match open parenthesis #656: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:303: + DECLARE_LIBBPF_OPTS(bpf_test_run_opts, opts, + .ctx_in = &arg_checkpoint, WARNING: line length of 96 exceeds 80 columns #660: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:307: + struct test_restore_udp_socket_bpf *skel = test_restore_udp_socket_bpf__open_and_load(); WARNING: Missing a blank line after declarations #661: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:308: + struct test_restore_udp_socket_bpf *skel = test_restore_udp_socket_bpf__open_and_load(); + dump_socket_queue_fd = bpf_program__fd(skel->progs.dump_socket_queue); WARNING: line length of 84 exceeds 80 columns #662: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:309: + restore_socket_queue_fd = bpf_program__fd(skel->progs.restore_socket_queue); WARNING: line length of 84 exceeds 80 columns #664: FILE: tools/testing/selftests/crib/test_restore_udp_socket.c:311: + rb = ring_buffer__new(bpf_map__fd(skel->maps.rb), handle_event, NULL, NULL); WARNING: Improper SPDX comment style for 'tools/testing/selftests/crib/test_restore_udp_socket.h', please use '/*' instead #693: FILE: tools/testing/selftests/crib/test_restore_udp_socket.h:1: +// SPDX-License-Identifier: GPL-2.0 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #693: FILE: tools/testing/selftests/crib/test_restore_udp_socket.h:1: +// SPDX-License-Identifier: GPL-2.0 total: 0 errors, 105 warnings, 3 checks, 695 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 239d5cbf8126 ("selftests/crib: Add test for dumping/restoring UDP socket packets") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 105 warnings, 3 checks, 695 lines checked