WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 WARNING: externs should be avoided in .c files #53: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:22: +extern struct task_struct *bpf_task_from_vpid(pid_t vpid) __ksym; WARNING: line length of 83 exceeds 80 columns #56: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:25: +extern struct sock *bpf_sock_from_task_fd(struct task_struct *task, int fd) __ksym; WARNING: externs should be avoided in .c files #56: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:25: +extern struct sock *bpf_sock_from_task_fd(struct task_struct *task, int fd) __ksym; WARNING: externs should be avoided in .c files #57: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:26: +extern struct sock *bpf_sock_from_socket(struct socket *sock) __ksym; WARNING: externs should be avoided in .c files #60: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:29: +extern struct socket *bpf_socket_from_file(struct file *file) __ksym; WARNING: externs should be avoided in .c files #61: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:30: +extern struct sock_common *bpf_sock_common_from_sock(struct sock *sk) __ksym; WARNING: externs should be avoided in .c files #62: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:31: +extern struct tcp_sock *bpf_tcp_sock_from_sock(struct sock *sk) __ksym; WARNING: externs should be avoided in .c files #63: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:32: +extern struct udp_sock *bpf_udp_sock_from_sock(struct sock *sk) __ksym; WARNING: line length of 95 exceeds 80 columns #65: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:34: +extern int bpf_inet_src_addr_from_socket(struct socket *sock, struct sockaddr_in *addr) __ksym; WARNING: line length of 95 exceeds 80 columns #66: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:35: +extern int bpf_inet_dst_addr_from_socket(struct socket *sock, struct sockaddr_in *addr) __ksym; WARNING: line length of 97 exceeds 80 columns #67: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:36: +extern int bpf_inet6_src_addr_from_socket(struct socket *sock, struct sockaddr_in6 *addr) __ksym; WARNING: line length of 97 exceeds 80 columns #68: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:37: +extern int bpf_inet6_dst_addr_from_socket(struct socket *sock, struct sockaddr_in6 *addr) __ksym; WARNING: line length of 98 exceeds 80 columns #70: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:39: +extern int bpf_iter_task_file_new(struct bpf_iter_task_file *it, struct task_struct *task) __ksym; WARNING: line length of 82 exceeds 80 columns #71: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:40: +extern struct file *bpf_iter_task_file_next(struct bpf_iter_task_file *it) __ksym; WARNING: externs should be avoided in .c files #71: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:40: +extern struct file *bpf_iter_task_file_next(struct bpf_iter_task_file *it) __ksym; WARNING: Missing a blank line after declarations #81: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:50: + struct task_struct *task = bpf_task_from_vpid(arg->pid); + if (!task) { WARNING: Missing a blank line after declarations #87: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:56: + struct sock *sk = bpf_sock_from_task_fd(task, arg->sockfd); + if (!sk) { WARNING: line length of 88 exceeds 80 columns #92: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:61: + struct event_udp *e_udp = bpf_ringbuf_reserve(&rb, sizeof(struct event_udp), 0); WARNING: Missing a blank line after declarations #93: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:62: + struct event_udp *e_udp = bpf_ringbuf_reserve(&rb, sizeof(struct event_udp), 0); + if (!e_udp) { WARNING: Missing a blank line after declarations #122: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:91: + struct task_struct *task = bpf_task_from_vpid(arg->pid); + if (!task) { WARNING: Missing a blank line after declarations #128: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:97: + struct sock *sk = bpf_sock_from_task_fd(task, arg->sockfd); + if (!sk) { WARNING: line length of 88 exceeds 80 columns #133: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:102: + struct event_tcp *e_tcp = bpf_ringbuf_reserve(&rb, sizeof(struct event_tcp), 0); WARNING: Missing a blank line after declarations #134: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:103: + struct event_tcp *e_tcp = bpf_ringbuf_reserve(&rb, sizeof(struct event_tcp), 0); + if (!e_tcp) { WARNING: line length of 105 exceeds 80 columns #163: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:132: + struct event_inet_addr *e_src_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet_addr), 0); WARNING: Missing a blank line after declarations #164: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:133: + struct event_inet_addr *e_src_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet_addr), 0); + if (!e_src_addr) { WARNING: braces {} are not necessary for single statement blocks #164: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:133: + if (!e_src_addr) { + return -2; + } WARNING: line length of 105 exceeds 80 columns #168: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:137: + struct event_inet_addr *e_dst_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet_addr), 0); WARNING: Missing a blank line after declarations #169: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:138: + struct event_inet_addr *e_dst_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet_addr), 0); + if (!e_dst_addr) { WARNING: line length of 107 exceeds 80 columns #193: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:162: + struct event_inet6_addr *e_src_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet6_addr), 0); WARNING: Missing a blank line after declarations #194: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:163: + struct event_inet6_addr *e_src_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet6_addr), 0); + if (!e_src_addr) { WARNING: braces {} are not necessary for single statement blocks #194: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:163: + if (!e_src_addr) { + return -2; + } WARNING: line length of 107 exceeds 80 columns #198: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:167: + struct event_inet6_addr *e_dst_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet6_addr), 0); WARNING: Missing a blank line after declarations #199: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:168: + struct event_inet6_addr *e_dst_addr = bpf_ringbuf_reserve(&rb, sizeof(struct event_inet6_addr), 0); + if (!e_dst_addr) { WARNING: Missing a blank line after declarations #227: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:196: + struct task_struct *task = bpf_task_from_vpid(arg->pid); + if (!task) { WARNING: Missing a blank line after declarations #238: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:207: + struct socket *sock = bpf_socket_from_file(cur_file); + if (!sock) { WARNING: braces {} are not necessary for single statement blocks #238: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:207: + if (!sock) { + continue; + } WARNING: line length of 105 exceeds 80 columns #242: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:211: + struct event_socket *e_socket = bpf_ringbuf_reserve(&rb, sizeof(struct event_socket), 0); WARNING: Missing a blank line after declarations #243: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:212: + struct event_socket *e_socket = bpf_ringbuf_reserve(&rb, sizeof(struct event_socket), 0); + if (!e_socket) { WARNING: braces {} are not necessary for single statement blocks #273: FILE: tools/testing/selftests/crib/test_dump_all_socket.bpf.c:242: + if (err) { + goto error_buf; + } WARNING: line length of 103 exceeds 80 columns #368: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:79: +static struct socket_dump_info *find_dump_info_by_sockfd(struct socket_dump_info *all_info, int sockfd) WARNING: Missing a blank line after declarations #371: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:82: + struct socket_dump_info *info; + for (int i = 0; i < 4; i++) { WARNING: line length of 87 exceeds 80 columns #379: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:90: +static int handle_tcp_event(struct socket_dump_info *all_info, struct event_tcp *e_tcp) WARNING: line length of 94 exceeds 80 columns #381: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:92: + struct socket_dump_info *info = find_dump_info_by_sockfd(all_info, e_tcp->hdr.sockfd); WARNING: Missing a blank line after declarations #382: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:93: + struct socket_dump_info *info = find_dump_info_by_sockfd(all_info, e_tcp->hdr.sockfd); + info->tcp.snd_wl1 = e_tcp->snd_wl1; WARNING: line length of 87 exceeds 80 columns #392: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:103: +static int handle_udp_event(struct socket_dump_info *all_info, struct event_udp *e_udp) WARNING: line length of 94 exceeds 80 columns #394: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:105: + struct socket_dump_info *info = find_dump_info_by_sockfd(all_info, e_udp->hdr.sockfd); WARNING: Missing a blank line after declarations #395: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:106: + struct socket_dump_info *info = find_dump_info_by_sockfd(all_info, e_udp->hdr.sockfd); + info->udp.udp_flags = e_udp->udp_flags; WARNING: line length of 105 exceeds 80 columns #401: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:112: +static int handle_inet_addr_event(struct socket_dump_info *all_info, struct event_inet_addr *e_inet_addr) WARNING: Missing a blank line after declarations #404: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:115: + struct socket_dump_info *info = &all_info[socket_count - 1]; + if (e_inet_addr->hdr.subtype == EVENT_SUBTYPE_ADDR_SRC) WARNING: line length of 89 exceeds 80 columns #405: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:116: + memcpy(&info->src_addr4, &e_inet_addr->addr, sizeof(struct sockaddr_in)); WARNING: line length of 89 exceeds 80 columns #407: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:118: + memcpy(&info->dst_addr4, &e_inet_addr->addr, sizeof(struct sockaddr_in)); WARNING: line length of 108 exceeds 80 columns #411: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:122: +static int handle_inet6_addr_event(struct socket_dump_info *all_info, struct event_inet6_addr *e_inet6_addr) WARNING: Missing a blank line after declarations #414: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:125: + struct socket_dump_info *info = &all_info[socket_count - 1]; + if (e_inet6_addr->hdr.subtype == EVENT_SUBTYPE_ADDR_SRC) WARNING: line length of 91 exceeds 80 columns #415: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:126: + memcpy(&info->src_addr6, &e_inet6_addr->addr, sizeof(struct sockaddr_in6)); WARNING: line length of 91 exceeds 80 columns #417: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:128: + memcpy(&info->dst_addr6, &e_inet6_addr->addr, sizeof(struct sockaddr_in6)); WARNING: line length of 96 exceeds 80 columns #421: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:132: +static int handle_socket_event(struct socket_dump_info *all_info, struct event_socket *e_socket) CHECK: Alignment should match open parenthesis #429: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:140: + DECLARE_LIBBPF_OPTS(bpf_test_run_opts, tattrs, + .ctx_in = &arg, WARNING: Missing a blank line after declarations #434: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:145: + struct socket_dump_info *info = &all_info[socket_count]; + info->sockfd = e_socket->hdr.sockfd; WARNING: Missing a blank line after declarations #440: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:151: + int err = 0; + if (e_socket->protocol == IPPROTO_TCP) WARNING: line length of 81 exceeds 80 columns #467: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:178: + handle_inet_addr_event(all_info, (struct event_inet_addr *)data); WARNING: line length of 83 exceeds 80 columns #470: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:181: + handle_inet6_addr_event(all_info, (struct event_inet6_addr *)data); WARNING: Missing a blank line after declarations #483: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:194: + const int enable = 1; + if (info->family != AF_INET || info->type != SOCK_STREAM || CHECK: Alignment should match open parenthesis #484: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:195: + if (info->family != AF_INET || info->type != SOCK_STREAM || + info->protocol != IPPROTO_TCP) WARNING: line length of 91 exceeds 80 columns #487: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:198: + if (info->dst_addr4.sin_family != AF_INET || info->src_addr4.sin_family != AF_INET) WARNING: line length of 106 exceeds 80 columns #490: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:201: + if (info->sockfd == tcp_client_fd && (info->dst_addr4.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || CHECK: Alignment should match open parenthesis #491: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:202: + if (info->sockfd == tcp_client_fd && (info->dst_addr4.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || + info->dst_addr4.sin_port != htons(5555))) WARNING: line length of 101 exceeds 80 columns #494: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:205: + if (info->sockfd == tcp_server_fd && (info->src_addr4.sin_addr.s_addr != htonl(INADDR_ANY) || CHECK: Alignment should match open parenthesis #495: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:206: + if (info->sockfd == tcp_server_fd && (info->src_addr4.sin_addr.s_addr != htonl(INADDR_ANY) || + info->src_addr4.sin_port != htons(5555))) WARNING: line length of 106 exceeds 80 columns #498: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:209: + if (info->sockfd == tcp_accept_fd && (info->src_addr4.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || CHECK: Alignment should match open parenthesis #499: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:210: + if (info->sockfd == tcp_accept_fd && (info->src_addr4.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || + info->dst_addr4.sin_addr.s_addr != htonl(INADDR_LOOPBACK) || WARNING: line length of 95 exceeds 80 columns #504: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:215: + if (setsockopt(info->sockfd, IPPROTO_TCP, TCP_REPAIR, &enable, sizeof(enable))) WARNING: line length of 92 exceeds 80 columns #509: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:220: + if (getsockopt(info->sockfd, IPPROTO_TCP, TCP_REPAIR_WINDOW, &opt, &optlen)) WARNING: Missing a blank line after declarations #509: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:220: + socklen_t optlen = sizeof(opt); + if (getsockopt(info->sockfd, IPPROTO_TCP, TCP_REPAIR_WINDOW, &opt, &optlen)) WARNING: line length of 91 exceeds 80 columns #512: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:223: + if (opt.snd_wl1 != info->tcp.snd_wl1 || opt.snd_wnd != info->tcp.snd_wnd || WARNING: line length of 101 exceeds 80 columns #513: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:224: + opt.max_window != info->tcp.max_window || opt.rcv_wnd != info->tcp.rcv_wnd || CHECK: Alignment should match open parenthesis #513: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:224: + if (opt.snd_wl1 != info->tcp.snd_wl1 || opt.snd_wnd != info->tcp.snd_wnd || + opt.max_window != info->tcp.max_window || opt.rcv_wnd != info->tcp.rcv_wnd || WARNING: line length of 99 exceeds 80 columns #518: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:229: + if (setsockopt(info->sockfd, IPPROTO_TCP, TCP_REPAIR_QUEUE, &queue, sizeof(queue))) WARNING: Missing a blank line after declarations #518: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:229: + int queue = TCP_SEND_QUEUE; + if (setsockopt(info->sockfd, IPPROTO_TCP, TCP_REPAIR_QUEUE, &queue, sizeof(queue))) WARNING: Missing a blank line after declarations #522: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:233: + unsigned int write_seq; + optlen = sizeof(write_seq); WARNING: line length of 94 exceeds 80 columns #523: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:234: + if (getsockopt(info->sockfd, IPPROTO_TCP, TCP_QUEUE_SEQ, &write_seq, &optlen)) WARNING: line length of 99 exceeds 80 columns #530: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:241: + if (setsockopt(info->sockfd, IPPROTO_TCP, TCP_REPAIR_QUEUE, &queue, sizeof(queue))) WARNING: line length of 92 exceeds 80 columns #534: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:245: + if (getsockopt(info->sockfd, IPPROTO_TCP, TCP_QUEUE_SEQ, &rcv_nxt, &optlen)) WARNING: Missing a blank line after declarations #534: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:245: + unsigned int rcv_nxt; + if (getsockopt(info->sockfd, IPPROTO_TCP, TCP_QUEUE_SEQ, &rcv_nxt, &optlen)) CHECK: Alignment should match open parenthesis #546: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:257: + if (info->family != AF_INET6 || info->type != SOCK_DGRAM || + info->protocol != IPPROTO_UDP) WARNING: line length of 98 exceeds 80 columns #549: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:260: + if (info->dst_addr6.sin6_family != AF_INET6 || info->dst_addr6.sin6_port != htons(7777) || WARNING: line length of 100 exceeds 80 columns #550: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:261: + memcmp(&info->dst_addr6.sin6_addr, &in6addr_loopback, sizeof(struct in6_addr)) != 0) CHECK: Alignment should match open parenthesis #550: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:261: + if (info->dst_addr6.sin6_family != AF_INET6 || info->dst_addr6.sin6_port != htons(7777) || + memcmp(&info->dst_addr6.sin6_addr, &in6addr_loopback, sizeof(struct in6_addr)) != 0) WARNING: Missing a blank line after declarations #559: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:270: + struct socket_dump_info *info; + for (int i = 0; i < 4; i++) { CHECK: Blank lines aren't necessary before a close brace '}' #573: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:284: + + } CHECK: Alignment should match open parenthesis #585: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:296: + DECLARE_LIBBPF_OPTS(bpf_test_run_opts, opts, + .ctx_in = &args, WARNING: line length of 99 exceeds 80 columns #599: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:310: + ASSERT_EQ(setsockopt(tcp_server_fd, SOL_SOCKET, SO_REUSEADDR, &enable, sizeof(enable)), 0); WARNING: Missing a blank line after declarations #599: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:310: + const int enable = 1; + ASSERT_EQ(setsockopt(tcp_server_fd, SOL_SOCKET, SO_REUSEADDR, &enable, sizeof(enable)), 0); WARNING: Missing a blank line after declarations #603: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:314: + struct sockaddr_in6 udp_dst_addr; + memset(&tcp_src_addr, 0, sizeof(struct sockaddr_in)); WARNING: line length of 104 exceeds 80 columns #619: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:330: + ASSERT_EQ(bind(tcp_server_fd, (struct sockaddr *)&tcp_src_addr, sizeof(struct sockaddr_in)), 0); WARNING: line length of 107 exceeds 80 columns #622: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:333: + ASSERT_EQ(connect(tcp_client_fd, (struct sockaddr *)&tcp_dst_addr, sizeof(struct sockaddr_in)), 0); WARNING: Missing a blank line after declarations #628: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:339: + char buf[20]; + memset(buf, 'a', 20); WARNING: line length of 108 exceeds 80 columns #631: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:342: + ASSERT_EQ(connect(udp_client_fd, (struct sockaddr *)&udp_dst_addr, sizeof(struct sockaddr_in6)), 0); WARNING: line length of 90 exceeds 80 columns #633: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:344: + struct test_dump_all_socket_bpf *skel = test_dump_all_socket_bpf__open_and_load(); WARNING: Missing a blank line after declarations #634: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:345: + struct test_dump_all_socket_bpf *skel = test_dump_all_socket_bpf__open_and_load(); + ASSERT_NE(skel, NULL); WARNING: line length of 115 exceeds 80 columns #645: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:356: + struct socket_dump_info *all_info = (struct socket_dump_info *)malloc(sizeof(struct socket_dump_info) * 4); WARNING: line length of 108 exceeds 80 columns #647: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:358: + struct ring_buffer *rb = ring_buffer__new(bpf_map__fd(skel->maps.rb), handle_event, all_info, NULL); WARNING: Missing a blank line after declarations #648: FILE: tools/testing/selftests/crib/test_dump_all_socket.c:359: + struct ring_buffer *rb = ring_buffer__new(bpf_map__fd(skel->maps.rb), handle_event, all_info, NULL); + ASSERT_NE(rb, NULL); WARNING: Improper SPDX comment style for 'tools/testing/selftests/crib/test_dump_all_socket.h', please use '/*' instead #671: FILE: tools/testing/selftests/crib/test_dump_all_socket.h:1: +// SPDX-License-Identifier: GPL-2.0 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #671: FILE: tools/testing/selftests/crib/test_dump_all_socket.h:1: +// SPDX-License-Identifier: GPL-2.0 total: 0 errors, 95 warnings, 10 checks, 696 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 33d5da765b68 ("selftests/crib: Add test for getting all socket information of the process") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 95 warnings, 10 checks, 696 lines checked