WARNING: please write a help paragraph that fully describes the config symbol #64: FILE: drivers/net/ethernet/mediatek/Kconfig:10: +config NET_AIROHA + tristate "Airoha SoC Gigabit Ethernet support" + depends on NET_DSA || !NET_DSA + select PAGE_POOL + select PAGE_POOL_STATS + help + This driver supports the gigabit ethernet MACs in the + Airoha SoC family. + ERROR: space prohibited before that close parenthesis ')' #229: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:139: + GENMASK(4 + (((_n) % 4) << 3), (((_n) % 4 ) << 3)) ERROR: space prohibited before that close parenthesis ')' #237: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:147: + GENMASK(4 + (((_n) % 4) << 3), (((_n) % 4 ) << 3)) WARNING: line length of 81 exceeds 80 columns #676: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:586: +#define QDMA_DESC_DROP_MASK BIT(30) /* tx: drop pkt - rx: overflow */ WARNING: line length of 92 exceeds 80 columns #696: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:606: +#define QDMA_ETH_TXMSG_METER_MASK GENMASK(30, 24) /* 0x7f means do not apply meters */ WARNING: line length of 85 exceeds 80 columns #702: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:612: +#define QDMA_ETH_TXMSG_ACNT_G1_MASK GENMASK(10, 6) /* 0x1f means do not count */ WARNING: line length of 85 exceeds 80 columns #703: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:613: +#define QDMA_ETH_TXMSG_ACNT_G0_MASK GENMASK(5, 0) /* 0x3f means do not count */ CHECK: spinlock_t definition without comment #818: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:728: + spinlock_t lock; CHECK: spinlock_t definition without comment #860: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:770: + spinlock_t irq_lock; WARNING: line length of 86 exceeds 80 columns #1116: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:1026: + airoha_fe_wr(eth, REG_FE_VIP_PATN(20), 0x893a); /* ETH->ETH_P_1905 (0x893a) */ WARNING: line length of 81 exceeds 80 columns #1289: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:1199: + USEC_PER_MSEC, 5 * USEC_PER_MSEC, WARNING: line length of 81 exceeds 80 columns #1938: FILE: drivers/net/ethernet/mediatek/airoha_eth.c:1848: + FIELD_PREP(GLB_FAST_TICK_MASK, 25)); /* fast-tick 25us */ total: 2 errors, 8 warnings, 2 checks, 2750 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0d53aecee839 ("net: airoha: Introduce ethernet support for EN7581 SoC") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.