WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #65: new file mode 100644 CHECK: Prefer kernel type 'u64' over 'uint64_t' #122: FILE: drivers/ptp/ptp_vmclock.c:53: +static inline uint64_t mul_u64_u64_shr_add_u64(uint64_t *res_hi, uint64_t delta, CHECK: Prefer kernel type 'u64' over 'uint64_t' #123: FILE: drivers/ptp/ptp_vmclock.c:54: + uint64_t period, uint8_t shift, CHECK: Prefer kernel type 'u64' over 'uint64_t' #141: FILE: drivers/ptp/ptp_vmclock.c:72: + uint64_t cycle, delta, seq, frac_sec; WARNING: memory barrier without comment #154: FILE: drivers/ptp/ptp_vmclock.c:85: + virt_rmb(); CHECK: braces {} should be used on all arms of this statement #173: FILE: drivers/ptp/ptp_vmclock.c:104: + if (sts) { [...] + } else [...] CHECK: Unbalanced braces around else statement #181: FILE: drivers/ptp/ptp_vmclock.c:112: + } else WARNING: line length of 84 exceeds 80 columns #187: FILE: drivers/ptp/ptp_vmclock.c:118: + st->clk->counter_period_frac_sec, WARNING: line length of 81 exceeds 80 columns #188: FILE: drivers/ptp/ptp_vmclock.c:119: + st->clk->counter_period_shift, WARNING: memory barrier without comment #193: FILE: drivers/ptp/ptp_vmclock.c:124: + virt_rmb(); WARNING: line length of 87 exceeds 80 columns #223: FILE: drivers/ptp/ptp_vmclock.c:154: + struct system_counterval_t *system_counter, WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #227: FILE: drivers/ptp/ptp_vmclock.c:158: + unsigned pvti_ver; WARNING: line length of 87 exceeds 80 columns #240: FILE: drivers/ptp/ptp_vmclock.c:171: + system_counter->cycles); CHECK: Please don't use multiple blank lines #282: FILE: drivers/ptp/ptp_vmclock.c:213: + + WARNING: Missing a blank line after declarations #298: FILE: drivers/ptp/ptp_vmclock.c:229: + struct system_time_snapshot systime_snapshot; + ktime_get_snapshot(&systime_snapshot); WARNING: line length of 84 exceeds 80 columns #303: FILE: drivers/ptp/ptp_vmclock.c:234: + ret = get_device_system_crosststamp(ptp_vmclock_get_time_fn, CHECK: Alignment should match open parenthesis #326: FILE: drivers/ptp/ptp_vmclock.c:257: +static int ptp_vmclock_settime(struct ptp_clock_info *ptp, + const struct timespec64 *ts) WARNING: line length of 81 exceeds 80 columns #331: FILE: drivers/ptp/ptp_vmclock.c:262: +static int ptp_vmclock_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts) WARNING: line length of 82 exceeds 80 columns #339: FILE: drivers/ptp/ptp_vmclock.c:270: +static int ptp_vmclock_gettimex(struct ptp_clock_info *ptp, struct timespec64 *ts, CHECK: Alignment should match open parenthesis #349: FILE: drivers/ptp/ptp_vmclock.c:280: +static int ptp_vmclock_enable(struct ptp_clock_info *ptp, + struct ptp_clock_request *rq, int on) CHECK: spaces preferred around that '|' (ctx:VxV) #374: FILE: drivers/ptp/ptp_vmclock.c:305: + if ((vma->vm_flags & (VM_READ|VM_WRITE)) != VM_READ) ^ ERROR: code indent should use tabs where possible #380: FILE: drivers/ptp/ptp_vmclock.c:311: + if (io_remap_pfn_range(vma, vma->vm_start,$ WARNING: please, no spaces at the start of a line #380: FILE: drivers/ptp/ptp_vmclock.c:311: + if (io_remap_pfn_range(vma, vma->vm_start,$ ERROR: code indent should use tabs where possible #382: FILE: drivers/ptp/ptp_vmclock.c:313: + vma->vm_page_prot))$ WARNING: please, no spaces at the start of a line #382: FILE: drivers/ptp/ptp_vmclock.c:313: + vma->vm_page_prot))$ ERROR: code indent should use tabs where possible #383: FILE: drivers/ptp/ptp_vmclock.c:314: + return -EAGAIN;$ WARNING: please, no spaces at the start of a line #383: FILE: drivers/ptp/ptp_vmclock.c:314: + return -EAGAIN;$ ERROR: code indent should use tabs where possible #385: FILE: drivers/ptp/ptp_vmclock.c:316: + return 0;$ WARNING: please, no spaces at the start of a line #385: FILE: drivers/ptp/ptp_vmclock.c:316: + return 0;$ CHECK: Prefer kernel type 's32' over 'int32_t' #395: FILE: drivers/ptp/ptp_vmclock.c:326: + int32_t seq; WARNING: memory barrier without comment #406: FILE: drivers/ptp/ptp_vmclock.c:337: + virt_rmb(); WARNING: memory barrier without comment #411: FILE: drivers/ptp/ptp_vmclock.c:342: + virt_rmb(); ERROR: code indent should use tabs where possible #424: FILE: drivers/ptp/ptp_vmclock.c:355: + .mmap = vmclock_miscdev_mmap,$ WARNING: please, no spaces at the start of a line #424: FILE: drivers/ptp/ptp_vmclock.c:355: + .mmap = vmclock_miscdev_mmap,$ ERROR: code indent should use tabs where possible #425: FILE: drivers/ptp/ptp_vmclock.c:356: + .read = vmclock_miscdev_read,$ WARNING: please, no spaces at the start of a line #425: FILE: drivers/ptp/ptp_vmclock.c:356: + .read = vmclock_miscdev_read,$ WARNING: space prohibited between function name and open parenthesis '(' #479: FILE: drivers/ptp/ptp_vmclock.c:410: + st = devm_kzalloc(dev, sizeof (*st), GFP_KERNEL); ERROR: code indent should use tabs where possible #525: FILE: drivers/ptp/ptp_vmclock.c:456: + ret = devm_add_action_or_reset(&pdev->dev, vmclock_put_idx, st);$ WARNING: please, no spaces at the start of a line #525: FILE: drivers/ptp/ptp_vmclock.c:456: + ret = devm_add_action_or_reset(&pdev->dev, vmclock_put_idx, st);$ WARNING: line length of 82 exceeds 80 columns #529: FILE: drivers/ptp/ptp_vmclock.c:460: + st->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "vmclock%d", st->index); WARNING: line length of 92 exceeds 80 columns #549: FILE: drivers/ptp/ptp_vmclock.c:480: + strncpy(st->ptp_clock_info.name, st->name, sizeof(st->ptp_clock_info.name)); WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #549: FILE: drivers/ptp/ptp_vmclock.c:480: + strncpy(st->ptp_clock_info.name, st->name, sizeof(st->ptp_clock_info.name)); WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #585: FILE: drivers/ptp/ptp_vmclock.c:516: +MODULE_LICENSE("GPL v2"); WARNING: line length of 82 exceeds 80 columns #592: FILE: include/uapi/linux/vmclock.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */ total: 7 errors, 27 warnings, 10 checks, 680 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit a773976580e3 ("ptp: Add vDSO-style vmclock support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.