========== checkpatch - FAILED ERROR: trailing statements should be on next line #45: FILE: drivers/fwctl/main.c:24: +DEFINE_FREE(kvfree_errptr, void *, if (!IS_ERR_OR_NULL(_T)) kvfree(_T)); CHECK: Lines should not end with a '(' #73: FILE: drivers/fwctl/main.c:102: + dev_warn( CHECK: Lines should not end with a '(' #92: FILE: drivers/fwctl/main.c:121: + void *outbuf __free(kvfree_errptr) = fwctl->ops->fw_rpc( WARNING: line length of 91 exceeds 80 columns #176: FILE: include/uapi/fwctl/fwctl.h:91: + * @FWCTL_RPC_DEBUG_WRITE: Writable access to lockdown compatible debug information CHECK: Please use a blank line after function/struct/union/enum declarations #219: FILE: include/uapi/fwctl/fwctl.h:134: +}; +#define FWCTL_RPC _IO(FWCTL_TYPE, FWCTL_CMD_RPC) total: 1 errors, 1 warnings, 3 checks, 180 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 5ed44aee42a5 ("fwctl: FWCTL_RPC to execute a Remote Procedure Call to device firmware") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.