CHECK: Macro argument 'mcdev' may be better as '(mcdev)' to avoid precedence issues
#119: FILE: drivers/fwctl/mlx5/main.c:11:
+#define mlx5ctl_err(mcdev, format, ...) \
+	dev_err(&mcdev->fwctl.dev, format, ##__VA_ARGS__)

CHECK: Macro argument 'mcdev' may be better as '(mcdev)' to avoid precedence issues
#122: FILE: drivers/fwctl/mlx5/main.c:14:
+#define mlx5ctl_dbg(mcdev, format, ...)                             \
+	dev_dbg(&mcdev->fwctl.dev, "PID %u: " format, current->pid, \
+		##__VA_ARGS__)

CHECK: Please use a blank line after function/struct/union/enum declarations
#136: FILE: drivers/fwctl/mlx5/main.c:28:
+};
+DEFINE_FREE(mlx5ctl, struct mlx5ctl_dev *, if (_T) fwctl_put(&_T->fwctl));

ERROR: trailing statements should be on next line
#136: FILE: drivers/fwctl/mlx5/main.c:28:
+DEFINE_FREE(mlx5ctl, struct mlx5ctl_dev *, if (_T) fwctl_put(&_T->fwctl));

CHECK: multiple assignments should be avoided
#363: FILE: drivers/fwctl/mlx5/main.c:255:
+		rpc_out = rpc_alloc = kvzalloc(*out_len, GFP_KERNEL);

CHECK: Lines should not end with a '('
#404: FILE: drivers/fwctl/mlx5/main.c:296:
+	struct mlx5ctl_dev *mcdev __free(mlx5ctl) = fwctl_alloc_device(

total: 1 errors, 0 warnings, 5 checks, 419 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 4ee3d55615f0 ("fwctl/mlx5: Support for communicating with mlx5 fw") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.