WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

WARNING: line length of 100 exceeds 80 columns
#129: FILE: tools/testing/selftests/ovpn/float-test.sh:25:
+			ip link add veth${p} netns peer0 type veth peer name veth${p} netns peer${p}

WARNING: line length of 91 exceeds 80 columns
#147: FILE: tools/testing/selftests/ovpn/float-test.sh:43:
+			ip netns exec peer0 $OVPN_CLI new_multi_peer tun0 1 $UDP_PEERS_FILE

WARNING: line length of 120 exceeds 80 columns
#150: FILE: tools/testing/selftests/ovpn/float-test.sh:46:
+			#	ip netns exec peer0 $OVPN_CLI new_peer tun0 ${p} ${p} 10.10.${p}.2 1 5.5.5.$((${p} + 1))

WARNING: line length of 101 exceeds 80 columns
#151: FILE: tools/testing/selftests/ovpn/float-test.sh:47:
+				ip netns exec peer0 $OVPN_CLI new_key tun0 ${p} 1 0 $ALG 0 data64.key

WARNING: line length of 103 exceeds 80 columns
#154: FILE: tools/testing/selftests/ovpn/float-test.sh:50:
+			ip netns exec peer${1} $OVPN_CLI new_peer tun${1} 1 ${1} 10.10.${1}.1 1 5.5.5.1

WARNING: line length of 99 exceeds 80 columns
#155: FILE: tools/testing/selftests/ovpn/float-test.sh:51:
+			ip netns exec peer${1} $OVPN_CLI new_key tun${1} ${1} 1 0 $ALG 1 data64.key

WARNING: line length of 90 exceeds 80 columns
#159: FILE: tools/testing/selftests/ovpn/float-test.sh:55:
+			(ip netns exec peer$1 $OVPN_CLI listen tun0 1 $TCP_PEERS_FILE && {

WARNING: line length of 109 exceeds 80 columns
#161: FILE: tools/testing/selftests/ovpn/float-test.sh:57:
+					ip netns exec peer0 $OVPN_CLI new_key tun0 ${p} 1 0 $ALG 0 data64.key

WARNING: line length of 100 exceeds 80 columns
#166: FILE: tools/testing/selftests/ovpn/float-test.sh:62:
+			ip netns exec peer${1} $OVPN_CLI connect tun${1} ${1} 10.10.${1}.1 1 5.5.5.1

WARNING: line length of 99 exceeds 80 columns
#167: FILE: tools/testing/selftests/ovpn/float-test.sh:63:
+			ip netns exec peer${1} $OVPN_CLI new_key tun${1} ${1} 1 0 $ALG 1 data64.key

WARNING: line length of 88 exceeds 80 columns
#177: FILE: tools/testing/selftests/ovpn/float-test.sh:73:
+		ip netns exec peer${p} ${OVPN_CLI} del_iface tun${p} 2>/dev/null || true

WARNING: line length of 100 exceeds 80 columns
#248: FILE: tools/testing/selftests/ovpn/netns-test.sh:25:
+			ip link add veth${p} netns peer0 type veth peer name veth${p} netns peer${p}

WARNING: line length of 91 exceeds 80 columns
#266: FILE: tools/testing/selftests/ovpn/netns-test.sh:43:
+			ip netns exec peer0 $OVPN_CLI new_multi_peer tun0 1 $UDP_PEERS_FILE

WARNING: line length of 120 exceeds 80 columns
#269: FILE: tools/testing/selftests/ovpn/netns-test.sh:46:
+			#	ip netns exec peer0 $OVPN_CLI new_peer tun0 ${p} ${p} 10.10.${p}.2 1 5.5.5.$((${p} + 1))

WARNING: line length of 101 exceeds 80 columns
#270: FILE: tools/testing/selftests/ovpn/netns-test.sh:47:
+				ip netns exec peer0 $OVPN_CLI new_key tun0 ${p} 1 0 $ALG 0 data64.key

WARNING: line length of 103 exceeds 80 columns
#273: FILE: tools/testing/selftests/ovpn/netns-test.sh:50:
+			ip netns exec peer${1} $OVPN_CLI new_peer tun${1} 1 ${1} 10.10.${1}.1 1 5.5.5.1

WARNING: line length of 99 exceeds 80 columns
#274: FILE: tools/testing/selftests/ovpn/netns-test.sh:51:
+			ip netns exec peer${1} $OVPN_CLI new_key tun${1} ${1} 1 0 $ALG 1 data64.key

WARNING: line length of 89 exceeds 80 columns
#278: FILE: tools/testing/selftests/ovpn/netns-test.sh:55:
+			(ip netns exec peer0 $OVPN_CLI listen tun0 1 $TCP_PEERS_FILE && {

WARNING: line length of 109 exceeds 80 columns
#280: FILE: tools/testing/selftests/ovpn/netns-test.sh:57:
+					ip netns exec peer0 $OVPN_CLI new_key tun0 ${p} 1 0 $ALG 0 data64.key

WARNING: line length of 111 exceeds 80 columns
#285: FILE: tools/testing/selftests/ovpn/netns-test.sh:62:
+			ip netns exec peer${1} $OVPN_CLI connect tun${1} ${1} 10.10.${1}.1 1 5.5.5.1 data64.key

WARNING: line length of 86 exceeds 80 columns
#295: FILE: tools/testing/selftests/ovpn/netns-test.sh:72:
+		ip netns exec peer${p} $OVPN_CLI del_iface tun${p} 2>/dev/null || true

WARNING: line length of 83 exceeds 80 columns
#338: FILE: tools/testing/selftests/ovpn/netns-test.sh:115:
+	ip netns exec peer${p} $OVPN_CLI new_key tun${p} ${p} 2 1 $ALG 1 data64.key

WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
#574: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:213:
+static int ovpn_nl_cb_error(struct sockaddr_nl (*nla)__attribute__((unused)),

WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
#609: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:248:
+static int ovpn_nl_cb_finish(struct nl_msg (*msg)__attribute__((unused)),

WARNING: Missing a blank line after declarations
#816: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:455:
+	int opt = 1;
+	ret = setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt));

WARNING: line length of 82 exceeds 80 columns
#830: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:469:
+		if (setsockopt(s, IPPROTO_IPV6, IPV6_V6ONLY, &opt, sizeof(opt))) {

WARNING: line length of 86 exceeds 80 columns
#967: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:606:
+			fprintf(stderr, "Invalid family for remote socket address\n");

WARNING: line length of 87 exceeds 80 columns
#970: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:609:
+		NLA_PUT(ctx->nl_msg, OVPN_A_PEER_SOCKADDR_REMOTE, alen, &ovpn->remote);

CHECK: Please don't use multiple blank lines
#973: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:612:
+
+

WARNING: line length of 83 exceeds 80 columns
#980: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:619:
+		NLA_PUT(ctx->nl_msg, OVPN_A_PEER_VPN_IPV6, sizeof(struct in6_addr),

WARNING: line length of 83 exceeds 80 columns
#1064: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:703:
+		inet_ntop(AF_INET, nla_data(attrs_peer[OVPN_A_PEER_VPN_IPV4]), buf,

WARNING: Missing a blank line after declarations
#1064: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:703:
+		char buf[INET_ADDRSTRLEN];
+		inet_ntop(AF_INET, nla_data(attrs_peer[OVPN_A_PEER_VPN_IPV4]), buf,

WARNING: line length of 84 exceeds 80 columns
#1071: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:710:
+		inet_ntop(AF_INET6, nla_data(attrs_peer[OVPN_A_PEER_VPN_IPV6]), buf,

WARNING: Missing a blank line after declarations
#1071: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:710:
+		char buf[INET6_ADDRSTRLEN];
+		inet_ntop(AF_INET6, nla_data(attrs_peer[OVPN_A_PEER_VPN_IPV6]), buf,

WARNING: line length of 85 exceeds 80 columns
#1092: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:731:
+					  nla_data(attrs_peer[OVPN_A_PEER_LOCAL_IP]),

WARNING: line length of 87 exceeds 80 columns
#1098: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:737:
+			fprintf(stderr, "\tRemote: %s:%u\n", buf, ntohs(in->sin_port));

WARNING: line length of 85 exceeds 80 columns
#1104: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:743:
+					  nla_data(attrs_peer[OVPN_A_PEER_LOCAL_IP]),

WARNING: line length of 82 exceeds 80 columns
#1111: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:750:
+				ntohs(in6->sin6_port), ntohl(in6->sin6_scope_id));

WARNING: line length of 81 exceeds 80 columns
#1117: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:756:
+			nla_get_u32(attrs_peer[OVPN_A_PEER_KEEPALIVE_INTERVAL]));

WARNING: line length of 85 exceeds 80 columns
#1357: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:996:
+			    grp->group, nla_len(tb_mcgrp[CTRL_ATTR_MCAST_GRP_NAME])))

WARNING: Block comments use * on subsequent lines
#1420: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1059:
+		/*if (!attrs[OVPN_A_DEL_PEER_REASON]) {
+			fprintf(stderr, "no reason in DEL_PEER message\n");

WARNING: line length of 123 exceeds 80 columns
#1544: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1183:
+	fprintf(stderr, "* connect <peer_id> <raddr> <rport> <vpnaddr>: start connecting peer of TCP-based VPN session\n");

WARNING: line length of 101 exceeds 80 columns
#1550: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1189:
+	fprintf(stderr, "* listen <lport> <peers_file>: listen for incoming peer TCP connections\n");

WARNING: line length of 91 exceeds 80 columns
#1552: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1191:
+	fprintf(stderr, "\tpeers_file: file containing one peer per line: Line format:\n");

WARNING: line length of 98 exceeds 80 columns
#1555: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1194:
+	fprintf(stderr, "* new_peer <lport> <peer-id> <raddr> <rport> <vpnaddr>: add new peer\n");

WARNING: line length of 93 exceeds 80 columns
#1556: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1195:
+	fprintf(stderr, "\tpeer-id: peer ID to be used in data packets to/from this peer\n");

WARNING: line length of 103 exceeds 80 columns
#1562: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1201:
+	fprintf(stderr, "* new_multi_peer <lport> <file>: add multiple peers as listed in the file\n");

WARNING: line length of 90 exceeds 80 columns
#1564: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1203:
+	fprintf(stderr, "\tfile: text file containing one peer per line. Line format:\n");

WARNING: line length of 85 exceeds 80 columns
#1580: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1219:
+	fprintf(stderr, "\tpeer-id: peer ID of the peer to configure the key for\n");

WARNING: line length of 82 exceeds 80 columns
#1587: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1226:
+	fprintf(stderr, "* del_key <peer-id>: erase existing data channel key\n");

WARNING: line length of 88 exceeds 80 columns
#1590: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1229:
+	fprintf(stderr, "* swap_keys <peer-id>: swap primary and seconday key slots\n");

WARNING: line length of 91 exceeds 80 columns
#1593: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1232:
+	fprintf(stderr, "* listen_mcast: listen to ovpn-dco netlink multicast messages\n");

WARNING: line length of 90 exceeds 80 columns
#1596: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1235:
+static int ovpn_parse_remote(struct ovpn_ctx *ovpn, const char *host, const char *service,

WARNING: line length of 106 exceeds 80 columns
#1612: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1251:
+		if (!(result->ai_family == AF_INET && result->ai_addrlen == sizeof(struct sockaddr_in)) &&

WARNING: line length of 108 exceeds 80 columns
#1613: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1252:
+		    !(result->ai_family == AF_INET6 && result->ai_addrlen == sizeof(struct sockaddr_in6))) {

WARNING: line length of 98 exceeds 80 columns
#1625: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1264:
+	if (!(result->ai_family == AF_INET && result->ai_addrlen == sizeof(struct sockaddr_in)) &&

WARNING: line length of 100 exceeds 80 columns
#1626: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1265:
+	    !(result->ai_family == AF_INET6 && result->ai_addrlen == sizeof(struct sockaddr_in6))) {

WARNING: line length of 93 exceeds 80 columns
#1640: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1279:
+static int ovpn_parse_new_peer(struct ovpn_ctx *ovpn, const char *peer_id, const char *raddr,

WARNING: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90
#1732: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1371:
+		strncpy(ovpn.ifname, argv[2], IFNAMSIZ - 1);

ERROR: space required after that close brace '}'
#1772: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1411:
+	}else if (!strcmp(argv[1], "del_iface")) {

WARNING: line length of 89 exceeds 80 columns
#1826: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1465:
+			ret = ovpn_parse_new_peer(&peer_ctx, peer_id, NULL, NULL, vpnip);

WARNING: line length of 99 exceeds 80 columns
#1834: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1473:
+				fprintf(stderr, "cannot add peer to VPN: %s %s\n", peer_id, vpnip);

WARNING: line length of 85 exceeds 80 columns
#1849: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1488:
+		ret = ovpn_parse_new_peer(&ovpn, argv[3], argv[4], argv[5], argv[6]);

WARNING: line length of 85 exceeds 80 columns
#1898: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1537:
+		ret = ovpn_parse_new_peer(&ovpn, argv[4], argv[5], argv[6], argv[7]);

WARNING: line length of 94 exceeds 80 columns
#1937: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1576:
+		while ((n = fscanf(fp, "%s %s %s %s\n", peer_id, raddr, rport, vpnip)) == 4) {

WARNING: line length of 91 exceeds 80 columns
#1944: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1583:
+			ret = ovpn_parse_new_peer(&peer_ctx, peer_id, raddr, rport, vpnip);

WARNING: line length of 97 exceeds 80 columns
#1952: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1591:
+				fprintf(stderr, "cannot add peer to VPN: %s %s %s %s\n", peer_id,

WARNING: Missing a blank line after declarations
#2019: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1658:
+		int slot = strtoul(argv[4], NULL, 10);
+		if ((errno == ERANGE) || (slot < 1) || (slot > 2)) {

CHECK: Unnecessary parentheses around 'errno == ERANGE'
#2019: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1658:
+		if ((errno == ERANGE) || (slot < 1) || (slot > 2)) {

CHECK: Unnecessary parentheses around 'slot < 1'
#2019: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1658:
+		if ((errno == ERANGE) || (slot < 1) || (slot > 2)) {

CHECK: Unnecessary parentheses around 'slot > 2'
#2019: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1658:
+		if ((errno == ERANGE) || (slot < 1) || (slot > 2)) {

CHECK: Unnecessary parentheses around 'errno == ERANGE'
#2034: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1673:
+		if ((errno == ERANGE) || (ovpn.key_id > 2)) {

CHECK: Unnecessary parentheses around 'ovpn.key_id > 2'
#2034: FILE: tools/testing/selftests/ovpn/ovpn-cli.c:1673:
+		if ((errno == ERANGE) || (ovpn.key_id > 2)) {

total: 1 errors, 67 warnings, 6 checks, 2040 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit ad68935792cb ("testing/selftest: add test tool and scripts for ovpn module") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.