CHECK: extern prototypes should be avoided in .h files #100: FILE: arch/x86/include/asm/vmware.h:61: +extern unsigned long vmware_hypercall_slow(unsigned long cmd, WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #125: FILE: arch/x86/include/asm/vmware.h:86: + asm_inline volatile (VMWARE_HYPERCALL WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #146: FILE: arch/x86/include/asm/vmware.h:107: + asm_inline volatile (VMWARE_HYPERCALL WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #167: FILE: arch/x86/include/asm/vmware.h:128: + asm_inline volatile (VMWARE_HYPERCALL WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #189: FILE: arch/x86/include/asm/vmware.h:150: + asm_inline volatile (VMWARE_HYPERCALL WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #213: FILE: arch/x86/include/asm/vmware.h:174: + asm_inline volatile (VMWARE_HYPERCALL WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #237: FILE: arch/x86/include/asm/vmware.h:198: + asm_inline volatile (VMWARE_HYPERCALL CHECK: Lines should not end with a '(' #271: FILE: arch/x86/include/asm/vmware.h:232: + asm_inline volatile ( WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #271: FILE: arch/x86/include/asm/vmware.h:232: + asm_inline volatile ( WARNING: space prohibited between function name and open parenthesis '(' #286: FILE: arch/x86/include/asm/vmware.h:247: + [in6] VMW_BP_CONSTRAINT (in6) CHECK: Lines should not end with a '(' #305: FILE: arch/x86/include/asm/vmware.h:260: + asm_inline volatile ( WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #305: FILE: arch/x86/include/asm/vmware.h:260: + asm_inline volatile ( WARNING: space prohibited between function name and open parenthesis '(' #320: FILE: arch/x86/include/asm/vmware.h:275: + [in6] VMW_BP_CONSTRAINT (in6) CHECK: Please use a blank line after function/struct/union/enum declarations #324: FILE: arch/x86/include/asm/vmware.h:279: +} +#undef VMW_BP_CONSTRAINT WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #365: FILE: arch/x86/kernel/cpu/vmware.c:115: + asm_inline volatile ("vmcall" WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #377: FILE: arch/x86/kernel/cpu/vmware.c:127: + asm_inline volatile ("vmmcall" WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #389: FILE: arch/x86/kernel/cpu/vmware.c:139: + asm_inline volatile ("movw %[port], %%dx; inl (%%dx), %%eax" total: 0 errors, 13 warnings, 4 checks, 364 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 35c4bac8e84e ("x86/vmware: Introduce VMware hypercall API") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 13 warnings, 4 checks, 364 lines checked