WARNING: line length of 90 exceeds 80 columns #67: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:2221: +static int gaudi2_send_cpu_message(struct hl_device *hdev, u32 *msg, u16 len, u32 timeout, CHECK: Alignment should match open parenthesis #68: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:2222: +static int gaudi2_send_cpu_message(struct hl_device *hdev, u32 *msg, u16 len, u32 timeout, + u64 *result); WARNING: line length of 98 exceeds 80 columns #80: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:2390: + * The NIC driver section size and the HMMU page tables section in the HBM needs to be the WARNING: line length of 94 exceeds 80 columns #81: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:2391: + * remaining size in the first dram page after taking into account the F/W image size. WARNING: line length of 95 exceeds 80 columns #84: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:2394: + (HMMU_PAGE_TABLES_SIZE + EDMA_PQS_SIZE + EDMA_SCRATCHPAD_SIZE); WARNING: line length of 88 exceeds 80 columns #122: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3012: + /* Skip for hard or device release reset flow. No need to repopulate. */ WARNING: line length of 91 exceeds 80 columns #144: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3085: +static int gaudi2_fetch_frequency(struct hl_device *hdev, u32 pll_index, u16 *pll_freq_arr) WARNING: line length of 83 exceeds 80 columns #219: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3311: + /* max 250 MB per packet, in order to avoid CPUCP packet timeout */ WARNING: line length of 83 exceeds 80 columns #225: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3317: + pkt.cpucp_pkt.ctl = cpu_to_le32(CPUCP_PACKET_NIC_CLR_MEM << WARNING: line length of 84 exceeds 80 columns #226: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3318: + CPUCP_PKT_CTL_OPCODE_SHIFT); WARNING: line length of 81 exceeds 80 columns #227: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3319: + pkt.mem_base_addr = cpu_to_le64(asic_prop->nic_drv_addr + WARNING: line length of 93 exceeds 80 columns #233: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3325: + /* add 1 as it was subtracted in original size calculation */ WARNING: line length of 95 exceeds 80 columns #234: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3326: + pkt.size = cpu_to_le32(nic_drv_size - gran_per_packet * i + 1); WARNING: line length of 95 exceeds 80 columns #236: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3328: + rc = gaudi2_send_cpu_message(hdev, (u32 *) &pkt, sizeof(pkt), 0, NULL); CHECK: No space is necessary after a cast #236: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3328: + rc = gaudi2_send_cpu_message(hdev, (u32 *) &pkt, sizeof(pkt), 0, NULL); WARNING: line length of 81 exceeds 80 columns #245: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3337: + for (i = 0; i < hdev->asic_prop.nic_drv_size; i += sizeof(val)) { WARNING: line length of 84 exceeds 80 columns #246: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3338: + rc = hdev->asic_funcs->access_dev_mem(hdev, PCI_REGION_DRAM, WARNING: line length of 97 exceeds 80 columns #247: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3339: + hdev->asic_prop.nic_drv_addr + i, WARNING: line length of 87 exceeds 80 columns #248: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3340: + &val, DEBUGFS_WRITE64); WARNING: line length of 82 exceeds 80 columns #252: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3344: + hdev->asic_prop.nic_drv_addr + i); CHECK: Alignment should match open parenthesis #252: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3344: + dev_err(hdev->dev, "Failed to set nic memory. addr: 0x%llx", + hdev->asic_prop.nic_drv_addr + i); WARNING: line length of 95 exceeds 80 columns #276: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3427: + pkt.ctl = cpu_to_le32(CPUCP_PACKET_NIC_ECC_INTRS_UNMASK << CPUCP_PKT_CTL_OPCODE_SHIFT); WARNING: line length of 81 exceeds 80 columns #278: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3429: + return gaudi2_send_cpu_message(hdev, (u32 *) &pkt, sizeof(pkt), 0, NULL); CHECK: No space is necessary after a cast #278: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:3429: + return gaudi2_send_cpu_message(hdev, (u32 *) &pkt, sizeof(pkt), 0, NULL); WARNING: line length of 95 exceeds 80 columns #314: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:4984: + * Mark the NIC as in reset to avoid any new NIC accesses to the H/W. This must be done WARNING: line length of 83 exceeds 80 columns #315: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:4985: + * before we stop the CPU as the NIC might use it e.g. get/set EEPROM data. WARNING: line length of 95 exceeds 80 columns #357: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:5558: + gaudi2_arm_monitors_for_virt_msix_db(hdev, sob_id, first_mon_id, interrupt_id); WARNING: line length of 95 exceeds 80 columns #383: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:6637: + /* On PLDM the NIC PHY link is always up, and because the NIC interrupts are enabled by WARNING: line length of 93 exceeds 80 columns #457: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8022: + if (!(hdev->cn.ports_mask & BIT(i * NIC_NUMBER_OF_QM_PER_MACRO + q))) WARNING: line length of 81 exceeds 80 columns #473: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8148: +static void gaudi2_handle_bmon_spmu_event(struct hl_device *hdev, u8 macro_index) WARNING: line length of 83 exceeds 80 columns #475: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8150: + /* For this point a profiler is not configuring the BMON and SPMU block and WARNING: line length of 83 exceeds 80 columns #476: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8151: + * therefore we can't deduce which port and entity triggered the interrupt. WARNING: line length of 86 exceeds 80 columns #477: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8152: + * So for now we only clear all interrupt registers to prevent interrupt flood WARNING: line length of 83 exceeds 80 columns #481: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8156: + WREG32(debug_spmu_regs[GAUDI2_SPMU_NIC0_DBG_0 + macro_index * macro_offset] WARNING: line length of 83 exceeds 80 columns #483: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8158: + WREG32(debug_spmu_regs[GAUDI2_SPMU_NIC0_DBG_1 + macro_index * macro_offset] WARNING: line length of 85 exceeds 80 columns #487: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8162: + WREG32(debug_bmon_regs[GAUDI2_BMON_NIC0_DBG_0_0 + macro_index * macro_offset] WARNING: line length of 85 exceeds 80 columns #489: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8164: + WREG32(debug_bmon_regs[GAUDI2_BMON_NIC0_DBG_1_0 + macro_index * macro_offset] WARNING: line length of 85 exceeds 80 columns #491: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8166: + WREG32(debug_bmon_regs[GAUDI2_BMON_NIC0_DBG_2_0 + macro_index * macro_offset] WARNING: line length of 85 exceeds 80 columns #493: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8168: + WREG32(debug_bmon_regs[GAUDI2_BMON_NIC0_DBG_0_1 + macro_index * macro_offset] WARNING: line length of 85 exceeds 80 columns #495: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8170: + WREG32(debug_bmon_regs[GAUDI2_BMON_NIC0_DBG_1_1 + macro_index * macro_offset] WARNING: line length of 85 exceeds 80 columns #497: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8172: + WREG32(debug_bmon_regs[GAUDI2_BMON_NIC0_DBG_2_1 + macro_index * macro_offset] WARNING: line length of 99 exceeds 80 columns #501: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8176: +static int gaudi2_handle_nic_sw_error_event(struct hl_device *hdev, u16 event_type, u8 macro_index, WARNING: line length of 92 exceeds 80 columns #502: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8177: + struct hl_eq_nic_intr_cause *nic_intr_cause) CHECK: Alignment should match open parenthesis #502: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8177: +static int gaudi2_handle_nic_sw_error_event(struct hl_device *hdev, u16 event_type, u8 macro_index, + struct hl_eq_nic_intr_cause *nic_intr_cause) WARNING: line length of 84 exceeds 80 columns #506: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8181: + error_count = gaudi2_cn_handle_sw_error_event(hdev, event_type, macro_index, CHECK: Alignment should match open parenthesis #507: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8182: + error_count = gaudi2_cn_handle_sw_error_event(hdev, event_type, macro_index, + nic_intr_cause); WARNING: line length of 93 exceeds 80 columns #521: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8600: +static int gaudi2_handle_nic_axi_error_response_event(struct hl_device *hdev, u16 event_type, WARNING: line length of 92 exceeds 80 columns #522: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8601: + u8 macro_index, struct hl_eq_nic_intr_cause *nic_intr_cause, CHECK: Alignment should match open parenthesis #522: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8601: +static int gaudi2_handle_nic_axi_error_response_event(struct hl_device *hdev, u16 event_type, + u8 macro_index, struct hl_eq_nic_intr_cause *nic_intr_cause, WARNING: line length of 94 exceeds 80 columns #527: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8606: + error_count = gaudi2_cn_handle_axi_error_response_event(hdev, event_type, macro_index, WARNING: line length of 91 exceeds 80 columns #531: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8610: + gaudi2_ack_module_razwi_event_handler(hdev, RAZWI_NIC, macro_index, 0, event_mask); WARNING: line length of 92 exceeds 80 columns #544: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:8829: + case GAUDI2_EVENT_NIC0_AXI_ERROR_RESPONSE ... GAUDI2_EVENT_NIC11_AXI_ERROR_RESPONSE: WARNING: line length of 92 exceeds 80 columns #583: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10470: + (GAUDI2_EVENT_NIC1_BMON_SPMU - GAUDI2_EVENT_NIC0_BMON_SPMU); WARNING: line length of 92 exceeds 80 columns #596: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10513: + case GAUDI2_EVENT_NIC0_AXI_ERROR_RESPONSE ... GAUDI2_EVENT_NIC11_AXI_ERROR_RESPONSE: WARNING: line length of 97 exceeds 80 columns #598: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10515: + error_count = gaudi2_handle_nic_axi_error_response_event(hdev, event_type, index, WARNING: line length of 96 exceeds 80 columns #599: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10516: + &eq_entry->nic_intr_cause, &event_mask); CHECK: Alignment should match open parenthesis #599: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10516: + error_count = gaudi2_handle_nic_axi_error_response_event(hdev, event_type, index, + &eq_entry->nic_intr_cause, &event_mask); WARNING: line length of 94 exceeds 80 columns #600: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10517: + error_count += gaudi2_handle_qm_sei_err(hdev, event_type, false, &event_mask); WARNING: line length of 90 exceeds 80 columns #617: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10534: + (GAUDI2_EVENT_NIC1_SW_ERROR - GAUDI2_EVENT_NIC0_SW_ERROR); WARNING: line length of 87 exceeds 80 columns #618: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10535: + error_count = gaudi2_handle_nic_sw_error_event(hdev, event_type, index, WARNING: line length of 83 exceeds 80 columns #619: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10536: + &eq_entry->nic_intr_cause); CHECK: Alignment should match open parenthesis #619: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10536: + error_count = gaudi2_handle_nic_sw_error_event(hdev, event_type, index, + &eq_entry->nic_intr_cause); WARNING: line length of 89 exceeds 80 columns #630: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10560: + case GAUDI2_EVENT_CPU0_STATUS_NIC0_ENG0 ... GAUDI2_EVENT_CPU11_STATUS_NIC11_ENG1: WARNING: line length of 95 exceeds 80 columns #631: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:10561: + hl_cn_send_status(hdev, event_type - GAUDI2_EVENT_CPU0_STATUS_NIC0_ENG0, 0, 0); WARNING: line length of 91 exceeds 80 columns #651: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:11851: + nic_id++, queue_id += NUM_OF_PQ_PER_QMAN) { CHECK: Blank lines aren't necessary after an open brace '{' #652: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:11852: + nic_id++, queue_id += NUM_OF_PQ_PER_QMAN) { + CHECK: Alignment should match open parenthesis #660: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:11860: + if ((gaudi2->nic_hw_cap_initialized & nic_mask) && + (!(hdev->cn.ports_mask & BIT(nic_id)))) { CHECK: Blank lines aren't necessary after an open brace '{' #661: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:11861: + (!(hdev->cn.ports_mask & BIT(nic_id)))) { + WARNING: line length of 88 exceeds 80 columns #662: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:11862: + gaudi2_stop_qman_common(hdev, gaudi2_qm_blocks_bases[queue_id]); WARNING: line length of 91 exceeds 80 columns #663: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:11863: + gaudi2_disable_qman_common(hdev, gaudi2_qm_blocks_bases[queue_id]); WARNING: line length of 83 exceeds 80 columns #697: FILE: drivers/accel/habanalabs/gaudi2/gaudi2.c:11970: +static int gaudi2_get_reg_pcie_addr(struct hl_device *hdev, u32 reg, u64 *pci_addr) WARNING: line length of 85 exceeds 80 columns #793: FILE: drivers/accel/habanalabs/gaudi2/gaudi2P.h:262: + GAUDI2_RESERVED_SOB_NIC_PORT_FIRST + NIC_NUMBER_OF_PORTS - 1, WARNING: line length of 89 exceeds 80 columns #803: FILE: drivers/accel/habanalabs/gaudi2/gaudi2P.h:279: + GAUDI2_RESERVED_MON_NIC_PORT_FIRST + 3 * NIC_NUMBER_OF_PORTS - 1, WARNING: line length of 96 exceeds 80 columns #847: FILE: drivers/accel/habanalabs/gaudi2/gaudi2P.h:625: +void gaudi2_cn_spmu_get_stats_info(struct hl_device *hdev, u32 port, struct hbl_cn_stat **stats, CHECK: Alignment should match open parenthesis #848: FILE: drivers/accel/habanalabs/gaudi2/gaudi2P.h:626: +void gaudi2_cn_spmu_get_stats_info(struct hl_device *hdev, u32 port, struct hbl_cn_stat **stats, + u32 *n_stats); WARNING: line length of 99 exceeds 80 columns #849: FILE: drivers/accel/habanalabs/gaudi2/gaudi2P.h:627: +int gaudi2_cn_spmu_config(struct hl_device *hdev, u32 port, u32 num_event_types, u32 event_types[], CHECK: Alignment should match open parenthesis #850: FILE: drivers/accel/habanalabs/gaudi2/gaudi2P.h:628: +int gaudi2_cn_spmu_config(struct hl_device *hdev, u32 port, u32 num_event_types, u32 event_types[], + bool enable); WARNING: line length of 94 exceeds 80 columns #851: FILE: drivers/accel/habanalabs/gaudi2/gaudi2P.h:629: +int gaudi2_cn_spmu_sample(struct hl_device *hdev, u32 port, u32 num_out_data, u64 out_data[]); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #859: new file mode 100644 WARNING: line length of 91 exceeds 80 columns #879: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:16: +int gaudi2_cn_handle_sw_error_event(struct hl_device *hdev, u16 event_type, u8 macro_index, WARNING: line length of 84 exceeds 80 columns #880: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:17: + struct hl_eq_nic_intr_cause *nic_intr_cause) CHECK: Alignment should match open parenthesis #880: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:17: +int gaudi2_cn_handle_sw_error_event(struct hl_device *hdev, u16 event_type, u8 macro_index, + struct hl_eq_nic_intr_cause *nic_intr_cause) WARNING: line length of 93 exceeds 80 columns #888: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:25: + error_count = aux_ops->sw_err_event_handler(aux_dev, event_type, macro_index, WARNING: line length of 85 exceeds 80 columns #894: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:31: +int gaudi2_cn_handle_axi_error_response_event(struct hl_device *hdev, u16 event_type, CHECK: Alignment should match open parenthesis #895: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:32: +int gaudi2_cn_handle_axi_error_response_event(struct hl_device *hdev, u16 event_type, + u8 macro_index, WARNING: line length of 92 exceeds 80 columns #896: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:33: + struct hl_eq_nic_intr_cause *nic_intr_cause) WARNING: line length of 92 exceeds 80 columns #904: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:41: + error_count = aux_ops->axi_error_response_event_handler(aux_dev, event_type, WARNING: line length of 84 exceeds 80 columns #905: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:42: + macro_index, WARNING: line length of 88 exceeds 80 columns #906: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:43: + nic_intr_cause); WARNING: line length of 84 exceeds 80 columns #933: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:70: + NIC_WREG32(mmNIC0_QPC0_INTERRUPT_RESP_ERR_MASK, 0xFFFFFFFF); WARNING: line length of 95 exceeds 80 columns #994: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:131: +static void gaudi2_cn_override_ports_ext_mask(struct hl_device *hdev, uint64_t *ports_ext_mask) WARNING: line length of 81 exceeds 80 columns #996: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:133: + /* For asic type GAUDI2B, the external ports mask shouldn't be changed */ WARNING: line length of 86 exceeds 80 columns #1002: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:139: + /* If we are running on a PCI card, all the ports should be set as external */ WARNING: line length of 87 exceeds 80 columns #1034: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:171: + struct hbl_cn_cpucp_info *cn_cpucp_info = &hdev->asic_prop.cn_props.cpucp_info; CHECK: Alignment should match open parenthesis #1065: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:202: + dev_warn(hdev->dev, "unrecognized MAC OUI %pM, port %d\n", + mac_addr, i); WARNING: line length of 92 exceeds 80 columns #1102: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:239: + /* If we are running on non HLS2 setup or a PCI card, all the ports should be set as WARNING: line length of 82 exceeds 80 columns #1132: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:269: +static char *gaudi2_cn_get_event_name(struct hbl_aux_dev *aux_dev, u16 event_type) WARNING: line length of 95 exceeds 80 columns #1134: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:271: + return gaudi2_irq_map_table[event_type].valid ? gaudi2_irq_map_table[event_type].name : CHECK: Alignment should match open parenthesis #1139: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:276: +static int gaudi2_cn_poll_mem(struct hbl_aux_dev *aux_dev, u32 *addr, u32 *val, + hbl_cn_poll_cond_func func) WARNING: line length of 83 exceeds 80 columns #1145: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:282: +static void *gaudi2_cn_dma_alloc_coherent(struct hbl_aux_dev *aux_dev, size_t size, WARNING: line length of 97 exceeds 80 columns #1151: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:288: +static void gaudi2_cn_dma_free_coherent(struct hbl_aux_dev *aux_dev, size_t size, void *cpu_addr, WARNING: line length of 97 exceeds 80 columns #1157: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:294: +static void *gaudi2_cn_dma_pool_zalloc(struct hbl_aux_dev *aux_dev, size_t size, gfp_t mem_flags, WARNING: line length of 98 exceeds 80 columns #1163: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:300: +static void gaudi2_cn_dma_pool_free(struct hbl_aux_dev *aux_dev, void *vaddr, dma_addr_t dma_addr) WARNING: line length of 83 exceeds 80 columns #1187: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:324: + gaudi2_aux_data->fw_security_enabled = hdev->asic_prop.fw_security_enabled; WARNING: line length of 85 exceeds 80 columns #1188: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:325: + gaudi2_aux_data->msix_enabled = !!(gaudi2->hw_cap_initialized & HW_CAP_MSIX); WARNING: line length of 97 exceeds 80 columns #1242: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:379: +static void gaudi2_cn_ports_stop_prepare(struct hl_device *hdev, bool fw_reset, bool in_teardown) WARNING: line length of 83 exceeds 80 columns #1253: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:390: + gaudi2_aux_ops->ports_stop_prepare(aux_dev, fw_reset, in_teardown); WARNING: line length of 96 exceeds 80 columns #1256: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:393: +static int gaudi2_cn_send_port_cpucp_status(struct hl_device *hdev, u32 port, u8 cmd, u8 period) WARNING: line length of 90 exceeds 80 columns #1267: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.c:404: + return gaudi2_aux_ops->send_port_cpucp_status(aux_dev, port, cmd, period); CHECK: Macro argument 'reg' may be better as '(reg)' to avoid precedence issues #1318: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:25: +#define NIC_CFG_BASE(port, reg) \ + ((u64) (NIC_MACRO_CFG_BASE(port) + \ + ((reg < mmNIC0_RXE0_CONTROL) ? \ + (NIC_CFG_LO_SIZE * (u64) ((port) & 1)) : \ + (NIC_CFG_HI_SIZE * (u64) ((port) & 1))))) CHECK: No space is necessary after a cast #1319: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:26: + ((u64) (NIC_MACRO_CFG_BASE(port) + \ CHECK: No space is necessary after a cast #1321: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:28: + (NIC_CFG_LO_SIZE * (u64) ((port) & 1)) : \ CHECK: No space is necessary after a cast #1322: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:29: + (NIC_CFG_HI_SIZE * (u64) ((port) & 1))))) WARNING: line length of 91 exceeds 80 columns #1330: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:37: +int gaudi2_cn_handle_sw_error_event(struct hl_device *hdev, u16 event_type, u8 macro_index, WARNING: line length of 85 exceeds 80 columns #1331: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:38: + struct hl_eq_nic_intr_cause *nic_intr_cause); CHECK: Alignment should match open parenthesis #1331: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:38: +int gaudi2_cn_handle_sw_error_event(struct hl_device *hdev, u16 event_type, u8 macro_index, + struct hl_eq_nic_intr_cause *nic_intr_cause); WARNING: line length of 85 exceeds 80 columns #1332: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:39: +int gaudi2_cn_handle_axi_error_response_event(struct hl_device *hdev, u16 event_type, WARNING: line length of 93 exceeds 80 columns #1333: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:40: + u8 macro_index, struct hl_eq_nic_intr_cause *nic_intr_cause); CHECK: Alignment should match open parenthesis #1333: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_cn.h:40: +int gaudi2_cn_handle_axi_error_response_event(struct hl_device *hdev, u16 event_type, + u8 macro_index, struct hl_eq_nic_intr_cause *nic_intr_cause); WARNING: line length of 87 exceeds 80 columns #1406: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c:2456: + return reg_idx >= GAUDI2_SPMU_NIC0_DBG_0 && reg_idx <= GAUDI2_SPMU_NIC11_DBG_1; WARNING: line length of 85 exceeds 80 columns #1416: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c:2569: +static int gaudi2_sample_spmu(struct hl_device *hdev, struct hl_debug_params *params) WARNING: line length of 96 exceeds 80 columns #1459: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c:2612: +void gaudi2_cn_spmu_get_stats_info(struct hl_device *hdev, u32 port, struct hbl_cn_stat **stats, CHECK: Alignment should match open parenthesis #1460: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c:2613: +void gaudi2_cn_spmu_get_stats_info(struct hl_device *hdev, u32 port, struct hbl_cn_stat **stats, + u32 *n_stats) WARNING: line length of 99 exceeds 80 columns #1476: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c:2629: +int gaudi2_cn_spmu_config(struct hl_device *hdev, u32 port, u32 num_event_types, u32 event_types[], CHECK: Alignment should match open parenthesis #1477: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c:2630: +int gaudi2_cn_spmu_config(struct hl_device *hdev, u32 port, u32 num_event_types, u32 event_types[], + bool enable) WARNING: line length of 93 exceeds 80 columns #1510: FILE: drivers/accel/habanalabs/gaudi2/gaudi2_coresight.c:2663: +int gaudi2_cn_spmu_sample(struct hl_device *hdev, u32 port, u32 num_out_data, u64 out_data[]) total: 0 errors, 100 warnings, 26 checks, 1421 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 92c4a425fcc0 ("accel/habanalabs/gaudi2: network scaling support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 100 warnings, 26 checks, 1421 lines checked