WARNING: line length of 97 exceeds 80 columns #53: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:65: +#define __regex(regex) __attribute__((btf_decl_tag("comment:test_expect_regex=" regex))) WARNING: line length of 104 exceeds 80 columns #58: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:70: +#define __regex_unpriv(regex) __attribute__((btf_decl_tag("comment:test_expect_regex_unpriv=" regex))) WARNING: line length of 81 exceeds 80 columns #126: FILE: tools/testing/selftests/bpf/test_loader.c:116: + (1 + subspec->expect_msg_cnt) * sizeof(struct expect_msg)); WARNING: line length of 81 exceeds 80 columns #147: FILE: tools/testing/selftests/bpf/test_loader.c:135: + (1 + subspec->expect_msg_cnt) * sizeof(struct expect_msg)); WARNING: line length of 93 exceeds 80 columns #154: FILE: tools/testing/selftests/bpf/test_loader.c:142: + subspec->expect[subspec->expect_msg_cnt].regex = (regex_t *) malloc(sizeof(regex_t)); CHECK: No space is necessary after a cast #154: FILE: tools/testing/selftests/bpf/test_loader.c:142: + subspec->expect[subspec->expect_msg_cnt].regex = (regex_t *) malloc(sizeof(regex_t)); WARNING: space prohibited between function name and open parenthesis '(' #155: FILE: tools/testing/selftests/bpf/test_loader.c:143: + regcomp_res = regcomp (subspec->expect[subspec->expect_msg_cnt].regex, CHECK: spaces preferred around that '|' (ctx:VxV) #156: FILE: tools/testing/selftests/bpf/test_loader.c:144: + regex_str, REG_EXTENDED|REG_NEWLINE); ^ WARNING: line length of 90 exceeds 80 columns #194: FILE: tools/testing/selftests/bpf/test_loader.c:390: + size_t sz = spec->priv.expect_msg_cnt * sizeof(struct expect_msg); WARNING: line length of 92 exceeds 80 columns #201: FILE: tools/testing/selftests/bpf/test_loader.c:394: + PRINT_FAIL("failed to allocate memory for unpriv.expect\n"); CHECK: Comparison to NULL could be written "!regex" #225: FILE: tools/testing/selftests/bpf/test_loader.c:466: + if (regex == NULL) { WARNING: line length of 93 exceeds 80 columns #226: FILE: tools/testing/selftests/bpf/test_loader.c:467: + match = strstr(tester->log_buf + tester->next_match_pos, expect_msg); WARNING: space prohibited between function name and open parenthesis '(' #227: FILE: tools/testing/selftests/bpf/test_loader.c:468: + if (!ASSERT_OK_PTR (match, "expect_msg")) { WARNING: line length of 90 exceeds 80 columns #228: FILE: tools/testing/selftests/bpf/test_loader.c:469: + /* if we are in verbose mode, we've already emitted log */ WARNING: line length of 91 exceeds 80 columns #230: FILE: tools/testing/selftests/bpf/test_loader.c:471: + emit_verifier_log(tester->log_buf, true /*force*/); WARNING: line length of 96 exceeds 80 columns #233: FILE: tools/testing/selftests/bpf/test_loader.c:474: + "MATCHED MSG: '%s'\n", subspec->expect[j].msg); WARNING: line length of 84 exceeds 80 columns #234: FILE: tools/testing/selftests/bpf/test_loader.c:475: + fprintf(stderr, "EXPECTED MSG: '%s'\n", expect_msg); WARNING: line length of 94 exceeds 80 columns #237: FILE: tools/testing/selftests/bpf/test_loader.c:478: + tester->next_match_pos = match - tester->log_buf + strlen(expect_msg); WARNING: line length of 116 exceeds 80 columns #239: FILE: tools/testing/selftests/bpf/test_loader.c:480: + int match_size = regexec (regex, tester->log_buf + tester->next_match_pos, 1, reg_match, 0); WARNING: space prohibited between function name and open parenthesis '(' #239: FILE: tools/testing/selftests/bpf/test_loader.c:480: + int match_size = regexec (regex, tester->log_buf + tester->next_match_pos, 1, reg_match, 0); WARNING: Missing a blank line after declarations #240: FILE: tools/testing/selftests/bpf/test_loader.c:481: + int match_size = regexec (regex, tester->log_buf + tester->next_match_pos, 1, reg_match, 0); + if (match_size != 1) { WARNING: line length of 90 exceeds 80 columns #241: FILE: tools/testing/selftests/bpf/test_loader.c:482: + /* if we are in verbose mode, we've already emitted log */ WARNING: line length of 91 exceeds 80 columns #243: FILE: tools/testing/selftests/bpf/test_loader.c:484: + emit_verifier_log(tester->log_buf, true /*force*/); WARNING: line length of 98 exceeds 80 columns #246: FILE: tools/testing/selftests/bpf/test_loader.c:487: + "MATCHED REGEX: '%s'\n", subspec->expect[j].msg); WARNING: line length of 86 exceeds 80 columns #247: FILE: tools/testing/selftests/bpf/test_loader.c:488: + fprintf(stderr, "EXPECTED REGEX: '%s'\n", expect_msg); total: 0 errors, 22 warnings, 3 checks, 230 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 54cd449bd433 ("selftests/bpf: Support checks against a regular expression.") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 22 warnings, 3 checks, 230 lines checked