CHECK: spaces preferred around that '<<' (ctx:VxV) #597: FILE: drivers/net/ethernet/smsc/smc91x.h:848: + SMC_outl((x)<<16, lp->base, SMC_REG(lp, 0, 2)); \ ^ WARNING: Argument 'lp' is not used in function-like macro #664: FILE: drivers/net/ethernet/smsc/smc91x.h:897: +#define SMC_CURRENT_BANK(lp, ioaddr) SMC_inw(ioaddr, BANK_SELECT) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #682: FILE: drivers/net/ethernet/smsc/smc91x.h:911: +#define SMC_GET_CONFIG(lp) SMC_inw(lp->base, CONFIG_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #688: FILE: drivers/net/ethernet/smsc/smc91x.h:915: +#define SMC_GET_COUNTER(lp) SMC_inw(lp->base, COUNTER_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #691: FILE: drivers/net/ethernet/smsc/smc91x.h:917: +#define SMC_GET_CTL(lp) SMC_inw(lp->base, CTL_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #697: FILE: drivers/net/ethernet/smsc/smc91x.h:921: +#define SMC_GET_MII(lp) SMC_inw(lp->base, MII_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #700: FILE: drivers/net/ethernet/smsc/smc91x.h:923: +#define SMC_GET_GP(lp) SMC_inw(lp->base, GP_REG(lp)) CHECK: spaces preferred around that '<<' (ctx:VxV) #706: FILE: drivers/net/ethernet/smsc/smc91x.h:928: + SMC_outl((x)<<16, lp->base, SMC_REG(lp, 8, 1)); \ ^ CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #716: FILE: drivers/net/ethernet/smsc/smc91x.h:935: +#define SMC_GET_MIR(lp) SMC_inw(lp->base, MIR_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #722: FILE: drivers/net/ethernet/smsc/smc91x.h:939: +#define SMC_GET_MMU_CMD(lp) SMC_inw(lp->base, MMU_CMD_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #728: FILE: drivers/net/ethernet/smsc/smc91x.h:943: +#define SMC_GET_FIFO(lp) SMC_inw(lp->base, FIFO_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #731: FILE: drivers/net/ethernet/smsc/smc91x.h:945: +#define SMC_GET_PTR(lp) SMC_inw(lp->base, PTR_REG(lp)) CHECK: spaces preferred around that '<<' (ctx:VxV) #737: FILE: drivers/net/ethernet/smsc/smc91x.h:950: + SMC_outl((x)<<16, lp->base, SMC_REG(lp, 4, 2)); \ ^ CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #744: FILE: drivers/net/ethernet/smsc/smc91x.h:955: +#define SMC_GET_EPH_STATUS(lp) SMC_inw(lp->base, EPH_STATUS_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #747: FILE: drivers/net/ethernet/smsc/smc91x.h:957: +#define SMC_GET_RCR(lp) SMC_inw(lp->base, RCR_REG(lp)) CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #756: FILE: drivers/net/ethernet/smsc/smc91x.h:963: +#define SMC_GET_RPC(lp) SMC_inw(lp->base, RPC_REG(lp)) CHECK: spaces preferred around that '<<' (ctx:VxV) #762: FILE: drivers/net/ethernet/smsc/smc91x.h:968: + SMC_outl((x)<<16, lp->base, SMC_REG(lp, 8, 0)); \ ^ CHECK: Macro argument 'lp' may be better as '(lp)' to avoid precedence issues #769: FILE: drivers/net/ethernet/smsc/smc91x.h:973: +#define SMC_GET_TCR(lp) SMC_inw(lp->base, TCR_REG(lp)) WARNING: line length of 82 exceeds 80 columns #795: FILE: drivers/net/ethernet/smsc/smc91x.h:992: + SMC_outw(lp, addr[0] | (addr[1] << 8), lp->base, ADDR0_REG(lp)); \ WARNING: line length of 82 exceeds 80 columns #796: FILE: drivers/net/ethernet/smsc/smc91x.h:993: + SMC_outw(lp, addr[2] | (addr[3] << 8), lp->base, ADDR1_REG(lp)); \ WARNING: line length of 82 exceeds 80 columns #797: FILE: drivers/net/ethernet/smsc/smc91x.h:994: + SMC_outw(lp, addr[4] | (addr[5] << 8), lp->base, ADDR2_REG(lp)); \ CHECK: spaces preferred around that '<<' (ctx:VxV) #817: FILE: drivers/net/ethernet/smsc/smc91x.h:1009: + SMC_outl((status) | (length)<<16, lp->base, \ ^ total: 0 errors, 4 warnings, 18 checks, 802 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit dedc349f3d9b ("net: smc91x: Refactor SMC_* macros") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 4 warnings, 18 checks, 802 lines checked