CHECK: Macro argument '__module' may be better as '(__module)' to avoid precedence issues
#106: FILE: drivers/net/ethernet/stmicro/stmmac/hwif.h:21:
+#define stmmac_do_typed_callback(__type, __fail_ret, __priv, __module, \
+				 __cname,  __arg0, __args...) \
 ({ \
+	__type __result = __fail_ret; \
 	if ((__priv)->hw->__module && (__priv)->hw->__module->__cname) \
 		__result = (__priv)->hw->__module->__cname((__arg0), ##__args); \
 	__result; \
 })

CHECK: Macro argument '__cname' may be better as '(__cname)' to avoid precedence issues
#106: FILE: drivers/net/ethernet/stmicro/stmmac/hwif.h:21:
+#define stmmac_do_typed_callback(__type, __fail_ret, __priv, __module, \
+				 __cname,  __arg0, __args...) \
 ({ \
+	__type __result = __fail_ret; \
 	if ((__priv)->hw->__module && (__priv)->hw->__module->__cname) \
 		__result = (__priv)->hw->__module->__cname((__arg0), ##__args); \
 	__result; \
 })

CHECK: Comparison to NULL could be written "hw->mac->phylink_select_pcs"
#147: FILE: drivers/net/ethernet/stmicro/stmmac/hwif.h:546:
+	((__priv)->hw->mac->phylink_select_pcs != NULL)

CHECK: Alignment should match open parenthesis
#192: FILE: drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:546:
+	if (priv->hw->pcs && !stmmac_has_mac_phylink_select_pcs(priv) &&
+	   !stmmac_pcs_get_adv_lp(priv, priv->ioaddr, &adv_lp)) {

total: 0 errors, 0 warnings, 4 checks, 145 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 92c156c05883 ("net: stmmac: add infrastructure for hwifs to provide PCS") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 4 checks, 145 lines checked