WARNING: line length of 87 exceeds 80 columns
#124: FILE: drivers/net/phy/microchip_t1s.c:176:
+static int lan865x_revb0_generate_cfg_offsets(struct phy_device *phydev, s8 offsets[2])

WARNING: line length of 81 exceeds 80 columns
#144: FILE: drivers/net/phy/microchip_t1s.c:205:
+		// The AN states that the readback value is in the range [-5, 15]

WARNING: line length of 86 exceeds 80 columns
#145: FILE: drivers/net/phy/microchip_t1s.c:206:
+		// and that it uses 5 bits, bit wonky of a description, it really only

WARNING: line length of 84 exceeds 80 columns
#150: FILE: drivers/net/phy/microchip_t1s.c:211:
+			// The AN specifies 'ret - 0x20' which is again pretty weird

WARNING: line length of 90 exceeds 80 columns
#151: FILE: drivers/net/phy/microchip_t1s.c:212:
+			// the addition here gives the same result on a s8 (with overflow)

WARNING: line length of 87 exceeds 80 columns
#152: FILE: drivers/net/phy/microchip_t1s.c:213:
+			// the assignment here are downcasting to s8 for sign extension

WARNING: line length of 88 exceeds 80 columns
#158: FILE: drivers/net/phy/microchip_t1s.c:219:
+	// And now for the really weird part, there's no explanation to what any of this

WARNING: line length of 92 exceeds 80 columns
#160: FILE: drivers/net/phy/microchip_t1s.c:221:
+	// Since these ops shift a lot, the previous sign extension is probably meaningless.

WARNING: line length of 92 exceeds 80 columns
#161: FILE: drivers/net/phy/microchip_t1s.c:222:
+	params[0] = (((params[0] + 9) & 0x3F) << 10) | ((params[0] + 14) & 0x3f) << 4 | 0x3;

WARNING: line length of 85 exceeds 80 columns
#167: FILE: drivers/net/phy/microchip_t1s.c:228:
+static int lan865x_revb0_read_cfg_params(struct phy_device *phydev, u16 cfg_params[])

WARNING: line length of 86 exceeds 80 columns
#176: FILE: drivers/net/phy/microchip_t1s.c:243:
+static int lan865x_revb0_write_cfg_params(struct phy_device *phydev, u16 cfg_params[])

WARNING: line length of 87 exceeds 80 columns
#247: FILE: drivers/net/phy/microchip_t1s.c:320:
+		/* All of the regs locatd in mms 4 could use phy_write_mmd as these are

WARNING: line length of 86 exceeds 80 columns
#248: FILE: drivers/net/phy/microchip_t1s.c:321:
+		 * accessible via MDIO_MMD_VEND2, but mms 1 not 'indirect accessible'.

WARNING: line length of 87 exceeds 80 columns
#249: FILE: drivers/net/phy/microchip_t1s.c:322:
+		 * Less conditionals are favored here by doing the set in just one way.

WARNING: line length of 92 exceeds 80 columns
#251: FILE: drivers/net/phy/microchip_t1s.c:324:
+		ret = lan865x_phy_write_mmd(phydev, op->mms | BIT(31), op->addr, fixup_val);

WARNING: line length of 82 exceeds 80 columns
#269: FILE: drivers/net/phy/microchip_t1s.c:340:
+	 * HW rev can be read from the vendor specific DEVID reg mms 10, addr 0x94

WARNING: line length of 81 exceeds 80 columns
#272: FILE: drivers/net/phy/microchip_t1s.c:342:
+	devid = lan865x_phy_read_mmd(phydev, mms10 | BIT(31), LAN865X_REG_DEVID);

total: 0 errors, 17 warnings, 0 checks, 274 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 2ad309a8a33e ("net: phy: microchip_t1s: enable lan865x revb1") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 17 warnings, 0 checks, 274 lines checked