========== checkpatch - FAILED WARNING: line length of 92 exceeds 80 columns #83: FILE: net/xfrm/xfrm_compat.c:133: + [XFRMA_SA_DIR] = NLA_POLICY_RANGE(NLA_U8, XFRM_SA_DIR_IN, XFRM_SA_DIR_OUT), WARNING: line length of 81 exceeds 80 columns #117: FILE: net/xfrm/xfrm_device.c:257: + (!(xuo->flags & XFRM_OFFLOAD_INBOUND) && x->dir == XFRM_SA_DIR_IN)) { WARNING: line length of 90 exceeds 80 columns #193: FILE: net/xfrm/xfrm_user.c:173: + NL_SET_ERR_MSG(extack, "Replay window should be 0 for output SA"); WARNING: line length of 88 exceeds 80 columns #202: FILE: net/xfrm/xfrm_user.c:182: + NL_SET_ERR_MSG(extack, "Replay bmp_len should 0 for output SA"); ERROR: do not use assignment in if condition #231: FILE: net/xfrm/xfrm_user.c:362: + if ((err = verify_replay(p, attrs, sa_dir, extack))) WARNING: line length of 98 exceeds 80 columns #250: FILE: net/xfrm/xfrm_user.c:397: + NL_SET_ERR_MSG(extack, "Flag DECAP_DSCP should not be set for output SA"); WARNING: line length of 92 exceeds 80 columns #256: FILE: net/xfrm/xfrm_user.c:403: + NL_SET_ERR_MSG(extack, "Flag ICMP should not be set for output SA"); WARNING: line length of 96 exceeds 80 columns #262: FILE: net/xfrm/xfrm_user.c:409: + NL_SET_ERR_MSG(extack, "Flag WILDRECV should not be set for output SA"); WARNING: line length of 90 exceeds 80 columns #268: FILE: net/xfrm/xfrm_user.c:415: + NL_SET_ERR_MSG(extack, "Replay window should be 0 for output SA"); WARNING: line length of 97 exceeds 80 columns #289: FILE: net/xfrm/xfrm_user.c:436: + NL_SET_ERR_MSG(extack, "Flag NOPMTUDISC should not be set for input SA"); WARNING: line length of 110 exceeds 80 columns #298: FILE: net/xfrm/xfrm_user.c:445: + NL_SET_ERR_MSG(extack, "Flag DONT_ENCAP_DSCP should not be set for input SA"); WARNING: line length of 108 exceeds 80 columns #304: FILE: net/xfrm/xfrm_user.c:451: + NL_SET_ERR_MSG(extack, "Flag OSEQ_MAY_WRAP should not be set for input SA"); CHECK: Blank lines aren't necessary before a close brace '}' #309: FILE: net/xfrm/xfrm_user.c:456: + + } WARNING: line length of 92 exceeds 80 columns #383: FILE: net/xfrm/xfrm_user.c:3167: + [XFRMA_SA_DIR] = NLA_POLICY_RANGE(NLA_U8, XFRM_SA_DIR_IN, XFRM_SA_DIR_OUT), total: 1 errors, 12 warnings, 1 checks, 336 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b2f7c7bea038 ("xfrm: Add Direction to the SA in or out") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.