WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 ERROR: Macros with complex values should be enclosed in parentheses #44: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:22: +#define BPF_STRUCT_OPS(name, args...) \ +SEC("struct_ops/"#name) \ +BPF_PROG(name, args) CHECK: Please don't use multiple blank lines #48: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:26: + + WARNING: line length of 83 exceeds 80 columns #52: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:30: +static __always_inline struct inet_connection_sock *inet_csk(const struct sock *sk) CHECK: spaces preferred around that '-' (ctx:VxV) #64: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:42: + return (__s32)(seq1-seq2) < 0; ^ CHECK: Please use a blank line after function/struct/union/enum declarations #66: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:44: +} +#define after(seq2, seq1) before(seq1, seq2) WARNING: line length of 81 exceeds 80 columns #71: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:49: +extern void cubictcp_cwnd_event(struct sock *sk, enum tcp_ca_event event) __ksym; WARNING: line length of 84 exceeds 80 columns #75: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:53: +extern void cubictcp_acked(struct sock *sk, const struct ack_sample *sample) __ksym; CHECK: Please don't use multiple blank lines #78: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:56: + + WARNING: line length of 83 exceeds 80 columns #84: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:62: +void BPF_STRUCT_OPS(bpf_cubic_cwnd_event, struct sock *sk, enum tcp_ca_event event) WARNING: line length of 81 exceeds 80 columns #112: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:90: + * [1] : Normal Slow Start condition is (tp->snd_cwnd < tp->snd_ssthresh) CHECK: Lines should not end with a '(' #129: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:107: +static __always_inline void tcp_cwnd_reduction( WARNING: line length of 99 exceeds 80 columns #136: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:114: + __u32 pkts_in_flight = tp->packets_out - (tp->sacked_out + tp->lost_out) + tp->retrans_out; WARNING: line length of 85 exceeds 80 columns #146: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:124: + (__u64)tp->snd_ssthresh * prr_delivered + tp->prior_cwnd - 1; WARNING: line length of 89 exceeds 80 columns #147: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:125: + sndcnt = (__u32)div64_u64(dividend, (__u64)tp->prior_cwnd) - tp->prr_out; CHECK: Lines should not end with a '(' #160: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:138: +static __always_inline bool tcp_may_raise_cwnd( WARNING: line length of 81 exceeds 80 columns #169: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:147: +void BPF_STRUCT_OPS(bpf_cubic_cong_control, struct sock *sk, __u32 ack, int flag, CHECK: Alignment should match open parenthesis #170: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:148: +void BPF_STRUCT_OPS(bpf_cubic_cong_control, struct sock *sk, __u32 ack, int flag, + const struct rate_sample *rs) CHECK: spaces preferred around that '<<' (ctx:VxV) #174: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:152: + if (((1<icsk_ca_state == TCP_CA_CWR) { CHECK: Alignment should match open parenthesis #182: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:160: + if (tp->snd_ssthresh < TCP_INFINITE_SSTHRESH && + inet_csk(sk)->icsk_ca_state == TCP_CA_CWR) { CHECK: Alignment should match open parenthesis #208: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:186: +void BPF_STRUCT_OPS(bpf_cubic_acked, struct sock *sk, + const struct ack_sample *sample) CHECK: Please don't use multiple blank lines #218: FILE: tools/testing/selftests/bpf/progs/bpf_cubic_cong_control.c:196: + + total: 1 errors, 12 warnings, 12 checks, 227 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 42e8f7b5b6e3 ("Add test for the use of new args in cong_control") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.