WARNING: Non-standard signature: 'Signed-of-by:' - perhaps 'Signed-off-by:'? #69: Signed-of-by: Jose E. Marchesi WARNING: space prohibited between function name and open parenthesis '(' #86: FILE: tools/lib/bpf/bpf_helpers.h:189: +#if defined (__clang__) WARNING: line length of 97 exceeds 80 columns #92: FILE: tools/lib/bpf/bpf_helpers.h:195: +#define bpf_ksym_exists(sym) ({ \ CHECK: Macro argument 'sym' may be better as '(sym)' to avoid precedence issues #92: FILE: tools/lib/bpf/bpf_helpers.h:195: +#define bpf_ksym_exists(sym) ({ \ + _Static_assert(__builtin_has_attribute (*sym, __weak__), #sym " should be marked as __weak"); \ + !!sym; \ +}) WARNING: line length of 105 exceeds 80 columns #93: FILE: tools/lib/bpf/bpf_helpers.h:196: + _Static_assert(__builtin_has_attribute (*sym, __weak__), #sym " should be marked as __weak"); \ WARNING: space prohibited between function name and open parenthesis '(' #93: FILE: tools/lib/bpf/bpf_helpers.h:196: + _Static_assert(__builtin_has_attribute (*sym, __weak__), #sym " should be marked as __weak"); \ WARNING: line length of 105 exceeds 80 columns #94: FILE: tools/lib/bpf/bpf_helpers.h:197: + !!sym; \ ERROR: Macros with complex values should be enclosed in parentheses #97: FILE: tools/lib/bpf/bpf_helpers.h:200: +#define bpf_ksym_exists(sym) !!sym CHECK: Macro argument 'sym' may be better as '(sym)' to avoid precedence issues #97: FILE: tools/lib/bpf/bpf_helpers.h:200: +#define bpf_ksym_exists(sym) !!sym total: 1 errors, 6 warnings, 2 checks, 19 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1e9a6c14cd0a ("bpf: fix bpf_ksym_exists in GCC") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.