WARNING: externs should be avoided in .c files #102: FILE: tools/testing/selftests/bpf/bench.c:283: +extern struct argp bench_trigger_batch_argp; WARNING: externs should be avoided in .c files #119: FILE: tools/testing/selftests/bpf/bench.c:514: +extern const struct bench bench_trig_kernel_count; WARNING: externs should be avoided in .c files #120: FILE: tools/testing/selftests/bpf/bench.c:515: +extern const struct bench bench_trig_kprobe_batch; WARNING: externs should be avoided in .c files #121: FILE: tools/testing/selftests/bpf/bench.c:516: +extern const struct bench bench_trig_kretprobe_batch; WARNING: externs should be avoided in .c files #122: FILE: tools/testing/selftests/bpf/bench.c:517: +extern const struct bench bench_trig_kprobe_multi_batch; WARNING: externs should be avoided in .c files #123: FILE: tools/testing/selftests/bpf/bench.c:518: +extern const struct bench bench_trig_kretprobe_multi_batch; WARNING: externs should be avoided in .c files #124: FILE: tools/testing/selftests/bpf/bench.c:519: +extern const struct bench bench_trig_fentry_batch; WARNING: externs should be avoided in .c files #125: FILE: tools/testing/selftests/bpf/bench.c:520: +extern const struct bench bench_trig_fexit_batch; WARNING: line length of 107 exceeds 80 columns #202: FILE: tools/testing/selftests/bpf/benchs/bench_trigger.c:37: + fprintf(stderr, "invalid --trig-batch-iters value (should be between %d and %d)\n", WARNING: line length of 87 exceeds 80 columns #237: FILE: tools/testing/selftests/bpf/benchs/bench_trigger.c:125: + int fd = ctx.driver_prog_fd ?: bpf_program__fd(ctx.skel->progs.trigger_driver); WARNING: line length of 99 exceeds 80 columns #381: FILE: tools/testing/selftests/bpf/benchs/run_bench_trigger.sh:23: + summary=$(sudo ./bench -w2 -d5 -a -p$p trig-$t | tail -n1 | cut -d'(' -f1 | cut -d' ' -f3-) WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #400: FILE: tools/testing/selftests/bpf/progs/trigger_bench.c:106: +const volatile int batch_iters = 0; WARNING: line length of 81 exceeds 80 columns #419: FILE: tools/testing/selftests/bpf/progs/trigger_bench.c:125: + (void)bpf_get_numa_node_id(); /* attach point for benchmarking */ total: 0 errors, 13 warnings, 0 checks, 340 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 5ae04bf1e706 ("selftests/bpf: add batched, mostly in-kernel BPF triggering benchmarks") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 13 warnings, 0 checks, 340 lines checked