WARNING: line length of 81 exceeds 80 columns
#89: FILE: tools/testing/selftests/net/tcp_ao/connect-deny.c:226:
+	trace_hash_event_expect(TCP_HASH_AO_REQUIRED, this_ip_addr, this_ip_dest,

CHECK: Alignment should match open parenthesis
#190: FILE: tools/testing/selftests/net/tcp_ao/key-management.c:1096:
+		trace_ao_event_expect(TCP_AO_RNEXT_REQUEST,
+				this_ip_addr, this_ip_dest,

WARNING: line length of 82 exceeds 80 columns
#192: FILE: tools/testing/selftests/net/tcp_ao/key-management.c:1098:
+				i == 0 ? -1 : collection.keys[i - 1].server_keyid,

CHECK: extern prototypes should be avoided in .h files
#230: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:188:
+extern void test_init_ftrace(int nsfd1, int nsfd2);

CHECK: extern prototypes should be avoided in .h files
#231: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:189:
+extern int test_setup_tracing(void);

CHECK: extern prototypes should be avoided in .h files
#239: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:264:
+extern int switch_save_ns(int fd);

CHECK: extern prototypes should be avoided in .h files
#240: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:265:
+extern void switch_close_ns(int fd);

WARNING: Prefer ____printf__(3, 4) over __attribute__((__format__(__printf__, 3, 4)))
#247: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:272:
+__attribute__((__format__(__printf__, 3, 4)))

CHECK: extern prototypes should be avoided in .h files
#248: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:273:
+extern int test_echo(const char *fname, bool append, const char *fmt, ...);

CHECK: Please use a blank line after function/struct/union/enum declarations
#277: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:675:
+};
+extern int __trace_event_expect(enum trace_events type, int family,

CHECK: extern prototypes should be avoided in .h files
#277: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:675:
+extern int __trace_event_expect(enum trace_events type, int family,

CHECK: Alignment should match open parenthesis
#284: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:682:
+static inline void trace_hash_event_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

CHECK: Alignment should match open parenthesis
#299: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:697:
+static inline void trace_ao_event_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

CHECK: Alignment should match open parenthesis
#315: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:713:
+static inline void trace_ao_event_sk_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

CHECK: Alignment should match open parenthesis
#330: FILE: tools/testing/selftests/net/tcp_ao/lib/aolib.h:728:
+static inline void trace_ao_event_sne_expect(enum trace_events type,
+				union tcp_addr src, union tcp_addr dst,

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#345: 
new file mode 100644

WARNING: static char array declaration should probably be static const char
#362: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:13:
+static char ftrace_path_fmt[] = "ksft-ftrace-XXXXXX";

WARNING: static char array declaration should probably be static const char
#363: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:14:
+static char instance_path_fmt[] = "ksft-XXXXXX";

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#506: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:157:
+	unsigned keyid;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#507: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:158:
+	unsigned rnext;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#508: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:159:
+	unsigned maclen;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#510: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:161:
+	unsigned sne;

CHECK: Comparison to NULL could be written "!opts"
#614: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:265:
+	if (opts == NULL) {

CHECK: Please use a blank line after function/struct/union/enum declarations
#718: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:369:
+};
+static struct trace_events_list *unexpected_events;

WARNING: line length of 87 exceeds 80 columns
#729: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:380:
+		if (!strncmp(trace_event_names[i], line, strlen(trace_event_names[i])))

CHECK: Comparison to NULL could be written "!p"
#762: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:413:
+		if (p == NULL) {

WARNING: line length of 83 exceeds 80 columns
#763: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:414:
+			test_print("Couldn't parse trace event addr:port %s", src);

CHECK: Comparison to NULL could be written "!p"
#777: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:428:
+	if (p == NULL || *addr == NULL) {

CHECK: Comparison to NULL could be written "!addr"
#777: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:428:
+	if (p == NULL || *addr == NULL) {

WARNING: line length of 126 exceeds 80 columns
#830: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:481:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c]",

CHECK: Alignment should match open parenthesis
#831: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:482:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c]",
+			&netns_cookie, &family,

WARNING: line length of 81 exceeds 80 columns
#835: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:486:
+			test_print("Couldn't parse trace event, matched = %d/10",

WARNING: line length of 154 exceeds 80 columns
#844: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:495:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c] keyid=%u rnext=%u maclen=%u",

CHECK: Alignment should match open parenthesis
#845: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:496:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms L3index=%d [%c%c%c%c%c] keyid=%u rnext=%u maclen=%u",
+			&netns_cookie, &family,

WARNING: line length of 81 exceeds 80 columns
#850: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:501:
+			test_print("Couldn't parse trace event, matched = %d/13",

WARNING: line length of 120 exceeds 80 columns
#855: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:506:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms keyid=%u rnext=%u",

CHECK: Alignment should match open parenthesis
#856: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:507:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms keyid=%u rnext=%u",
+			&netns_cookie, &family,

WARNING: line length of 109 exceeds 80 columns
#865: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:516:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms sne=%u",

CHECK: Alignment should match open parenthesis
#866: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:517:
+		nr_matched = sscanf(line, "%*s net=%" PRIu64 " state=%*s family=%ms src=%ms dest=%ms sne=%u",
+			&netns_cookie, &family,

WARNING: line length of 83 exceeds 80 columns
#883: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:534:
+			test_print("Couldn't parse trace event family %s", family);

WARNING: line length of 81 exceeds 80 columns
#901: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:552:
+			test_print("Couldn't parse trace event flags %c%c%c%c%c",

WARNING: line length of 86 exceeds 80 columns
#908: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:559:
+	if (src && tracer_scan_address(out->family, src, &out->src, &out->src_port)) {

WARNING: line length of 86 exceeds 80 columns
#913: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:564:
+	if (dst && tracer_scan_address(out->family, dst, &out->dst, &out->dst_port)) {

WARNING: line length of 118 exceeds 80 columns
#919: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:570:
+		test_print("Net namespace filter for trace event didn't work: %" PRIu64 " != %" PRIu64 " OR %" PRIu64,

CHECK: Unnecessary parentheses around t->line
#955: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:606:
+	free(*(t->line));

WARNING: line length of 82 exceeds 80 columns
#1055: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:706:
+			test_ok("No unexpected trace events during the test run");

ERROR: do not initialise statics to 0
#1138: FILE: tools/testing/selftests/net/tcp_ao/lib/ftrace.c:789:
+	static int already_set = 0;

WARNING: Prefer ____printf__(3, 4) over __attribute__((__format__(__printf__, 3, 4)))
#1252: FILE: tools/testing/selftests/net/tcp_ao/lib/utils.c:24:
+__attribute__((__format__(__printf__, 3, 4)))

WARNING: line length of 83 exceeds 80 columns
#1366: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:197:
+			      port + 1, port + 1, 0, -1, -1, -1, -1, -1, 5, 7, -1);

WARNING: line length of 83 exceeds 80 columns
#1368: FILE: tools/testing/selftests/net/tcp_ao/self-connect.c:199:
+			      port + 1, port + 1, 0, -1, -1, -1, -1, -1, 7, 5, -1);

CHECK: Alignment should match open parenthesis
#1391: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:120:
+	trace_ao_event_sne_expect(TCP_AO_SND_SNE_UPDATE, this_ip_addr,
+			this_ip_dest, test_server_port + 1, client_new_port, 1);

CHECK: Alignment should match open parenthesis
#1393: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:122:
+	trace_ao_event_sne_expect(TCP_AO_SND_SNE_UPDATE, this_ip_dest,
+			this_ip_addr, client_new_port, test_server_port + 1, 1);

CHECK: Alignment should match open parenthesis
#1395: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:124:
+	trace_ao_event_sne_expect(TCP_AO_RCV_SNE_UPDATE, this_ip_addr,
+			this_ip_dest, test_server_port + 1, client_new_port, 1);

CHECK: Alignment should match open parenthesis
#1397: FILE: tools/testing/selftests/net/tcp_ao/seq-ext.c:126:
+	trace_ao_event_sne_expect(TCP_AO_RCV_SNE_UPDATE, this_ip_dest,
+			this_ip_addr, client_new_port, test_server_port + 1, 1);

total: 1 errors, 27 warnings, 26 checks, 1365 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 0c17769a7d64 ("selftest/net: Add trace events matching to tcp_ao") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.