WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #74: new file mode 100644 WARNING: Block comments use * on subsequent lines #89: FILE: tools/testing/selftests/bpf/progs/bpf_compiler.h:11: +/* In GCC -funroll-loops, which is enabled with -O2, should have the + same impact than the loop-unroll-enable pragma above. */ WARNING: Block comments use a trailing */ on a separate line #89: FILE: tools/testing/selftests/bpf/progs/bpf_compiler.h:11: + same impact than the loop-unroll-enable pragma above. */ ERROR: open brace '{' following function definitions go on the next line #129: FILE: tools/testing/selftests/bpf/progs/iters.c:187: + __pragma_loop_no_unroll for (i = 0; i < 3; i++) { ERROR: open brace '{' following function definitions go on the next line #138: FILE: tools/testing/selftests/bpf/progs/iters.c:242: + __pragma_loop_no_unroll for (i = 0; i < 3; i++) { ERROR: open brace '{' following function definitions go on the next line #349: FILE: tools/testing/selftests/bpf/progs/test_cls_redirect.c:273: + __pragma_loop_unroll_full for (size_t i = 0; i < sizeof(struct iphdr) / 2; i++) { ERROR: open brace '{' following function definitions go on the next line #358: FILE: tools/testing/selftests/bpf/progs/test_cls_redirect.c:300: + __pragma_loop_unroll_full for (int i = 0; i < 6; i++) { ERROR: open brace '{' following function definitions go on the next line #380: FILE: tools/testing/selftests/bpf/progs/test_lwt_seg6local.c:136: + __pragma_loop_unroll_full for (int i = 0; i < 10; i++) { ERROR: open brace '{' following function definitions go on the next line #389: FILE: tools/testing/selftests/bpf/progs/test_lwt_seg6local.c:307: + __pragma_loop_unroll_full for (unsigned long long lo = 0; lo < 4; lo++) { ERROR: open brace '{' following function definitions go on the next line #411: FILE: tools/testing/selftests/bpf/progs/test_seg6_loop.c:139: + __pragma_loop_no_unroll for (long i = 0; i < 100; i++) { ERROR: open brace '{' following function definitions go on the next line #431: FILE: tools/testing/selftests/bpf/progs/test_skb_ctx.c:13: + __pragma_loop_unroll_full for (int i = 0; i < 5; i++) { ERROR: open brace '{' following function definitions go on the next line #462: FILE: tools/testing/selftests/bpf/progs/test_sysctl_loop1.c:64: + __pragma_loop_no_unroll for (i = 0; i < ARRAY_SIZE(tcp_mem); ++i) { ERROR: open brace '{' following function definitions go on the next line #493: FILE: tools/testing/selftests/bpf/progs/test_sysctl_loop2.c:62: + __pragma_loop_no_unroll for (i = 0; i < ARRAY_SIZE(tcp_mem); ++i) { ERROR: open brace '{' following function definitions go on the next line #524: FILE: tools/testing/selftests/bpf/progs/test_sysctl_prog.c:62: + __pragma_loop_unroll_full for (i = 0; i < ARRAY_SIZE(tcp_mem); ++i) { ERROR: open brace '{' following function definitions go on the next line #665: FILE: tools/testing/selftests/bpf/progs/xdping_kern.c:120: + __pragma_loop_unroll_full for (i = 0; i < XDPING_MAX_COUNT; i++) { total: 12 errors, 3 warnings, 0 checks, 468 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a3873c36ddcf ("bpf: abstract loop unrolling pragmas in BPF selftests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.