ERROR: Macros with complex values should be enclosed in parentheses #48: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:17: +#define TRANS_SEQ_END \ + 0xFFFF, \ + RTW_PWR_CUT_ALL_MSK, \ + RTW_PWR_INTF_ALL_MSK, \ + 0, \ + RTW_PWR_CMD_END, 0, 0 BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 81 exceeds 80 columns #157: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:126: + {0x0f, 0x0f, 0x0d, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #158: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:127: + {0x10, 0x10, 0x0e, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #159: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:128: + {0x11, 0x11, 0x0f, 0x0c, 0x09, 0x06, 0x03, 0x01}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #193: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:162: + {0x0f, 0x0f, 0x0d, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #194: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:163: + {0x10, 0x10, 0x0e, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #195: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:164: + {0x11, 0x11, 0x0f, 0x09, 0x00, 0x00, 0x00, 0x00}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #222: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:191: +#define RTW_CCK_SWING_TABLE_SIZE ARRAY_SIZE(rtw8723b_cck_swing_table_ch14) WARNING: line length of 81 exceeds 80 columns #1301: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1270: +static void rtw8723b_query_phy_status_ofdm(struct rtw_dev *rtwdev, void *phy_raw, WARNING: line length of 82 exceeds 80 columns #1314: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1283: + pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2); WARNING: line length of 82 exceeds 80 columns #1515: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1484: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0003f); WARNING: line length of 82 exceeds 80 columns #1516: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1485: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xc7f87); WARNING: line length of 82 exceeds 80 columns #1582: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1551: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1583: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1552: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7fb7); WARNING: line length of 82 exceeds 80 columns #1647: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1616: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1648: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1617: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7d77); WARNING: line length of 81 exceeds 80 columns #1832: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1801: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_ADDR, RFREG_MASK, 0x30000); WARNING: line length of 82 exceeds 80 columns #1833: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1802: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1834: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1803: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7fb7); WARNING: line length of 84 exceeds 80 columns #1927: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1896: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, 0x50); WARNING: line length of 91 exceeds 80 columns #1928: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1897: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, backup.igia); WARNING: line length of 81 exceeds 80 columns #1936: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1905: + good = rtw8723x_iqk_similarity_cmp(rtwdev, result, j, i); WARNING: line length of 81 exceeds 80 columns #1982: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1951: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_ADDR, RFREG_MASK, 0x18000); WARNING: line length of 82 exceeds 80 columns #1983: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1952: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1984: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1953: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xe6177); WARNING: line length of 84 exceeds 80 columns #2074: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2043: + final_ofdm_swing_index - limit_ofdm); WARNING: line length of 88 exceeds 80 columns #2079: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2048: + rtw8723b_pwrtrack_set_ofdm_pwr(rtwdev, path, final_ofdm_swing_index, 0); WARNING: line length of 81 exceeds 80 columns #2083: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2052: + final_cck_swing_index - limit_cck); WARNING: line length of 83 exceeds 80 columns #2214: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2183: + rtw_write8_mask(rtwdev, REG_RFE_CTRL_ANT_SW, BIT_RFE_CTRL_ANT_SW_SEL, 0x3); total: 1 errors, 28 warnings, 0 checks, 2548 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8bf624e22919 ("wifi: rtw88: 8723b: add the RTL8723B chip driver") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.