ERROR: Macros with complex values should be enclosed in parentheses #52: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:22: +#define TRANS_SEQ_END \ + 0xFFFF, \ + RTW_PWR_CUT_ALL_MSK, \ + RTW_PWR_INTF_ALL_MSK, \ + 0, \ + RTW_PWR_CMD_END, 0, 0 BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 81 exceeds 80 columns #172: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:142: + {0x0f, 0x0f, 0x0d, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #173: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:143: + {0x10, 0x10, 0x0e, 0x0b, 0x08, 0x05, 0x03, 0x01}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #174: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:144: + {0x11, 0x11, 0x0f, 0x0c, 0x09, 0x06, 0x03, 0x01}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #208: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:178: + {0x0f, 0x0f, 0x0d, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 10, -11.0dB */ WARNING: line length of 81 exceeds 80 columns #209: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:179: + {0x10, 0x10, 0x0e, 0x08, 0x00, 0x00, 0x00, 0x00}, /* 11, -10.5dB */ WARNING: line length of 81 exceeds 80 columns #210: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:180: + {0x11, 0x11, 0x0f, 0x09, 0x00, 0x00, 0x00, 0x00}, /* 12, -10.0dB */ WARNING: line length of 81 exceeds 80 columns #237: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:207: +#define RTW_CCK_SWING_TABLE_SIZE ARRAY_SIZE(rtw8723b_cck_swing_table_ch14) WARNING: line length of 81 exceeds 80 columns #1301: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1271: + struct phy_status_8703b *phy_status = (struct phy_status_8703b *)phy_raw; WARNING: line length of 81 exceeds 80 columns #1319: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1289: + struct phy_status_8703b *phy_status = (struct phy_status_8703b *)phy_raw; WARNING: line length of 82 exceeds 80 columns #1329: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1299: + pkt_stat->rx_snr[RF_PATH_A] = (s8)(phy_status->path_rxsnr[RF_PATH_A] / 2); WARNING: line length of 82 exceeds 80 columns #1530: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1500: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0003f); WARNING: line length of 82 exceeds 80 columns #1531: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1501: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xc7f87); WARNING: line length of 82 exceeds 80 columns #1597: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1567: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1598: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1568: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7fb7); WARNING: line length of 82 exceeds 80 columns #1662: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1632: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1663: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1633: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7d77); WARNING: line length of 81 exceeds 80 columns #1847: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1817: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_ADDR, RFREG_MASK, 0x30000); WARNING: line length of 82 exceeds 80 columns #1848: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1818: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1849: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1819: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xf7fb7); WARNING: line length of 84 exceeds 80 columns #1942: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1912: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, 0x50); WARNING: line length of 91 exceeds 80 columns #1943: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1913: + rtw_write32_mask(rtwdev, REG_OFDM0_XAAGC1, MASKBYTE0, backup.igia); WARNING: line length of 81 exceeds 80 columns #1951: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1921: + good = rtw8723x_iqk_similarity_cmp(rtwdev, result, j, i); WARNING: line length of 81 exceeds 80 columns #1997: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1967: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_ADDR, RFREG_MASK, 0x18000); WARNING: line length of 82 exceeds 80 columns #1998: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1968: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA0, RFREG_MASK, 0x0001f); WARNING: line length of 82 exceeds 80 columns #1999: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:1969: + rtw_write_rf(rtwdev, RF_PATH_A, RF_MODE_TABLE_DATA1, RFREG_MASK, 0xe6177); WARNING: line length of 84 exceeds 80 columns #2089: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2059: + final_ofdm_swing_index - limit_ofdm); WARNING: line length of 88 exceeds 80 columns #2094: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2064: + rtw8723b_pwrtrack_set_ofdm_pwr(rtwdev, path, final_ofdm_swing_index, 0); WARNING: line length of 81 exceeds 80 columns #2098: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2068: + final_cck_swing_index - limit_cck); WARNING: line length of 83 exceeds 80 columns #2229: FILE: drivers/net/wireless/realtek/rtw88/rtw8723b.c:2199: + rtw_write8_mask(rtwdev, REG_RFE_CTRL_ANT_SW, BIT_RFE_CTRL_ANT_SW_SEL, 0x3); total: 1 errors, 29 warnings, 0 checks, 2564 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 894d03ef29ec ("wifi: rtw88: 8723b: add the RTL8723B chip driver") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.