WARNING: line length of 86 exceeds 80 columns #55: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1063: + le32_get_bits(phy_data->ntfy->sigs.eht_tb.tb_rx1, WARNING: line length of 87 exceeds 80 columns #97: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1353: + IEEE80211_RADIOTAP_UHR_USIG1_TB_B20_B25_DISREGARD); WARNING: line length of 85 exceeds 80 columns #100: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1356: + IEEE80211_RADIOTAP_UHR_USIG2_TB_B0_B1_PPDU_TYPE); WARNING: line length of 81 exceeds 80 columns #102: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1358: + IEEE80211_RADIOTAP_UHR_USIG2_MU_B2_COBF_COSR, WARNING: line length of 81 exceeds 80 columns #103: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1359: + IEEE80211_RADIOTAP_UHR_USIG2_TB_B2_VALIDATE); WARNING: line length of 91 exceeds 80 columns #106: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1362: + IEEE80211_RADIOTAP_UHR_USIG2_TB_B3_B6_SPATIAL_REUSE_1); WARNING: line length of 92 exceeds 80 columns #109: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1365: + IEEE80211_RADIOTAP_UHR_USIG2_TB_B7_B10_SPATIAL_REUSE_2); WARNING: line length of 87 exceeds 80 columns #112: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1368: + IEEE80211_RADIOTAP_UHR_USIG2_TB_B11_B15_DISREGARD); WARNING: line length of 97 exceeds 80 columns #116: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1372: + usig->common |= cpu_to_le32(IEEE80211_RADIOTAP_EHT_USIG_COMMON_VALIDATE_BITS_OK); WARNING: line length of 93 exceeds 80 columns #119: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1375: + usig->common |= cpu_to_le32(IEEE80211_RADIOTAP_EHT_USIG_COMMON_BAD_USIG_CRC); WARNING: line length of 81 exceeds 80 columns #123: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1379: + struct ieee80211_radiotap_eht_usig *usig) WARNING: line length of 88 exceeds 80 columns #130: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1386: + IEEE80211_RADIOTAP_UHR_USIG1_ELR_B20_B24_DISREGARD); WARNING: line length of 83 exceeds 80 columns #133: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1389: + IEEE80211_RADIOTAP_UHR_USIG1_ELR_B25_VALIDATE); WARNING: line length of 86 exceeds 80 columns #136: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1392: + IEEE80211_RADIOTAP_UHR_USIG2_ELR_B0_B1_PPDU_TYPE); WARNING: line length of 84 exceeds 80 columns #139: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1395: + IEEE80211_RADIOTAP_UHR_USIG2_ELR_B2_B12_STA_ID); WARNING: line length of 87 exceeds 80 columns #142: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1398: + IEEE80211_RADIOTAP_UHR_USIG2_ELR_B13_B15_VALIDATE); WARNING: line length of 97 exceeds 80 columns #146: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1402: + usig->common |= cpu_to_le32(IEEE80211_RADIOTAP_EHT_USIG_COMMON_VALIDATE_BITS_OK); WARNING: line length of 93 exceeds 80 columns #149: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1405: + usig->common |= cpu_to_le32(IEEE80211_RADIOTAP_EHT_USIG_COMMON_BAD_USIG_CRC); WARNING: line length of 84 exceeds 80 columns #153: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1409: + struct ieee80211_radiotap_eht_usig *usig) WARNING: line length of 87 exceeds 80 columns #160: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1416: + IEEE80211_RADIOTAP_UHR_USIG1_MU_B20_B24_DISREGARD); WARNING: line length of 82 exceeds 80 columns #163: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1419: + IEEE80211_RADIOTAP_UHR_USIG1_MU_B25_VALIDATE); WARNING: line length of 85 exceeds 80 columns #166: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1422: + IEEE80211_RADIOTAP_UHR_USIG2_MU_B0_B1_PPDU_TYPE); WARNING: line length of 82 exceeds 80 columns #169: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1425: + IEEE80211_RADIOTAP_UHR_USIG2_MU_B2_COBF_COSR); WARNING: line length of 90 exceeds 80 columns #172: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1428: + IEEE80211_RADIOTAP_UHR_USIG2_MU_B3_B7_PUNCTURED_INFO); WARNING: line length of 81 exceeds 80 columns #175: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1431: + IEEE80211_RADIOTAP_UHR_USIG2_MU_B8_VALIDATE); WARNING: line length of 84 exceeds 80 columns #178: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1434: + IEEE80211_RADIOTAP_UHR_USIG2_MU_B9_B10_SIG_MCS); WARNING: line length of 93 exceeds 80 columns #181: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1437: + IEEE80211_RADIOTAP_UHR_USIG2_MU_B11_B15_UHR_SIG_SYMBOLS); WARNING: line length of 97 exceeds 80 columns #185: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1441: + usig->common |= cpu_to_le32(IEEE80211_RADIOTAP_EHT_USIG_COMMON_VALIDATE_BITS_OK); WARNING: line length of 93 exceeds 80 columns #188: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1444: + usig->common |= cpu_to_le32(IEEE80211_RADIOTAP_EHT_USIG_COMMON_BAD_USIG_CRC); WARNING: line length of 84 exceeds 80 columns #207: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1463: + usig->common |= cpu_to_le32(IEEE80211_RADIOTAP_EHT_USIG_COMMON_UL_DL_KNOWN | WARNING: line length of 88 exceeds 80 columns #208: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1464: + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BSS_COLOR_KNOWN | WARNING: line length of 94 exceeds 80 columns #209: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1465: + IEEE80211_RADIOTAP_EHT_USIG_COMMON_VALIDATE_BITS_CHECKED | WARNING: line length of 81 exceeds 80 columns #210: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1466: + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BW_KNOWN | WARNING: line length of 83 exceeds 80 columns #211: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1467: + IEEE80211_RADIOTAP_EHT_USIG_COMMON_TXOP_KNOWN | WARNING: line length of 86 exceeds 80 columns #212: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1468: + IEEE80211_RADIOTAP_EHT_USIG_COMMON_PHY_VER_KNOWN); WARNING: line length of 82 exceeds 80 columns #231: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1487: + usig->common |= LE32_DEC_ENC(usig_a1, OFDM_RX_FRAME_ENHANCED_WIFI_UL_FLAG, WARNING: line length of 84 exceeds 80 columns #233: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1489: + usig->common |= LE32_DEC_ENC(usig_a1, OFDM_RX_FRAME_ENHANCED_WIFI_BSS_COLOR, WARNING: line length of 83 exceeds 80 columns #234: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1490: + IEEE80211_RADIOTAP_EHT_USIG_COMMON_BSS_COLOR); WARNING: line length of 81 exceeds 80 columns #240: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1496: + IEEE80211_RADIOTAP_EHT_USIG_COMMON_PHY_VER); WARNING: line length of 85 exceeds 80 columns #262: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1518: + uhr->known |= cpu_to_le32(IEEE80211_RADIOTAP_UHR_KNOWN_DRU_RRU_ALLOC_TB_FMT | WARNING: line length of 90 exceeds 80 columns #263: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1519: + IEEE80211_RADIOTAP_UHR_KNOWN_LDPC_EXTRA_SYMBOL_SEGMENT | WARNING: line length of 87 exceeds 80 columns #264: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1520: + IEEE80211_RADIOTAP_UHR_KNOWN_PRE_FEC_PADDING_FACTOR | WARNING: line length of 90 exceeds 80 columns #266: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1522: + IEEE80211_RADIOTAP_UHR_KNOWN_NUMBER_OF_UHR_LTF_SYMBOLS | WARNING: line length of 95 exceeds 80 columns #271: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1527: + IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_ALLOC_TB_FMT_PS_160); WARNING: line length of 91 exceeds 80 columns #274: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1530: + IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_ALLOC_TB_FMT_B0 | WARNING: line length of 94 exceeds 80 columns #275: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1531: + IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_ALLOC_TB_FMT_B7_B1); WARNING: line length of 91 exceeds 80 columns #276: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1532: + uhr->data[8] |= le32_encode_bits(!le32_get_bits(phy_data->ntfy->sigs.uhr_tb.tb_rx0, WARNING: line length of 90 exceeds 80 columns #278: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1534: + IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_INDICATION); WARNING: line length of 93 exceeds 80 columns #282: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1538: + IEEE80211_RADIOTAP_UHR_DATA0_LDPC_EXTRA_SYMBOL_SEGMENT); WARNING: line length of 90 exceeds 80 columns #285: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1541: + IEEE80211_RADIOTAP_UHR_DATA0_PRE_FEC_PADDING_FACTOR); WARNING: line length of 83 exceeds 80 columns #288: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1544: + IEEE80211_RADIOTAP_UHR_DATA0_PE_DISAMBIGUITY); WARNING: line length of 89 exceeds 80 columns #291: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1547: + IEEE80211_RADIOTAP_UHR_DATA0_NUMBER_OF_LTF_SYMBOLS); WARNING: line length of 82 exceeds 80 columns #294: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1550: + IEEE80211_RADIOTAP_UHR_DATA1_PRI80_CHAN_POS); WARNING: line length of 86 exceeds 80 columns #297: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1553: + le32_get_bits(phy_data->ntfy->sigs.uhr_tb.tb_rx1, ERROR: Macros with complex values should be enclosed in parentheses #310: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1566: +#define __IWL_MLD_ENC_UHR_RU(rt_data, rt_ru, fw_data, fw_ru) \ + uhr->data[(rt_data)] |= \ + (cpu_to_le32(IEEE80211_RADIOTAP_UHR_DATA ## rt_data ## _RU_ALLOC_CC_ ## rt_ru ## _KNOWN) | \ + LE32_DEC_ENC(phy_data->ntfy->sigs.uhr.cmn[fw_data], \ + OFDM_RX_FRAME_EHT_RU_ALLOC_ ## fw_data ## _ ## fw_ru, \ + IEEE80211_RADIOTAP_UHR_DATA ## rt_data ## _RU_ALLOC_CC_ ## rt_ru)) BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. WARNING: line length of 108 exceeds 80 columns #312: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1568: + (cpu_to_le32(IEEE80211_RADIOTAP_UHR_DATA ## rt_data ## _RU_ALLOC_CC_ ## rt_ru ## _KNOWN) | \ WARNING: line length of 85 exceeds 80 columns #314: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1570: + OFDM_RX_FRAME_EHT_RU_ALLOC_ ## fw_data ## _ ## fw_ru, \ WARNING: line length of 96 exceeds 80 columns #315: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1571: + IEEE80211_RADIOTAP_UHR_DATA ## rt_data ## _RU_ALLOC_CC_ ## rt_ru)) WARNING: line length of 84 exceeds 80 columns #418: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1674: + /* All RU allocating size/index is in TB format */ WARNING: line length of 85 exceeds 80 columns #419: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1675: + IEEE80211_RADIOTAP_UHR_KNOWN_DRU_RRU_ALLOC_TB_FMT | WARNING: line length of 90 exceeds 80 columns #420: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1676: + IEEE80211_RADIOTAP_UHR_KNOWN_LDPC_EXTRA_SYMBOL_SEGMENT | WARNING: line length of 87 exceeds 80 columns #421: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1677: + IEEE80211_RADIOTAP_UHR_KNOWN_PRE_FEC_PADDING_FACTOR | WARNING: line length of 90 exceeds 80 columns #424: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1680: + IEEE80211_RADIOTAP_UHR_KNOWN_NUMBER_OF_NON_OFDMA_USERS | WARNING: line length of 88 exceeds 80 columns #425: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1681: + IEEE80211_RADIOTAP_UHR_KNOWN_INTERFERENCE_MITIGATION); WARNING: line length of 81 exceeds 80 columns #429: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1685: + IEEE80211_RADIOTAP_UHR_DATA0_SPATIAL_REUSE); WARNING: line length of 95 exceeds 80 columns #432: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1688: + IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_ALLOC_TB_FMT_PS_160); WARNING: line length of 91 exceeds 80 columns #435: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1691: + IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_ALLOC_TB_FMT_B0 | WARNING: line length of 94 exceeds 80 columns #436: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1692: + IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_ALLOC_TB_FMT_B7_B1); WARNING: line length of 85 exceeds 80 columns #438: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1694: + uhr->data[8] |= cpu_to_le32(IEEE80211_RADIOTAP_UHR_DATA8_DRU_RRU_INDICATION); WARNING: line length of 93 exceeds 80 columns #442: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1698: + IEEE80211_RADIOTAP_UHR_DATA0_LDPC_EXTRA_SYMBOL_SEGMENT); WARNING: line length of 90 exceeds 80 columns #445: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1701: + IEEE80211_RADIOTAP_UHR_DATA0_PRE_FEC_PADDING_FACTOR); WARNING: line length of 83 exceeds 80 columns #448: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1704: + IEEE80211_RADIOTAP_UHR_DATA0_PE_DISAMBIGUITY); WARNING: line length of 82 exceeds 80 columns #451: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1707: + IEEE80211_RADIOTAP_UHR_DATA1_PRI80_CHAN_POS); WARNING: line length of 93 exceeds 80 columns #454: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1710: + IEEE80211_RADIOTAP_UHR_DATA7_NUMBER_OF_NON_OFDMA_USERS); WARNING: line length of 91 exceeds 80 columns #458: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1714: + IEEE80211_RADIOTAP_UHR_DATA7_INTERFERENCE_MITIGATION); WARNING: line length of 84 exceeds 80 columns #470: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1726: + uhr->user[0].known |= cpu_to_le32(IEEE80211_RADIOTAP_UHR_USER_KNOWN_STA_ID); WARNING: line length of 83 exceeds 80 columns #473: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1729: + IEEE80211_RADIOTAP_UHR_USER_INFO_STA_ID); WARNING: line length of 85 exceeds 80 columns #487: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1743: + if (uhr->user[0].info & cpu_to_le32(IEEE80211_RADIOTAP_UHR_USER_INFO_UEQM)) { WARNING: line length of 84 exceeds 80 columns #489: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1745: + cpu_to_le32(IEEE80211_RADIOTAP_UHR_USER_KNOWN_UEQM_PATTERN); WARNING: line length of 84 exceeds 80 columns #493: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1749: + IEEE80211_RADIOTAP_UHR_USER_INFO_UEQM_PATTERN); WARNING: line length of 88 exceeds 80 columns #514: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1770: + IEEE80211_RADIOTAP_UHR_ELR_KNOWN_LDPC_EXTRA_OFDM_SYM | WARNING: line length of 86 exceeds 80 columns #517: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1773: + IEEE80211_RADIOTAP_UHR_ELR_KNOWN_SIG_1_CRC_CHECKED | WARNING: line length of 86 exceeds 80 columns #518: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1774: + IEEE80211_RADIOTAP_UHR_ELR_KNOWN_SIG_2_CRC_CHECKED | WARNING: line length of 83 exceeds 80 columns #519: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1775: + IEEE80211_RADIOTAP_UHR_ELR_KNOWN_MARK_BSS_COLOR); WARNING: line length of 87 exceeds 80 columns #531: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1787: + IEEE80211_RADIOTAP_UHR_ELR_SIG1_LDPC_EXTRA_OFDM_SYM); WARNING: line length of 83 exceeds 80 columns #569: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1825: + IEEE80211_RADIOTAP_UHR_DATA0_GI_LTF_SIZE); WARNING: line length of 85 exceeds 80 columns #576: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1832: + IEEE80211_RADIOTAP_UHR_USER_KNOWN_USER_CAPTURED); WARNING: line length of 86 exceeds 80 columns #585: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1841: + cpu_to_le32(IEEE80211_RADIOTAP_UHR_USER_INFO_2X_LDPC); WARNING: line length of 85 exceeds 80 columns #589: FILE: drivers/net/wireless/intel/iwlwifi/mld/rx.c:1845: + cpu_to_le32(IEEE80211_RADIOTAP_UHR_USER_INFO_CODING); total: 1 errors, 88 warnings, 0 checks, 638 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 49f290edecf9 ("wifi: iwlwifi: mld: add UHR sniffer support") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.