1: 0bfe93c523d7 ! 1: 4a55aa01a03e wifi: mac80211: Guard FILS discovery and unsolicited broadcast probe response @@ Commit message  Currently in user-space there is no restriction on sending this for non-transmitting BSS, thus it may send these for those BSSs as well. - However the driver will use the config only for transmitting BSS and - ignore for non-transmitting BSS. Returning an error here, even if - user-space sets these, could be fatal because failing start_ap or - update_ap operation would result in failure of bringing up those BSSs. - Thus, ignore the config for non-transmitting BSS silently. + While this is not a valid configuration, returning an error here could + be fatal because failing 'start_ap' or 'update_ap' operation would result + in failure of bringing up those BSSs. Thus, to maintain the compatibility + with existing user-space, ignore the config for non-transmitting BSS silently.  Signed-off-by: Manish Dharanenthiran   @@ net/mac80211/cfg.c: static int ieee80211_set_fils_discovery(struct ieee80211_sub   - if (!params->update)  + /* -+ * Only transmitting BSS should set this config, ignore this config for -+ * non-transmitting BSS silently even if user-space sets it, as -+ * returning error would result in failure of bringing up of those BSSs. ++ * This configuration is only applicable to transmitting BSSes. ++ * ++ * Current user-space version may also set this for non-transmitting ++ * BSSes. While this is not a valid configuration, to maintain the ++ * compatibility with the existing user-space ignore the configuration ++ * for non-transmitting BSS silently.  + */  + if (!params->update || link_conf->nontransmitted) return 0; @@ net/mac80211/cfg.c: ieee80211_set_unsol_bcast_probe_resp(struct ieee80211_sub_if   - if (!params->update)  + /* -+ * Only transmitting BSS should set this config, ignore this config for -+ * non-transmitting BSS silently even if user-space sets it, as -+ * returning error would result in failure of bringing up of those BSSs. ++ * This configuration is only applicable to transmitting BSSes. ++ * ++ * Current user-space version may also set this for non-transmitting ++ * BSSes. While this is not a valid configuration, to maintain the ++ * compatibility with the existing user-space ignore the configuration ++ * for non-transmitting BSS silently.  + */  + if (!params->update || link_conf->nontransmitted) return 0;